Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-19 Thread Paul Vriens
On 05/20/2010 07:55 AM, Paul Vriens wrote: On 05/20/2010 01:15 AM, Michael Stefaniuc wrote: The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW returns NULL there is a crash. --- dlls/msi/msi.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/msi/ms

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-19 Thread Paul Vriens
On 05/20/2010 01:15 AM, Michael Stefaniuc wrote: The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW returns NULL there is a crash. --- dlls/msi/msi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 3170e6d..9

performance bot results - this time with screensaver off

2010-05-19 Thread Dan Kegel
Every benchmark did at least a little better, and 3dmark2001 did a lot better, today: http://kegel.com/wine/yagmarkdata/E8400-GT_220-Ubuntu_10.04_LTS-e8400-wine-1.1.44-322.html Why? Well, there are oodles of processes running in Gnome by default, plus the workrave app I use for my RSI. I had kil

Re: comctl32/listview: Don't forward WM_COMMAND to parent if we don't have an Edit box

2010-05-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2163 Your paranoid android.

Re: quartz: Avoid using the long type.

2010-05-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2159 Your paranoid android.

Re: software built and worked under wine but not in vista?

2010-05-19 Thread Hin-Tak Leung
--- On Wed, 19/5/10, Saulius Krasuckas wrote: > I sorry for stepping into Alexandre's > or Dmitry's shoes, but.. > > * On Tue, 18 May 2010, Hin-Tak Leung wrote: > > > > So it seems that setupgs.exe is mis-compiled under > wine with win7 sdk > > but just happened to also work under wine. Any id

Re: software built and worked under wine but not in vista?

2010-05-19 Thread Saulius Krasuckas
I sorry for stepping into Alexandre's or Dmitry's shoes, but.. * On Tue, 18 May 2010, Hin-Tak Leung wrote: > > So it seems that setupgs.exe is mis-compiled under wine with win7 sdk > but just happened to also work under wine. Any idea how it might happen? ... there could be a pair of bugs: one

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Roderick Colenbrander
On Wed, May 19, 2010 at 7:02 PM, Henri Verbeet wrote: > On 19 May 2010 14:46, Roderick Colenbrander wrote: >>> The main issue I'm facing is p8 uploads which are completely broken >>> right now (a regression). At the beginning of the week I wanted to add > ... >> What do you think? >> > Is there a

Re: The WineHQ About page needs a picture

2010-05-19 Thread Frank Richter
On 19.05.2010 17:03, Scott Ritchie wrote: > I was doing some housecleaning work looking at the WineHQ website, and I > realized we still have an awful lot of flat, wide text on the About > page. This is the perfect place to collapse it into a column and fill > the right side of the screen with an

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Henri Verbeet
On 19 May 2010 14:46, Roderick Colenbrander wrote: >> The main issue I'm facing is p8 uploads which are completely broken >> right now (a regression). At the beginning of the week I wanted to add ... > What do you think? > Is there a bug report / demo application that clearly shows the problem? Ma

Re: The WineHQ About page needs a picture

2010-05-19 Thread David Gerard
On 19 May 2010 16:03, Scott Ritchie wrote: > I was doing some housecleaning work looking at the WineHQ website, and I > realized we still have an awful lot of flat, wide text on the About > page.  This is the perfect place to collapse it into a column and fill > the right side of the screen with

Re: wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-19 Thread Juan Lang
> I don't see a good reason for writing small http server in tests. It's a lot > of work. Certificate verification errors can be checked in crypt32 tests, it > can be done locally (there are already some tests). The crypt32 tests don't demonstrate the change you're making. wininet (and winhttp) r

The WineHQ About page needs a picture

2010-05-19 Thread Scott Ritchie
I was doing some housecleaning work looking at the WineHQ website, and I realized we still have an awful lot of flat, wide text on the About page. This is the perfect place to collapse it into a column and fill the right side of the screen with an image. But...what image? Thanks, Scott Ritchie

Re: [PATCH 4/4] wininet: Fix variables values after redirection in HTTP_HttpSendRequestW

2010-05-19 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/wininet/http.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:405: Test failed: expected status 10 (INTERN

Heaven 2 benchmark in good shape...

2010-05-19 Thread Dan Kegel
Yesterday's performance bot results, http://kegel.com/wine/yagmarkdata/E8400-GT_220-Ubuntu_10.04_LTS-e8400-wine-1.1.44-290.html show that the Heaven 2 d3d9 benchmark had a couple 10% improvements in the past week (up from 10 to 11 and then 12 fps). If we're going to see improvements in a benchmark,

Re: wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-19 Thread Dan Kegel
On Wed, May 19, 2010 at 5:27 AM, Piotr Caban wrote: >> Or look at how Chromium does its ssl unit tests, by launching a little >> server written in python: >> >> http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=net/socket/ssl_test_util.cc >> >> http://src.chromium.org/cgi-bin/gitw

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Roderick Colenbrander
On Wed, May 19, 2010 at 11:30 AM, Roderick Colenbrander wrote: >>> At a later stage I might disallow calling set_shader when we don't need the >>> shader. >> How does the caller know when a shader is needed? >> > > In the end set_shader will only be called by blit_shader->blit_surface. > > The ma

Re: wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-19 Thread Piotr Caban
On 05/19/10 07:40, Dan Kegel wrote: Test can't be easily added to wine because we don't have pages to test certificate errors on. That should be addressed, no? E.g. with a page hosted at winehq.org with a self-signed certificate? It's writing a test case for one of possible errors. It won't pr

Re: d3dx9: Add some version-specific checks in the shader assembler.

2010-05-19 Thread Matteo Bruni
2010/5/19 Stefan Dösinger : > > Am 18.05.2010 um 14:55 schrieb Matteo Bruni: >> +    if(!check_reg_type(src, vs_3_reg_allowed)) { >> +        asmparser_message(This, "Line %u: Source register %s not supported >> in VS 3.0\n", >> +                          This->line_no, >> +                      

Re: winemp3.acm: Fixes the Mac-specific code (try 2)

2010-05-19 Thread Aric Stewart
Hi, I was excited to try out this patch but now it is giving me a crash. (OS/X 10.5.8) Backtrace: =>0 0x12a9 (0x0033d81c) 1 0x086e (0x0033d838) 2 0x936f5a47 _ZN14CodecConverter14AppendNewInputEmPcmRmP28AudioStreamPacketDescription+0xb6() in audiotoolbox (0x0033d888) 3 0x936f56

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Roderick Colenbrander
>> At a later stage I might disallow calling set_shader when we don't need the >> shader. > How does the caller know when a shader is needed? > In the end set_shader will only be called by blit_shader->blit_surface. The main issue I'm facing is p8 uploads which are completely broken right now (a

Re: d3dx9: Add some version-specific checks in the shader assembler.

2010-05-19 Thread Stefan Dösinger
Am 18.05.2010 um 14:55 schrieb Matteo Bruni: > +if(!check_reg_type(src, vs_3_reg_allowed)) { > +asmparser_message(This, "Line %u: Source register %s not supported > in VS 3.0\n", > + This->line_no, > + debug_print_srcreg(src, ST_VERTEX

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Henri Verbeet
On 19 May 2010 09:56, Stefan Dösinger wrote: > > Am 19.05.2010 um 00:38 schrieb Roderick Colenbrander: > >> This patch series removes the responsibility for enabling/disabling the >> texture_target from the 'set_shader' stage of the blit_shader. > I disagree with this patch. glEnable(GL_TEXTURE_2D

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Stefan Dösinger
Am 19.05.2010 um 00:38 schrieb Roderick Colenbrander: > This patch series removes the responsibility for enabling/disabling the > texture_target from the 'set_shader' stage of the blit_shader. I disagree with this patch. glEnable(GL_TEXTURE_2D) is the fixed function pipline's way of putting the

Re: Work on WineQuartz for MacOSX

2010-05-19 Thread Mike Kronenberg
On 18.05.2010, at 17:53, Roderick Colenbrander wrote: > On Tue, May 18, 2010 at 3:12 PM, Mike Kronenberg > wrote: >> On 17.05.2010, at 07:52, Charles Davis wrote: >> >>> On 5/16/10 9:04 PM, James Mckenzie wrote: Roderick Colenbrander wrote: > On Sun, May 16, 2010 at 6:02 PM, C.W. Betts