re: wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Dan Kegel
>> Test can't be easily added to wine because we don't have pages to test >> certificate errors on. > >That should be addressed, no? E.g. with a page hosted at winehq.org >with a self-signed certificate? Or look at how Chromium does its ssl unit tests, by launching a little server written in pyth

Re: [PATCH 2/4] wininet: Added INTERNET_OPTION_ERROR_MASK flag handling to InternetSetOptionW (try2)

2010-05-18 Thread Austin English
On Tue, May 18, 2010 at 8:28 PM, Piotr Caban wrote: > Try2: >  - Commented out test that fails on Win2000 (there were no new failures on > Win98). Any reason you didn't use broken() instead? -- -Austin

Re: ntdll: add stub for NtRaiseHardError (try 2)

2010-05-18 Thread James McKenzie
Austin English wrote: On Tue, May 18, 2010 at 1:17 PM, Austin English wrote: This time returning STATUS_NOT_IMPLEMENTED instead of E_NOTIMPL, to match the rest of ntdll. Thanks to Juan for pointing that out. Today's not my day... Wasn't mine either. Spent the entire day at 'work'

Re: Steam hardware survey causing crashes (so next round of statistics will under-represent Wine users)

2010-05-18 Thread Edward Savage
On Wed, May 19, 2010 at 9:36 AM, Scott Ritchie wrote: > Just a small note but occasionally we hear from Valve about steam > statistics and the percentage of Wine users. > > I just got a crash from running the survey.  It makes me pretty unlikely > to click the button again, even if it doesn't cras

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Juan Lang
> Test can't be easily added to wine because we don't have pages to test > certificate errors on. That should be addressed, no? E.g. with a page hosted at winehq.org with a self-signed certificate? That'd at least allow us to check the expected error when the root of a certificate chain is untru

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Piotr Caban
Hi, On 05/19/10 02:01, Juan Lang wrote: +if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT) && ( +res == ERROR_INTERNET_SEC_CERT_DATE_INVALID +|| res == ERROR_INTERNET_INVALID_CA +|| res == ERROR_INTERNET_SEC_C

Re: [PATCH 2/4] wininet: Added INTERNET_OPTION_ERROR_MASK flag handling to InternetSetOptionW

2010-05-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2142 Your paranoid android.

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Juan Lang
Hi Piotr, +if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT) && ( +res == ERROR_INTERNET_SEC_CERT_DATE_INVALID +|| res == ERROR_INTERNET_INVALID_CA +|| res == ERROR_INTERNET_SEC_CERT_NO_REV +|

Steam hardware survey causing crashes (so next round of statistics will under-represent Wine users)

2010-05-18 Thread Scott Ritchie
Just a small note but occasionally we hear from Valve about steam statistics and the percentage of Wine users. I just got a crash from running the survey. It makes me pretty unlikely to click the button again, even if it doesn't crash in the future. I imagine other users would feel similarly. T

software built and worked under wine but not in vista?

2010-05-18 Thread Hin-Tak Leung
I have encountered a slightly strange issue with building the windows self-extracting installer release of ghostscript (http://www.ghostscript.com/) - the self-extracting installer is created with the winzip self-extractor package, which can be manually unzipped. The curious thing is that I can

autoconf 2.62 failure due to AS_VAR_IF

2010-05-18 Thread Gerald Pfeifer
Using autoconf 2.62 on my primary test system I am getting: configure:26081: error: possibly undefined macro: AS_VAR_IF Indeed use of AS_VAR_IF appears relatively new, and it seems this may be similar to AS_VAR_APPEND where we have the following in configure.ac: dnl autoconf versions before

Re: Re²: SONAME_LIBFONTCONFIG undeclared

2010-05-18 Thread Austin English
On Tue, May 18, 2010 at 3:08 PM, GOUJON Alexandre wrote: > Le 05/18/10 20:39, GOUJON Alexandre a écrit : >> >> xrender.c: In function 'X11DRV_XRender_Init': >> xrender.c:398: error: 'SONAME_LIBFONTCONFIG' undeclared (first use in this >> function) > > In fact, the 398th line is >    if ((fontconfi

Re²: SONAME_LIBFONTCONFIG undeclared

2010-05-18 Thread GOUJON Alexandre
Le 05/18/10 20:39, GOUJON Alexandre a écrit : xrender.c: In function 'X11DRV_XRender_Init': xrender.c:398: error: 'SONAME_LIBFONTCONFIG' undeclared (first use in this function) In fact, the 398th line is if ((fontconfig_handle = wine_dlopen(SONAME_LIBFONTCONFIG, RTLD_NOW, NULL, 0))) and

Re: SONAME_LIBFONTCONFIG undeclared

2010-05-18 Thread GOUJON Alexandre
Lei Zhang wrote: Works fine here on Ubuntu Hardy with today's wine-git. Do you have all the build dependencies? http://wiki.winehq.org/Recommended_Packages Yep. But now you're talking about dependencies I'm thinking I recently installed xrandr headers. My mistake. I will run make distclea

Re: SONAME_LIBFONTCONFIG undeclared

2010-05-18 Thread Lei Zhang
On Tue, May 18, 2010 at 11:39 AM, GOUJON Alexandre wrote: > Hi, > > I just updated my local tree and ran CFLAGS="-g -O0" ./configure > --disable-tests && make > and I got > > xrender.c:411: warning: implicit declaration of function 'pFcInit' > xrender.c:413: error: expected ')' before 'SONAME_LIBF

SONAME_LIBFONTCONFIG undeclared

2010-05-18 Thread GOUJON Alexandre
Hi, I just updated my local tree and ran CFLAGS="-g -O0" ./configure --disable-tests && make and I got make[1]: Entering directory `/home/alex/Projects/wine/dlls/winex11.drv' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -W

Re: ntdll: add stub for NtRaiseHardError (try 2)

2010-05-18 Thread Reece Dunn
On 18 May 2010 19:17, Austin English wrote: > This time returning STATUS_NOT_IMPLEMENTED instead of E_NOTIMPL, to > match the rest of ntdll. Thanks to Juan for pointing that out. > > -- > -Austin Patch? - Reece

Re: ntdll: add stub for NtRaiseHardError

2010-05-18 Thread Austin English
On Tue, May 18, 2010 at 1:07 PM, Juan Lang wrote: > Hi Austin, > +    return E_NOTIMPL; > I'm thinking this should return STATUS_NOT_IMPLEMENTED instead. Ah, crap. You're right, thanks for catching! -- -Austin

Re: ntdll: add stub for NtRaiseHardError

2010-05-18 Thread Juan Lang
Hi Austin, +return E_NOTIMPL; I'm thinking this should return STATUS_NOT_IMPLEMENTED instead. --Juan

Re: Nightly performance regression graphs

2010-05-18 Thread Remco
2010/5/18 Reece Dunn : >   > > should work on all platforms that support SVG. > > - Reece Chromium doesn't like the object markup. It shows tiny frames with scrollbars. It seems there is no cross-platform way to simply display an SVG image. -- Remco

Re: setupx.dll16: Fix error handling in VCP_VirtnodeCreate. (RETRY)

2010-05-18 Thread Alexandre Julliard
Gerald Pfeifer writes: > This was not applied and I also did not see any feedback (and even > checked the list archives) so I am resending it. If you are going to return an error you have to handle the error properly and free the data structures etc. It's not clear that this is the right thing

Re: [PATCH 1/2] wininet: Fix error handling in HTTP_HttpSendRequestW

2010-05-18 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/wininet/http.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:2692: Test failed: 2780: expected stat

Re: Nightly performance regression graphs

2010-05-18 Thread Reece Dunn
2010/5/18 André Hentschel : > Am 18.05.2010 15:17, schrieb Dan Kegel: >> On Mon, May 17, 2010 at 11:00 PM, Reece Dunn wrote: http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html >>> >>> Can you use something like: >>> >>> >> type="image/svg+xml"> >>>  >> type="image/svg+xml"> >>>  >> alt="E

Re: Nightly performance regression graphs

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 2:42 PM, Dan Kegel wrote: > On Tue, May 18, 2010 at 3:07 AM, Scott Ritchie wrote: >> > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html >> >> What tool are you using to make them? > > gnuplot.  The script (if you can call it that) I use is at > http://code.google.com

Re: Work on WineQuartz for MacOSX

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 3:12 PM, Mike Kronenberg wrote: > On 17.05.2010, at 07:52, Charles Davis wrote: > >> On 5/16/10 9:04 PM, James Mckenzie wrote: >>> Roderick Colenbrander wrote: On Sun, May 16, 2010 at 6:02 PM, C.W. Betts wrote: > On May 16, 2010, at 9:31 AM, James Mckenzie w

Re: Nightly performance regression graphs

2010-05-18 Thread André Hentschel
Am 18.05.2010 15:17, schrieb Dan Kegel: > On Mon, May 17, 2010 at 11:00 PM, Reece Dunn wrote: >>> http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html >> >> Can you use something like: >> >> > type="image/svg+xml"> >> > type="image/svg+xml"> >> > alt="E8400 GT220 - Ubuntu 10.04 LTS - e8400 - 3

Re: winecfg audio tab contents

2010-05-18 Thread Maarten Lankhorst
Hello Joerg, On 18-05-10 15:33, joerg-cyril.hoe...@t-systems.com wrote: did you notice that in winecfg-1.1.44, the audio tab content is broken: nothing is displayed below ALSA, and OSS lists 5 things only. There used to be much more content. This is likely a side effect from not calling DRV

Re: Nightly performance regression graphs

2010-05-18 Thread Dan Kegel
On Mon, May 17, 2010 at 11:00 PM, Reece Dunn wrote: >> http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > > Can you use something like: > > type="image/svg+xml"> >   type="image/svg+xml"> >   alt="E8400 GT220 - Ubuntu 10.04 LTS - e8400 - 3dmark06 3DMark Score"> >   > > > so that this will

Re: Work on WineQuartz for MacOSX

2010-05-18 Thread Mike Kronenberg
On 17.05.2010, at 07:52, Charles Davis wrote: > On 5/16/10 9:04 PM, James Mckenzie wrote: >> Roderick Colenbrander wrote: >>> On Sun, May 16, 2010 at 6:02 PM, C.W. Betts wrote: On May 16, 2010, at 9:31 AM, James Mckenzie wrote: > All: > > There was or is a quite lengthy thread o

Re: Nightly performance regression graphs

2010-05-18 Thread Dan Kegel
On Tue, May 18, 2010 at 3:07 AM, Scott Ritchie wrote: > > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > > What tool are you using to make them? gnuplot. The script (if you can call it that) I use is at http://code.google.com/p/winezeug/source/browse/trunk/yagmark-plot.sh > I recommen

Re: Nightly performance regression graphs

2010-05-18 Thread Dan Kegel
On Tue, May 18, 2010 at 1:13 AM, Sven Baars wrote: >> http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > > Just a question. What's this about? > > Vista Wine ratio > heaven2_d3d9_Video_memory1024.00256.00 0.2

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Henri Verbeet
On 18 May 2010 11:38, Roderick Colenbrander wrote: > I think we might be able to get rid of a lot of that code. At this > point two out of the three cases which use the blit_shader are routed > through draw_textured_quad which for instance already does the > glEnable(tex_type) for us. In this case

Re: Nightly performance regression graphs

2010-05-18 Thread wylda
> I finally threw together some graphs, see > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > Not sure what to make of the results yet. Cheap thought, expansive solution: Looking at the graphs and used HW i think this not necessary do what you expect. Change from 11 -> 10 can be just a n

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 10:58 AM, Henri Verbeet wrote: > On 18 May 2010 10:45, Roderick Colenbrander wrote: >> isn't right since set_shader does useful things as well like >> glEnable(tex_type). > Yeah. In the bigger picture it's also slightly insane that we have a > shader based blit backend tha

Re: [PATCH 3/4] wined3d: allow complex -> complex blits in arbfp blit_shader under special circumstances

2010-05-18 Thread Roderick Colenbrander
>> +        && (dst_usage & WINED3DUSAGE_RENDERTARGET)) > What is that condition for? For a part it was meant to disable sysmem -> sysmem copies using the arbfp blit_shader (but that should be done in general, so outside this check). I wasn't sure whether dst_pool == D3DPOOL_DEFAULT would be safe

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Henri Verbeet
On 18 May 2010 10:45, Roderick Colenbrander wrote: > isn't right since set_shader does useful things as well like > glEnable(tex_type). Yeah. In the bigger picture it's also slightly insane that we have a shader based blit backend that doesn't actually use a shader for blitting most of the time, b

Re: advapi32: Remove redundant "is NULL and error out" code (coccicheck).

2010-05-18 Thread Michael Stefaniuc
Alexandre, please disregard this patch as I missed somehow that the error codes are different. And to figure out which to use needs a test. bye michael Michael Stefaniuc wrote: > --- > dlls/advapi32/crypt.c |5 - > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 9:56 AM, Henri Verbeet wrote: > On 18 May 2010 09:30, Roderick Colenbrander wrote: >> -    arbfp_blit_set((IWineD3DDevice *)device, src_surface); >> +    if (is_complex_fixup(src_surface->resource.format_desc->color_fixup) && >> +        !is_complex_fixup(dst_surface->reso

Re: [PATCH 3/4] wined3d: allow complex -> complex blits in arbfp blit_shader under special circumstances

2010-05-18 Thread Henri Verbeet
On 18 May 2010 09:30, Roderick Colenbrander wrote: > This patch should also address bug 22575 when using the arbfp backend. A > similar fix is needed > for the ffp backend. That's meaningless as a Changelog entry. > +        && (dst_usage & WINED3DUSAGE_RENDERTARGET)) What is that condition for?

Re: [PATCH 4/4] wined3d: remove unneeded memory cleanup code from BltOverride

2010-05-18 Thread Henri Verbeet
On 18 May 2010 09:30, Roderick Colenbrander wrote: > We think the code is not needed and the code was wrong anyway since it didn't > check whether the pointers it freed > where valid. In which cases can it be invalid?

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Henri Verbeet
On 18 May 2010 09:30, Roderick Colenbrander wrote: > -    arbfp_blit_set((IWineD3DDevice *)device, src_surface); > +    if (is_complex_fixup(src_surface->resource.format_desc->color_fixup) && > +        !is_complex_fixup(dst_surface->resource.format_desc->color_fixup)) > +        arbfp_blit_set((I