Re: Nightly performance regression graphs

2010-05-17 Thread Reece Dunn
On 18 May 2010 02:01, Dan Kegel wrote: > I finally threw together some graphs, see > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > Not sure what to make of the results yet. > > They use svg, so a modern browser is required. Neat. Can you use something like: so that this wil

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread Charles Davis
On 5/17/10 9:32 PM, James McKenzie wrote: > Next stupid question: How does the patch get back into the XNU kernel > code? Is there a project for it, or do we dump it on Apple's front door > hoping that they will integrate it? To be honest, I really have no idea exactly how outsiders can contribut

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread James McKenzie
Charles Davis wrote: On 5/17/10 9:10 PM, James McKenzie wrote: Maybe. Actually, Mac OS X doesn't use a stock FreeBSD kernel. It uses a modified Mach kernel (the way NT uses a "modified microkernel") called "XNU". Many of XNU's BSD parts were forked from FreeBSD (a few parts come from other BS

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread Charles Davis
On 5/17/10 9:10 PM, James McKenzie wrote: > Is this something that should be investigated by the Open/Free-BSD (I > cannot keep which version MacOSX is based upon) It's FreeBSD. > community for inclusion > into the base kernel? Maybe. Actually, Mac OS X doesn't use a stock FreeBSD kernel. It uses a

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread James McKenzie
Charles Davis wrote: On 5/17/10 8:13 PM, James McKenzie wrote: Alexandre Julliard wrote: Charles Davis writes: What's wrong with my patch now? It's a really simple fix; in fact, this is as about as simple as it gets. How does this "break libwine compatibility"?

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread Charles Davis
On 5/17/10 8:13 PM, James McKenzie wrote: > Alexandre Julliard wrote: >> Charles Davis writes: >> >> >>> What's wrong with my patch now? It's a really simple fix; in fact, this >>> is as about as simple as it gets. How does this "break libwine >>> compatibility"? >>> >> >> Like I said, it's

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread James McKenzie
Alexandre Julliard wrote: Charles Davis writes: What's wrong with my patch now? It's a really simple fix; in fact, this is as about as simple as it gets. How does this "break libwine compatibility"? Like I said, it's not worth the trouble. Most modules need to be relocated anyway. It

Nightly performance regression graphs

2010-05-17 Thread Dan Kegel
I finally threw together some graphs, see http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html Not sure what to make of the results yet. They use svg, so a modern browser is required.

Re: [PATCH] comctl32/listview: Derive subitem rect from listview origin

2010-05-17 Thread Nikolay Sivov
On 5/18/2010 02:36, Andrew Eikum wrote: The old code used the containing item's position to determine the subitem's rect. Instead, we should be using the entire listview's origin as the offset, since the item position can change as columns are inserted and re-arranged, leading to broken listvie

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread Alexandre Julliard
Charles Davis writes: > What's wrong with my patch now? It's a really simple fix; in fact, this > is as about as simple as it gets. How does this "break libwine > compatibility"? Like I said, it's not worth the trouble. Most modules need to be relocated anyway. It would have to be done in the ke

Re: Trying to fix a bug, stuck at cross-compiling

2010-05-17 Thread André Hentschel
Am 17.05.2010 14:04, schrieb Alexandru Băluț: > Hi Michael, > > The Wine Test Bot does not help. I need to test the interface of the > application. > > Thanks, > Alex > > On Mon, May 17, 2010 at 09:41, Michael Stefaniuc wrote: >> Alexandru Băluț wrote: >>> I'm trying to fix bug 12804, and made

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

2010-05-17 Thread Charles Davis
What's wrong with my patch now? It's a really simple fix; in fact, this is as about as simple as it gets. How does this "break libwine compatibility"? Chip

Re: [PATCH 4/4] wined3d: add BLIT_OP_COMPLEX_UPLOAD

2010-05-17 Thread Roderick Colenbrander
On Mon, May 17, 2010 at 1:29 PM, Henri Verbeet wrote: > On 17 May 2010 13:11, Roderick Colenbrander wrote: >> This patch introduces a new blit operation to allow complex uploads from >> LoadLocation. It allows hw accelerated >> p8 uploads to function again (I broke them by accident). Without thi

Re: Trying to fix a bug, stuck at cross-compiling

2010-05-17 Thread wylda
I'm also interested how to cross compile ;) W. > Hi Michael, > > The Wine Test Bot does not help. I need to test the > interface of the > application. > > Thanks, > Alex

Re: Trying to fix a bug, stuck at cross-compiling

2010-05-17 Thread Alexandru Băluț
Hi Michael, The Wine Test Bot does not help. I need to test the interface of the application. Thanks, Alex On Mon, May 17, 2010 at 09:41, Michael Stefaniuc wrote: > Alexandru Băluț wrote: >> I'm trying to fix bug 12804, and made some changes to winecfg, and I >> need to test how it works on Win

Re: [PATCH 4/4] wined3d: add BLIT_OP_COMPLEX_UPLOAD

2010-05-17 Thread Henri Verbeet
On 17 May 2010 13:11, Roderick Colenbrander wrote: > This patch introduces a new blit operation to allow complex uploads from > LoadLocation. It allows hw accelerated > p8 uploads to function again (I broke them by accident). Without this > blit_operation there is no way to detect > this single

Re: urlmon: Added tests for some of the property methods. Added a dependency to urlmon for oleaut32

2010-05-17 Thread Jacek Caban
Hi Thomas, On 5/17/10 3:05 AM, Thomas Mullaly wrote: Added tests to make sure IUri_GetPropertyBSTR / IUri_GetPropertyDWORD / IUri_GetPropertyLength handle invalid arguments correctly. Fixed up/added some comments. Had to add a dependency to urlmon for oleaut32. This is because the Uri interf

Re: riched20: Avoid using long.

2010-05-17 Thread Michael Stefaniuc
(Marvin) wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? Yes, the bot is wrong on this one. The test function I modified isn't used in the f

Re: Trying to fix a bug, stuck at cross-compiling

2010-05-17 Thread Michael Stefaniuc
Alexandru Băluț wrote: > I'm trying to fix bug 12804, and made some changes to winecfg, and I > need to test how it works on Windows. I followed the instructions from Just use the Wine Test Bot to test on Windows: https://testbot.winehq.org/ The corresponding wiki page is http://wiki.winehq.org/W