Re: shell32/tests: Remove variable res which is not really used from init_strings.

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1972 Your paranoid android.

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread wylda
Ben Klein: > Any cases where -O0 and -O2 give different results for backtraces are > > bugs in the gcc optimisation code, not in Wine. And this was excatly one of the reasons, why use -O0. I do not want to report gcc bugs in wine's bugzilla. > Speed of code execution is an issue primarily with la

Re: kernel32/tests: Remove variable ret which is not really used from load_blackbox. (RESEND)

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1969 Your paranoid android.

Re: localspl/tests: Improve the tests in test_XcvDataPort_AddPort by properly checking return values and avoiding a duplicat

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1970 Your paranoid android.

Re: Added check for PROCESS_VM_WRITE, without which, some programs go into an infinite loop Henry Blum

2010-05-08 Thread Andrey Turkin
08.05.2010 9:10, Henry Blum wrote: --- dlls/kernel32/process.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 9a1f2f5..6dcad8f 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2657,7 +2657,7

Re: Added check for PROCESS_VM_WRITE, without which, some programs go into an infinite loop Henry Blum

2010-05-08 Thread Charles Davis
On 5/7/10 11:10 PM, Henry Blum wrote: > -if (status != STATUS_SUCCESS) > +if (status != STATUS_SUCCESS || (access & PROCESS_VM_WRITE)) According to this, opening a process and specifying the PROCESS_VM_WRITE access right causes OpenProcess() to fail. Why do you need this? And what about pr

Re: gdi32/tests: Remove two variables which are not really used from test_clipping.

2010-05-08 Thread Gerald Pfeifer
On Mon, 3 May 2010, Nikolay Sivov wrote: > Bitmap are useless after this change. I'll submit a patch which has this fixed. Interestingly, at least on my FreeBSD-based tester, test results did _not_ regress either way. Gerald

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.

2010-05-08 Thread Gerald Pfeifer
On Mon, 3 May 2010, Jacek Caban wrote: > On 5/2/10 9:16 PM, Gerald Pfeifer wrote: >> IActiveScriptSite_OnStateChange is described to return S_OK upon >> success, so instead of ignoring its return value and unconditionally >> returning S_OK it strikes me that we should return its result instead. > I

Re: Release plans

2010-05-08 Thread Ben Klein
2010/5/9 Sir Gallantmon (ニール・ゴンパ) : > On Sat, May 8, 2010 at 1:42 PM, Alexandre Julliard > wrote: >> >> Folks, >> >> The 64-bit support is now more or less complete, and we have most of the >> fancy new icons, so it's time to think about the next stable release. > > What do you mean by the 64-bit

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Ben Klein
On 9 May 2010 06:21, wrote: > Hi Marcus, > >> > * better backtraces for bug reports >> >> -O2 works like a charm there too, at least for me. > > I think i read that somewhere and if i understood that correctly, my > conclusion at that time was, that -02 optimizes the code, so it can > "omit some"

Re: Release plans

2010-05-08 Thread James McKenzie
Vincent Povirk wrote: Actually, when I read through the report, it broke in 1.0-rc4 but worked in 0.9.52. That is one old bug and aggravating too. You're right, so it didn't work in 1.0. That's.. that might actually be worse. Vincent: This should be on the 1.2 todo list. This real

Re: Release plans

2010-05-08 Thread Vincent Povirk
On Sat, May 8, 2010 at 8:43 PM, Erich Hoover wrote: > On Sat, May 8, 2010 at 7:16 PM, Vincent Povirk > wrote: >> >> While we're linking to bug lists, this one seems most interesting to me: >> http://bit.ly/bfOHK5 >> >> That's the list of major regressions introduced since 1.0-rc1. >> ... > > What

Re: Release plans

2010-05-08 Thread Erich Hoover
On Sat, May 8, 2010 at 7:16 PM, Vincent Povirk wrote: > While we're linking to bug lists, this one seems most interesting to me: > http://bit.ly/bfOHK5 > > That's the list of major regressions introduced since 1.0-rc1. > ... > What criteria did you use to build that list? There's a bunch of rece

Re: Release plans

2010-05-08 Thread Vincent Povirk
> Actually, when I read through the report, it broke in 1.0-rc4 but worked in > 0.9.52.  That is one old bug and aggravating too. You're right, so it didn't work in 1.0. That's.. that might actually be worse.

Re: Release plans

2010-05-08 Thread James McKenzie
Vincent Povirk wrote: While we're linking to bug lists, this one seems most interesting to me: http://bit.ly/bfOHK5 That's the list of major regressions introduced since 1.0-rc1. Bug 13891 in particular will make us look bad if it's not fixed before 1.2. A lot of apps (as I understand it, any a

Re: Release plans

2010-05-08 Thread James McKenzie
Vincent Povirk wrote: While we're linking to bug lists, this one seems most interesting to me: http://bit.ly/bfOHK5 That's the list of major regressions introduced since 1.0-rc1. Bug 13891 in particular will make us look bad if it's not fixed before 1.2. A lot of apps (as I understand it, any a

Re: Release plans

2010-05-08 Thread Vincent Povirk
While we're linking to bug lists, this one seems most interesting to me: http://bit.ly/bfOHK5 That's the list of major regressions introduced since 1.0-rc1. Bug 13891 in particular will make us look bad if it's not fixed before 1.2. A lot of apps (as I understand it, any app that does it properly

Re: [2/2] gdiplus: Implement GdipGetImageThumbnail.

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1960 Your paranoid android.

Re: [1/2] gdiplus: Add test for GdipGetImageThumbnail.

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1959 Your paranoid android.

Re: Release plans

2010-05-08 Thread Tom Wickline
On Sun, May 9, 2010 at 7:02 AM, Dan Kegel wrote: > Tom Wickline wrote: > >> > http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=Wine&target_milestone=1.2.0 > > > > Three releases to fix 88 nasty bugs? > > The sad fact is that

re: Release plans

2010-05-08 Thread Dan Kegel
Tom Wickline wrote: >> http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=Wine&target_milestone=1.2.0 > > Three releases to fix 88 nasty bugs? The sad fact is that it would take a lot more than that to fix them all, and it proba

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Eric Pouech
Le 08/05/2010 22:37, Nikolay Sivov a écrit : On 5/9/2010 00:21, wy...@volny.cz wrote: Hi Marcus, * better backtraces for bug reports -O2 works like a charm there too, at least for me. I think i read that somewhere and if i understood that correctly, my conclusion at that time was, that -02

Re: Release plans

2010-05-08 Thread Tom Wickline
On Sun, May 9, 2010 at 4:34 AM, Austin English wrote: > > It's the first link on the tasklist in bugzilla: > > http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=Wine&target_milestone=1.2.0&order=bugs.bug_severity > > -- > -Aust

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Nikolay Sivov
On 5/9/2010 00:21, wy...@volny.cz wrote: Hi Marcus, * better backtraces for bug reports -O2 works like a charm there too, at least for me. I think i read that somewhere and if i understood that correctly, my conclusion at that time was, that -02 optimizes the code, so it can

Re: Release plans

2010-05-08 Thread Austin English
On Sat, May 8, 2010 at 3:31 PM, James McKenzie wrote: > Alexandre Julliard wrote: >> >> Folks, >> >> The 64-bit support is now more or less complete, and we have most of the >> fancy new icons, so it's time to think about the next stable release. >> >> Unless some major problems come up, 1.1.44 wi

Re: Release plans

2010-05-08 Thread James McKenzie
Alexandre Julliard wrote: Folks, The 64-bit support is now more or less complete, and we have most of the fancy new icons, so it's time to think about the next stable release. Unless some major problems come up, 1.1.44 will be the last of the 1.1.x series. The next release will be 1.2-rc1, whic

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread wylda
Hi Marcus, > > * better backtraces for bug reports > > -O2 works like a charm there too, at least for me. I think i read that somewhere and if i understood that correctly, my conclusion at that time was, that -02 optimizes the code, so it can "omit some" part of code and replace them by faster al

Re: Release plans

2010-05-08 Thread ニール・ゴンパ
On Sat, May 8, 2010 at 1:42 PM, Alexandre Julliard wrote: > Folks, > > The 64-bit support is now more or less complete, and we have most of the > fancy new icons, so it's time to think about the next stable release. > > Unless some major problems come up, 1.1.44 will be the last of the 1.1.x > ser

Release plans

2010-05-08 Thread Alexandre Julliard
Folks, The 64-bit support is now more or less complete, and we have most of the fancy new icons, so it's time to think about the next stable release. Unless some major problems come up, 1.1.44 will be the last of the 1.1.x series. The next release will be 1.2-rc1, which will mark the beginning of

Re: user32: Fix selected brush color for caret bitmap creation

2010-05-08 Thread Nikolay Sivov
On 5/8/2010 22:20, Nikolay Sivov wrote: Fixes bug 1733. Selected brush color should depend on current window color or other system settings, it just inverts hdc colors. (should -> shouldn't)

Re: gdiplus: Implement bitmap color keying.

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1955 Your paranoid android.

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Marcus Meissner
On Sat, May 08, 2010 at 03:02:48PM +0200, wy...@volny.cz wrote: > > > Roderick: > > Yeah the -O0 bug was reported on #winehackers yesterday > > and will likely be fixed soon. > > Ah, ok :) I know you already test nearly everythink, but what about adding > another test -O{0,1,2,s,...} > a] before

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.

2010-05-08 Thread Jacek Caban
On 5/7/10 11:47 PM, Gerald Pfeifer wrote: On Mon, 3 May 2010, Jacek Caban wrote: On 5/2/10 9:16 PM, Gerald Pfeifer wrote: IActiveScriptSite_OnStateChange is described to return S_OK upon success, so instead of ignoring its return value and unconditionally returning S_OK it strikes me

RFC kernel32: add test for FindFirstFileA with a path ending with "/>"

2010-05-08 Thread Vincent Pelletier
This test passes on win2k & winxp, fails on wine. That failure causes cdkey verification problems in "Earth 2160" as sold on GOG.com: Once the installation is finished, the installers generates a registry key value based (among other things) on the ctime of installed directory. Looked-up path has

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread wylda
> Roderick: > Yeah the -O0 bug was reported on #winehackers yesterday > and will likely be fixed soon. Ah, ok :) I know you already test nearly everythink, but what about adding another test -O{0,1,2,s,...} a] before official release or b] evening wine git update > Compiling using -O2 (which is

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Roderick Colenbrander
Yeah the -O0 bug was reported on #winehackers yesterday and will likely be fixed soon. Compiling using -O2 (which is what you should use by default anyway unless you have very good reasons not to) should work fine. Roderick On Sat, May 8, 2010 at 2:33 PM, wrote: > > Hi guys, i can't compile win

Compilation failure in wine-1.1.44

2010-05-08 Thread wylda
Hi guys, i can't compile wine-1.1.44 (1.1.43 is OK here like all the ones before)... As i guess you would not release a wine, which can't be compiled, than i suspect there could be a trouble in my system (Debian Lenny 32bit). For this reason, i did not bother to fill a bug ;) as it would be marked

Re: mshtml: Fix return type value for HTMLBodyElement_put_text.

2010-05-08 Thread Jacek Caban
On 5/8/10 1:07 PM, Gerald Pfeifer wrote: The current code does not handle an error coming out of nsIDOMHTMLBodyElement_SetText and actually discards whatever nsres is set to. Jacek, is a patch like this okay, should we just remove nsres, or is it more complicated than that? We can't mix ns

Re: Add tests for ImageGetDigestStream

2010-05-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1950 Your paranoid android.