Re: localspl/tests: Improve the tests in test_XcvDataPort_AddPort by properly checking return values and avoiding a duplicat

2010-05-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1881 Your paranoid android.

Re: Minor dlls/localspl/tests/localmon.c simplificiation

2010-05-02 Thread Gerald Pfeifer
On Sat, 1 May 2010, Nikolay Sivov wrote: ChangeLog: Remove variable res which is not really used from test_XcvClosePort. >>> We should better test for return value than remove it. > This is a primitive thing, try it if you didn't before. > All you need is to add some lines like: > --- > o

Re: Minor dlls/comctl32/tests/listview.c simplification

2010-05-02 Thread Gerald Pfeifer
On Thu, 22 Apr 2010, Nikolay Sivov wrote: > You can't do this, subclassing is important thing here. And you will see > it if you run a test (that you should do before sending patch actually). Thanks, Nikolay. You're perfectly right, that was a silly mistake of mine, no way to put this differentl

Re: Remove variable doRecursive which is not really used from WCMD_for.

2010-05-02 Thread Gerald Pfeifer
On Sun, 2 May 2010, Nikolay Sivov wrote: > Please use consistent naming for patches and mail subjects. It's > described in http://wiki.winehq.org/SubmittingPatches. > > I'm not sure it makes sense to resend all these, but GERALD: as a > start word is unacceptable of course. Indeed, four or so pa

Re: Minor dlls/dbghelp/dwarf.c simplification

2010-05-02 Thread Gerald Pfeifer
Eric Pouech wrote: > this is wrong: dwarf_parse family set makes the pointer in the cxt > advance by the size of the object which is being parse You're right. I had, in fact, checked this very question, but doing so just again I see where I missed the += in the code. Thanks for catching this, E

Re: quartz: Properly return E_POINTER when ppFilters is null

2010-05-02 Thread Nikolay Sivov
On 5/3/2010 02:17, Jerome Leclanche wrote: Fixes bug 22563. Also fix broken indent right below. J. Leclanche Please, add a test for this, it looks trivial to test.

Re: Francois Gouget : winedbg: Fix compilation with gcc 2. 95 and non-GNU compilers.

2010-05-02 Thread Francois Gouget
On Wed, 21 Apr 2010, Eric Pouech wrote: > Francois Gouget a écrit : > > There were two problems: > > * the semi-colon was missing for non-GNUC compilers as you mentioned > > * gcc 2.95 does not support __attribute__() on function pointers > > > > Unfortunately your patch does not fix the second

Fullscreen Borderlands at Desktop Resolution

2010-05-02 Thread Erich Hoover
I've been playing the game Borderlands at less than my desktop resolution due to a strange bug and finally decided to try and track it down. The issue is that whenever the resolution of Borderlands is set to the same resolution as the desktop then the game window does not appear in the upper left

Re: Unable to start WoW from git 1.1.29 while 1.1.29 tarball works.

2010-05-02 Thread Johann "Myrkraverk" Oskarsson
Hi all, On Sun, May 2, 2010 at 4:55 PM, Johann "Myrkraverk" Oskarsson wrote: > I am unable to start WoW when I compile release 1.1.29 from the git > repo, while compiling the 1.1.29 release tarball allows me to play > WoW. With help from #winehq: An out of tree build works. Johann

Re: new wisotool 20100424: new verbs 3dmark2000, 3dmark2001, 3dmark03, 3dmark05, 3dmark06, baldursgate2, gta_vc, pcmark04, pcmark05, unigine_heaven

2010-05-02 Thread Vincent Pelletier
Patch updated. Notes: - Download urls and AHK scripts are *all* tested as of this patch (~5 hours to install everything). - BAT scripts are *not* tested. Remaining issues: - url escaping when posting login & password (I'll work on this next) - possibly BAT scripting mistakes (verb definition) -

Unable to start WoW from git 1.1.29 while 1.1.29 tarball works.

2010-05-02 Thread Johann "Myrkraverk" Oskarsson
Hello all. I am unable to start WoW when I compile release 1.1.29 from the git repo, while compiling the 1.1.29 release tarball allows me to play WoW. System info: % uname -a; isainfo -k SunOS asuka 5.11 snv_115 i86pc i386 i86pc amd64 Git compile steps taken: git checkout wine-1.1.29 git clean

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Dan Kegel
2010/5/2 Rico Schüller : > It looks like you've mixed up the results somewhere. The score should be > higher on the lower 3Dmark version. (3dmark 2000 on vista has 30278 points - > http://kegel.com/wine/yagmarkdata/e8400/gt240/vista/yagmark-e8400-Vista-2010-04-30-18:30.txt) That'll teach me to edi

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Rico Schüller
Am 01.05.2010 20:08, schrieb Dan Kegel: Results at http://kegel.com/wine/yagmarkdata/e8400/ Summary: Ubuntu: 6 runs 3dmark2000: min 4145, median 4154, max 4170 3dmark2001: min 18884, median 19261, max 19520 3dmark2006: min 17315, median 18154, max 18498 Vista: 2 runs: 3dmark2000: 8206, 821

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Dan Kegel
On Sun, May 2, 2010 at 2:07 AM, Roderick Colenbrander wrote: > When doing such benchmarks also try to write down the frame rates of > the individual tests. The 3dmark score is some sort of weighted > average (the result of the cpu test in it is also quite important). > From what I remember the sco

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Dan Kegel
On Sun, May 2, 2010 at 1:03 AM, Edward Savage wrote: >>  video card: nvidia GT 240 > > Do you happen to have a 4k/5k series ATI card to attempt this test set > with as well? I have three nvidia cards: 8500gt, gt220, gt240. (I also have an old ati rage pro which probably isn't worth testing.) > I

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Roderick Colenbrander
When doing such benchmarks also try to write down the frame rates of the individual tests. The 3dmark score is some sort of weighted average (the result of the cpu test in it is also quite important). >From what I remember the scores in 2000/2001/2003 were actually good but 2005/2006 used to be qui

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Edward Savage
On Sun, May 2, 2010 at 4:08 AM, Dan Kegel wrote: > I did some apples-to-apples 3d benchmarking today on a dual boot system. > It looks offhand like Windows is about twice as fast as Wine on these > benchmarks on my system. > >  cpu:  e8400 >  ram: 4GB >  video card: nvidia GT 240 >  Ubuntu 32 10.0

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Austin English
On Sat, May 1, 2010 at 5:26 PM, Scott Ritchie wrote: > One note of caution is that video card manufacturers have been known to > blatantly cheat on these tests by rigging their drivers with special > hacks when they detect 3dmark is running.  As far as I know the code may > still be there. > > Sin