Re: Francois Gouget : winedbg: Fix compilation with gcc 2. 95 and non-GNU compilers.

2010-04-21 Thread Eric Pouech
Francois Gouget a écrit : There were two problems: * the semi-colon was missing for non-GNUC compilers as you mentioned * gcc 2.95 does not support __attribute__() on function pointers Unfortunately your patch does not fix the second issue. A solution that would not require dbg_vprintf() woul

Re: Writing test programs for dlls/krnl386.exe16

2010-04-21 Thread Morten Rønne
Hi I have figured out what the problem was, and it comes down to a problem with the dot in krnl386.exe16. So as Dmitry suggested I have moved the test to kernel32 and there it works perfectly (with precompiled assembler program). Best Regards Morten Rønne Morten Rønne wrote: Hi Tha

Re: Graphics Driver Interface Standardization

2010-04-21 Thread Aleksey Bragin
I'm doing my own (non-X11 and not a Quartz one) version of a graphics/ user driver, and the interface is quite stable. Only a few minor changes were done over the period of ~6 months. Also, if I don't mistake, the specific winex11 calls from explorer are not needed anymore. WBR, Aleksey B

Re: Writing test programs for dlls/krnl386.exe16

2010-04-21 Thread Morten Rønne
Hi How I am supposed to call real mode DOS stuff from 32 bit code? Best Regards Morten Rønne Dmitry Timoshkov wrote: Morten Rønne wrote: I can't see what I should have missed in Makefile.in for this to fail. I would expect the needed rules would be made automatically when crea

Re: OPOS in wine

2010-04-21 Thread Austin English
On Wed, Apr 21, 2010 at 2:31 AM, Joni Salmela wrote: > Hello all mighty wine people. > > this might not be the best place to do this and for that I apologize for > this inconvenience... > > anyway I am about to try to configure OPOS in ubuntu 9.10 karmic using > wine since most of the printer

Fwd: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx.

2010-04-21 Thread Alexander Scott-Johns
Forgot to Reply All -- Forwarded message -- From: Alexander Scott-Johns Date: 21 April 2010 16:40 Subject: Re: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx. To: Dmitry Timoshkov On 21 April 2010 16:08, Dmitry Timoshkov wrote: > A

Re: user32: Add BM_SETSTATE/BM_SETCHECK message tests for a button, make them pass under Wine.

2010-04-21 Thread Paul Vriens
On 04/21/2010 05:16 PM, Greg Geldorp wrote: From: Dmitry Timoshkov [mailto:dmi...@codeweavers.com] That's not a failure in the new test, according the W7PROX64 log button message tests pass without any problem, the test just timeouts at the end. This seems to be not related to the new tests. A

Re: dlls/d3dx9_36/shader.c: replace malloc with HeapAlloc

2010-04-21 Thread Henri Verbeet
On 21 April 2010 17:19, Joris Huizer wrote: > -path = malloc(strlen(filename) + 1); > +path = HeapAlloc(GetProcessHeap(), 0, strlen(filename) + 1); No, malloc() is correct, wpp frees it again with free().

RE: user32: Add BM_SETSTATE/BM_SETCHECK message tests for a button, make them pass under Wine.

2010-04-21 Thread Greg Geldorp
> From: Dmitry Timoshkov [mailto:dmi...@codeweavers.com] > > That's not a failure in the new test, according the W7PROX64 log button > message tests pass without any problem, the test just timeouts at the end. > This seems to be not related to the new tests. Agreed. I ran the msg test without your

Re: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx.

2010-04-21 Thread Dmitry Timoshkov
Alexander Scott-Johns wrote: > Using GetCPInfoEx was a nice idea, but unfortunately its output is not > localized, and on Windows, the codepage identifier is tacked on the > beginnning. You should fix GetCPInfoEx instead, it returns localized strings under Windows. Same comment for your other p

Re: [1/2] include/wine: add option to specify the unittest target via environment variable

2010-04-21 Thread Paul Vriens
On 04/21/2010 07:21 AM, Stefan Leichter wrote: Am Tuesday 20 April 2010 20:57:41 schrieb Paul Vriens: On 04/20/2010 08:37 PM, Stefan Leichter wrote: Am Tuesday 20 April 2010 07:59:22 schrieb Paul Vriens: On 04/19/2010 11:44 PM, Stefan Leichter wrote: --- include/wine/test.h |6 +-

Re: [PATCH] msiexec: Use resource in msi for a Help Dialog to allow translation

2010-04-21 Thread Hans Leidekker
On Wed, 2010-04-21 at 16:18 +0200, Detlef Riekenberg wrote: > static void ShowUsage(int ExitCode) > { > - printf(UsageStr); > +WCHAR msiexec_version[40]; > +WCHAR msiexec_help[4096]; > +WCHAR msi_res[4050]; You should use dynamically sized heap buffers here.

Re: [1/2] include: Add asptlb.idl (try 2)

2010-04-21 Thread Michael Stefaniuc
Hello Alistair, Alistair Leslie-Hughes wrote: > Change long -> LONG thanks but that isn't really necessary. "long" is always 32bits in IDL files. widl will replace that with LONG in the generated files. > Changelog: > include: Add asptlb.idl bye michael

Re: (resend) imm32: rework storage of thread default contexts

2010-04-21 Thread Alexandre Julliard
Aric Stewart writes: > any thread needs to be able to access the default context for any > other thread in the process for ImmGetContext. This looks very suspicious, and not at all thread-safe. There has to be a better way. -- Alexandre Julliard julli...@winehq.org

Re: user32: Add BM_SETSTATE/BM_SETCHECK message tests for a button, make them pass under Wine.

2010-04-21 Thread Dmitry Timoshkov
Greg Geldorp wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=1

Intercept relay_call causes seh:raise_exception code=c0000005

2010-04-21 Thread Jui-Hao Chiang
Hi, All, I am currently using the WINEDEBUG=relay feature to intercept function calls as the following 1. in dlls/ntdll/relay.c, insert code snippet in static LONGLONG WINAPI relay_call( struct relay_descr *descr, unsigned int idx, const INT_PTR *stack ) { . my_own_function(entry_point->name,

Re: Minor dlls/mshtml/htmlbody.c simplification

2010-04-21 Thread Jacek Caban
Hi Gerald, On 4/21/10 1:45 PM, Gerald Pfeifer wrote: ChangeLog: Remove variable hres which is not really used from HTMLBodyElement_get_text. diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c index 5c66e65..c6b202b 100644 --- a/dlls/mshtml/htmlbody.c +++ b/dlls/mshtml/htmlbody.c @@ -4

Re: user32: Add BM_SETSTATE/BM_SETCHECK message tests for a button, make them pass under Wine.

2010-04-21 Thread Greg Geldorp
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1645 Your paranoid android.

OPOS in wine

2010-04-21 Thread Joni Salmela
Hello all mighty wine people. this might not be the best place to do this and for that I apologize for this inconvenience... anyway I am about to try to configure OPOS in ubuntu 9.10 karmic using wine since most of the printer drivers etc... are executed in the user space and the OPOS itself

Re: [2/2] msxml3: Rewrite IXMLDOMDocument2 save to behave more like msxml3

2010-04-21 Thread Nikolay Sivov
On 4/21/2010 13:14, Alistair Leslie-Hughes wrote: +ret = IUnknown_QueryInterface(pUnk,&IID_IUnknown, (void**)&pUnkRemote); There's no point to do it. You already have IUnknown pointer. It's better to remove test for that case I think.

Re: [2/2] msxml3: Rewrite IXMLDOMDocument2 save to behave more like msxml3

2010-04-21 Thread Nikolay Sivov
On 4/21/2010 07:13, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Rewrite IXMLDOMDocument2 save to behave more like msxml3 Best Regards Alistair Leslie-Hughes Hi, you forgot a patch.

Re: [PATCH 4/6] [WineGcc]: when specifying -m32, force i386 cpu when compiling on x86_64 boxes

2010-04-21 Thread Alexandre Julliard
Eric Pouech writes: > AFAICS it's not worse than when we use -b i386-elf > when building for wow64, we use winegcc for linking either 32bit or > 64bit execs (with the --sysroot switch) > not use what you propose will help... it'll prevent an error later on > in gcc (or ld), but if winegcc is pass