On 04/13/2010 12:46 AM, Greg Geldorp wrote:
From: Ge van Geldorp
From: Roderick Colenbrander
I'm not sure how the bot works but it looks like it concatenated some
of my patches together and then applied to them. I have no idea to
what Wine version it was since it applies fine on Wine git here.
wrote:
> >Since there is no neither todo_wine statements in the tests, nor test
> >failures
> >under Wine that means that both the tests and the patch are not OK.
>
> What has Wine to say when talking about the correctness
> of tests? Only native dictates what the test result should be.
Of co
> From: Ge van Geldorp
> > From: Roderick Colenbrander
> >
> > I'm not sure how the bot works but it looks like it concatenated some
> > of my patches together and then applied to them. I have no idea to
> > what Wine version it was since it applies fine on Wine git here. It
> > could be that I'm
> From: Roderick Colenbrander
>
> I'm not sure how the bot works but it looks like it concatenated some
> of my patches together and then applied to them. I have no idea to
> what Wine version it was since it applies fine on Wine git here. It
> could be that I'm doing something wrong but I don't s
I'm not sure how the bot works but it looks like it concatenated some
of my patches together and then applied to them. I have no idea to
what Wine version it was since it applies fine on Wine git here. It
could be that I'm doing something wrong but I don't see where.
Roderick
On Mon, Apr 12, 201
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.geldorp.nl/JobDetails.pl?Key=1401
Your paranoid andr
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.geldorp.nl/JobDetails.pl?Key=1399
Your paranoid andr
Dmitry Timoshkov wrote:
>Since there is no neither todo_wine statements in the tests, nor test failures
>under Wine that means that both the tests and the patch are not OK.
What has Wine to say when talking about the correctness
of tests? Only native dictates what the test result should be.
The
wrote:
> >I don't see any corresponding changes in that patch that remove todo_wine
> >statements
> >in the tests. That suggests that either such tests don't exist, or that
> >change actually
> >fixes nothing.
> A third explanation is possible:
> It's an example of one bug shadowing another bug
Dmitry Timoshkov wrote:
>I don't see any corresponding changes in that patch that remove todo_wine
>statements
>in the tests. That suggests that either such tests don't exist, or that change
>actually
>fixes nothing.
A third explanation is possible:
It's an example of one bug shadowing another b
[cc:ing wine-devel]
wrote:
> this is the second time that AJ commits a patch of mine despite
> a comment of yours.
I think that Alexandre has commited your patch slightly in a hurry,
usually he waits at least several hours unless the patch is obviously
correct (which is not the case here IMO).
writes:
> Ok. After being bitten at least once by assignment/comparison
> mismatch I promised myself to use that style. I'm myself used
> to read code as "if A equals 3" rather than "if 3 is the value
> of A" but I'm convinced that's just a matter of getting used
> to this style that is less er
wrote:
> >> +FIXME("(%04x) vkey %04X stub\n", dwFlags, lpParms->nVirtKey);
> >That change is unwanted.
> I can remove it, but why? Is supporting break keys a WONTFIX in Wine?
If that's really a problem then the first thing to do is start with some bug
reports or test cases. Adding spurious F
Dmitry Timoshkov wrote:
>> +FIXME("(%04x) vkey %04X stub\n", dwFlags, lpParms->nVirtKey);
>That change is unwanted.
I can remove it, but why? Is supporting break keys a WONTFIX in Wine?
>Do you have a test case which shows that notofication is not sent is the
>failure case?
It's already in
wrote:
> +FIXME("(%04x) vkey %04X stub\n", dwFlags, lpParms->nVirtKey);
That change is unwanted.
> -if (dwFlags & MCI_NOTIFY)
> - mciDriverNotify((HWND)lpParms->dwCallback, wDevID,
> -(dwRet == 0) ? MCI_NOTIFY_SUCCESSFUL :
> MCI_NOTIFY_FAILURE);
> -
> +
Hi all,
I decided to dig through the sample documentation for rtkit and see if I
could find a way to make it work for wine.
There's still a few things missing: hardcoded libdbus soname, no
checking if dbus is available, -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include should be added to ntd
On 12 April 2010 12:10, paulo lesgaz wrote:
> What do you mean?
>
> I think I kept the file format.
>
> And what are the other things ? ;)
>
Sorry, but I really think these are things you should be able to
figure out on your own.
On 12 April 2010 12:44, Roderick Colenbrander wrote:
> - context = context_acquire(This, (IWineD3DSurface *)target,
> CTXUSAGE_CLEAR);
> + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO)
> + {
> + if (!surface_is_offscreen((IWineD3DSurface *)target))
> + {
> +
On 12 April 2010 12:44, Roderick Colenbrander wrote:
> + if (ffp_blit.blit_supported(&myDevice->adapter->gl_info,
> BLIT_OP_COLOR_FILL,
> + NULL, 0, 0, NULL,
> + &dst_rect, This->resource.usage,
> This->reso
On 12 April 2010 12:44, Roderick Colenbrander wrote:
> {WINED3DFMT_D16_UNORM, GL_DEPTH_COMPONENT24_ARB,
> GL_DEPTH_COMPONENT24_ARB, 0,
> GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT, 0,
> WINED3DFMT_FLAG_POSTPIXELSHADE
2010/4/12 Nicolas Le Cam :
> Le 12 avril 2010 11:02, Frédéric Delanoy a écrit
> :
>> 2010/4/9 Nicolas Le Cam :
>>> Le 9 avril 2010 13:30, Frédéric Delanoy a
>>> écrit :
2010/4/9 Nicolas Le Cam :
> Hi Frédéric,
>
>>+processus clients se sont terminés. Ceci évite le coût inhérent
Le 12 avril 2010 11:02, Frédéric Delanoy a écrit :
> 2010/4/9 Nicolas Le Cam :
>> Le 9 avril 2010 13:30, Frédéric Delanoy a écrit
>> :
>>> 2010/4/9 Nicolas Le Cam :
Hi Frédéric,
>+processus clients se sont terminés. Ceci évite le coût inhérent à l'arrêt
sont -> soient
>>>
Damjan Jovanovic writes:
> I've hacked at this enough to get some basic USB I/O working, so now I
> have a better idea of what's necessary.
>
> I like usbhub.sys separate from usbd.sys because:
> * The service is called Usbhub in the registry, drivers might depend
> on the service, and having the
On Fri, 9 Apr 2010, Austin English wrote:
[...]
> Why did you rename system32? Are you linking your ~/.wine/drive_c to a
> real windows installation?
Windows paths are case insensitive so anything in drive_c should be
treated in a case-insensitive way. If winetricks does not do so, then it
is bu
The issues were existing before and thus not related to the patch.
The patch is only a file renaming and the test selector changed from
"texture" to "surface" to match tested functions.
I will see if I can do something to fix the test failures.
Christian
(Marvin) a écrit :
Hi,
While running
What do you mean?
I think I kept the file format.
And what are the other things ? ;)
A+
David
De : Henri Verbeet
À : wine-devel@winehq.org
Envoyé le : Lun 12 avril 2010, 11 h 52 min 15 s
Objet : Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests
Formatt
Formatting, among others.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.geldorp.nl/JobDetails.pl?Key=1363
Your paranoid andr
Austin English wrote:
On Fri, Apr 9, 2010 at 8:45 AM, Helge Hafting wrote:
I just tried installing gdiplus using winetricks, on a debian testing
system.
This failed, as winetricks tried to copy stuff into windows/system32,
where I happen to have Windows/System32.
I first tried making symlinks
Austin English wrote:
> I've updated winetricks ...
>
> Get it at http://winezeug.googlecode.com/svn/trunk/winetricks
Were you aware that VERSION is still set to 20100317?
2010/4/9 Nicolas Le Cam :
> Le 9 avril 2010 13:30, Frédéric Delanoy a écrit :
>> 2010/4/9 Nicolas Le Cam :
>>> Hi Frédéric,
>>>
+processus clients se sont terminés. Ceci évite le coût inhérent à l'arrêt
>>> sont -> soient
>>>
+\fIwineserver\fR dans le chemin système ou quelques autres empl
2010/4/9 Nicolas Le Cam :
> Le 9 avril 2010 13:23, Frédéric Delanoy a écrit :
>> Well I thought about putting it in non-infinitive form, but it didn't
>> sound/feel right to me.
>>
>> In fact "N'affiche" would be more like a description, while
>> "N'afficher" is more an action/modifier/behaviour "
On Mon, Apr 12, 2010 at 1:43 AM, wrote:
> Austin English wrote:
>
>> I've updated winetricks ...
>>
>> Get it at http://winezeug.googlecode.com/svn/trunk/winetricks
>
> Were you aware that VERSION is still set to 20100317?
Yes, Dan updates that when he puts it at
http://kegel.com/wine/winetrick
33 matches
Mail list logo
