wisotool: now supports seven games, runs on windows, too

2010-04-05 Thread Dan Kegel
My little automated app installer tool, wisotool, now supports seven apps: assassinscreed, diablo2, dragonage, morrowind, sims3, starcraft, and wog (world of goo) It also seems to run on Windows ok in Cygwin (though I've only barely tested that). Thanks to Austin for dragonage, morrowind, and some

Application period ends in ~4 days

2010-04-05 Thread Maarten Lankhorst
Hi all, I've seen a few very good proposals on the mailing list, but not enough of them ended up as a proposal on the official summer of code app. So if you haven't done so already please apply there now. You can still modify your proposal there after submitting it based on feedback, but you'l

Re: [PATCH 6/6] Due to code rewrites is_color_fixup_supported is not needed anymore in RealizePalette. The code in question should be executed in all cases. This also fixes palette refresh issues wh

2010-04-05 Thread Roderick Colenbrander
On Mon, Apr 5, 2010 at 9:52 PM, Stefan Dösinger wrote: > > Am 05.04.2010 um 20:05 schrieb Roderick Colenbrander: >> -        IWineD3DDeviceImpl *device = This->resource.device; >> -        if((This->resource.usage & WINED3DUSAGE_RENDERTARGET) && >> -             >> device->blitter->color_fixup_sup

Re: [PATCH 2/6] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets) (try 2)

2010-04-05 Thread Christian Costa
Henri Verbeet a écrit : On 5 April 2010 20:28, Christian Costa wrote: +inline ctab_constant* get_constant(D3DXHANDLE ptr) +{ +if (!ptr) return NULL; +return (ctab_constant*)~(UINT)ptr; +} + +inline D3DXHANDLE get_handle(ctab_constant* ptr) +{ +return (D3DXHANDLE)~((UINT)ptr); +}

Re: [PATCH 6/6] Due to code rewrites is_color_fixup_supported is not needed anymore in RealizePalette. The code in question should be executed in all cases. This also fixes palette refresh issues when

2010-04-05 Thread Stefan Dösinger
Am 05.04.2010 um 20:05 schrieb Roderick Colenbrander: > -IWineD3DDeviceImpl *device = This->resource.device; > -if((This->resource.usage & WINED3DUSAGE_RENDERTARGET) && > - > device->blitter->color_fixup_supported(&device->adapter->gl_info, > This->resource.format_desc

Re: [PATCH 2/6] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets) (try 2)

2010-04-05 Thread Henri Verbeet
On 5 April 2010 20:28, Christian Costa wrote: > +inline ctab_constant* get_constant(D3DXHANDLE ptr) > +{ > +if (!ptr) return NULL; > +return (ctab_constant*)~(UINT)ptr; > +} > + > +inline D3DXHANDLE get_handle(ctab_constant* ptr) > +{ > +return (D3DXHANDLE)~((UINT)ptr); > +} How is tha

Re: [PATCH 3/6] d3dx9_36: Implement D3DXGetImageInfoFromFileInMemory using WindowsCodecs (based on work from Tony Wasserka) (try 2)

2010-04-05 Thread Vincent Povirk
+hr = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); +if (FAILED(hr)) +return E_FAIL; You should continue in this case, but don't call CoUninitialize at the end. On Mon, Apr 5, 2010 at 1:28 PM, Christian Costa wrote: > -- > Check return of CoInitializeEx and some WIC calls. Retu

Re: Working on "DOS" VGA.

2010-04-05 Thread k4king
<< While they focus mostly on games, they aren't against general fixes. >> not the experience I had on a number of non game related postings, I was told the couple of bytes it would take to add support for a vesa std text video mode would add to much bloat and hit a number of other "it will not h

Re: [PATCH 3/7] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets)

2010-04-05 Thread Christian Costa
Henri Verbeet a écrit : On 5 April 2010 10:30, Christian Costa wrote: +inline ctab_constant* get_constant(D3DXHANDLE ptr) +{ +if (!ptr) return NULL; +return (ctab_constant*)~(DWORD)ptr; +} + +inline D3DXHANDLE get_handle(ctab_constant* ptr) +{ +return (D3DXHANDLE)~((DWORD)ptr); +

Hello, All! Interested in GSoC

2010-04-05 Thread Bradley Tucker
Hello everyone, I am Bradley Tucker, a junior computer science major at Tennessee Tech University, and I am very interested in participating in the Google Summer of Code. I have a strong passion for developing video games, and it sounds like working with the Wine Project this summer would be

Re: [PATCH 4/7] d3dx9_36: Implement D3DXGetImageInfoFromFileInMemory using WindowsCodecs (based on work from Tony Wasserka)

2010-04-05 Thread Vincent Povirk
> +CoUninitialize(); You should call this function only if your original CoInitializeEx call succeeded. It may fail in a multithreaded apartment (in which case WIC won't work either, but that's a bug), and in that case the uninitialize is not needed. Also, you seem to be leaving things uninit

re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found

2010-04-05 Thread Dan Kegel
"Mikhail Maroukhine" wrote: > user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found > Behavior checked on Windows XP Welcome to Wine development! Poker playing penguins salute you. As Dmitry wrote, adding a test case would be a good idea; see http://wiki.winehq.org/WritingCo

Re: [PATCH 6/7] d3dx9_36: Add stub for D3DXCreateTextureFromFileA

2010-04-05 Thread Henri Verbeet
On 5 April 2010 10:30, Christian Costa wrote: > +FIXME("(%p, %s, %p): stub\n", device, srcfile, texture); "srcfile" is an external string, this should use debugstr_a().

Re: [PATCH 3/7] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets)

2010-04-05 Thread Henri Verbeet
On 5 April 2010 10:30, Christian Costa wrote: > +inline ctab_constant* get_constant(D3DXHANDLE ptr) > +{ > +if (!ptr) return NULL; > +return (ctab_constant*)~(DWORD)ptr; > +} > + > +inline D3DXHANDLE get_handle(ctab_constant* ptr) > +{ > +return (D3DXHANDLE)~((DWORD)ptr); > +} These lo

Re: [PATCH 1/2] amstream: Expose also IMultiMediaStream which is the base interface of IAMMultiMediaStream (patch from Qingchuan Wang)

2010-04-05 Thread Henri Verbeet
On 5 April 2010 10:55, Christian Costa wrote: > The proper way to do attribution is by adding an appropriate From: line to the patch, preferably by simply passing --author with the right information to git commit.

Re: [PATCH 2/7] d3dx9_36: Improve FIXMEs and TRACEs for surface

2010-04-05 Thread Henri Verbeet
On 5 April 2010 10:30, Christian Costa wrote: > @@ -71,7 +71,8 @@ HRESULT WINAPI D3DXGetImageInfoFromFileA(LPCSTR file, > D3DXIMAGE_INFO *info) > LPWSTR widename; > HRESULT hr; > int strlength; > -TRACE("(void): relay\n"); > + > +TRACE("(%s, %p): relay\n", file, info); You

Re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found

2010-04-05 Thread Dmitry Timoshkov
"Mikhail Maroukhine" wrote: > user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found > Behavior checked on Windows XP Please add a test case for this. > +return retWnd ? retWnd : (hwndCtrl ? hwndCtrl : hwndDlg); Using an 'if' case would be more readable IMO. -- Dmitry.

Re: [GSOC] dshow/gst branch rebased and commented

2010-04-05 Thread Roderick Colenbrander
On Mon, Apr 5, 2010 at 10:45 AM, Edward Hervey wrote: > Hi all, > >  I took some time this morning to rebase tdavenport's gst/dshow branch > against current master and added my comments/reviews in the last commit. > >  The branch can be found here : > http://github.com/bilboed/wine/tree/tdaven-reb

[GSOC] dshow/gst branch rebased and commented

2010-04-05 Thread Edward Hervey
Hi all, I took some time this morning to rebase tdavenport's gst/dshow branch against current master and added my comments/reviews in the last commit. The branch can be found here : http://github.com/bilboed/wine/tree/tdaven-rebased I'm putting this out so that if any student is interested