Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

Dmitry Timoshkov a écrit : Eric Pouech wrote: hmm sounds like most of the code we have in not in sync [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136

Re: WineD3D BltOverride overhaul

On 24 March 2010 20:03, Roderick Colenbrander wrote: > I have experimented a bit with the design (intially only color fill > since that's quite independent). Note this is just a proof of concept > (some of the helper functions would become separate patches). This > patch is the current code in the

Re: usbhub.sys: add stubbed usbhub.sys

Damjan Jovanovic writes: > On Wed, Mar 24, 2010 at 9:51 PM, Alexandre Julliard > wrote: >> Damjan Jovanovic writes: >> >>> usbhub.sys isn't accessed via exports and I don't think anything >>> depends on usbhub.sys specifically - but on Windows it builds device >>> objects for USB devices and d

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

On Wed, Mar 24, 2010 at 3:52 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Hope this makes the rationale a bit clearer. Although admittedly the >> patch does allow for some busy waiting since >> if (mask & FD_READ  || async_waiting( sock->read_q )) ev |= POLLIN | POLLPRI; >> should

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests

On 03/24/2010 08:36 PM, Mike Kaplinskiy wrote: On Wed, Mar 24, 2010 at 12:17 PM, Paul Vriens wrote: On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: --- dlls/ws2_32/tests/Makefile.in |2 +- dlls/ws2_32/tests/sock.c | 735 + 2 files changed,

Re: usbhub.sys: add stubbed usbhub.sys

On Wed, Mar 24, 2010 at 9:51 PM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> usbhub.sys isn't accessed via exports and I don't think anything >> depends on usbhub.sys specifically - but on Windows it builds device >> objects for USB devices and does I/O to these, so it seems like th

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

Mike Kaplinskiy writes: > Hope this makes the rationale a bit clearer. Although admittedly the > patch does allow for some busy waiting since > if (mask & FD_READ || async_waiting( sock->read_q )) ev |= POLLIN | POLLPRI; > should be more like > if ( (mask & FD_READ && !async_busy( sock->read_q )

Re: usbhub.sys: add stubbed usbhub.sys

Damjan Jovanovic writes: > usbhub.sys isn't accessed via exports and I don't think anything > depends on usbhub.sys specifically - but on Windows it builds device > objects for USB devices and does I/O to these, so it seems like the > best place to do those in Wine too. I'm not convinced that sp

Re: usbhub.sys: add stubbed usbhub.sys

On Wed, Mar 24, 2010 at 9:24 PM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> The same as Etersoft's USB patches: for doing USB I/O to USB devices. > > Obviously, but why do you specifically need usbhub.sys given that it > doesn't export anything?  What is there that depends on havin

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests

On Wed, Mar 24, 2010 at 12:17 PM, Paul Vriens wrote: > On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: >> >> --- >>  dlls/ws2_32/tests/Makefile.in |    2 +- >>  dlls/ws2_32/tests/sock.c      |  735 >> + >>  2 files changed, 672 insertions(+), 65 deletions(-)

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

On Wed, Mar 24, 2010 at 2:50 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> POLLIN/POLLOUT are selected if we have pending asyncs (as they should >> be), but we shouldn't add these as pending events since the associated >> overlapped operations aren't done yet. We can't say for sure

Re: usbhub.sys: add stubbed usbhub.sys

Damjan Jovanovic writes: > The same as Etersoft's USB patches: for doing USB I/O to USB devices. Obviously, but why do you specifically need usbhub.sys given that it doesn't export anything? What is there that depends on having it? -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] d3dxof: Increase MAX_SUBOBJECTS and do the corresponding checks at the right place

Henri Verbeet a écrit : I notice several of these limits have been increased in the past, sometimes multiple times. What exactly are these supposed to protect against? At the beginning, it was to make things simpler but now the code is stabilized and remaining static arrays within struct

Re: configure.ac: detect libusb-1.0

On Wednesday 24 March 2010 18:43:22 Damjan Jovanovic wrote: > On Wed, Mar 24, 2010 at 6:58 PM, Albert Lee wrote: >> There are multiple libusb implementations (notably, Solaris libusb >> and FreeBSD libusb20) and it would be necessary to do an API test >> for those, rather than using pkgconfig. >

Re: d3dx9_36: Add stubbed interface for ID3DXEffect

Ok. I'll do it. A+ Christian David Adam a écrit : Hello, I removed my wine git, so I am not able to send a patch. It would be great if you could do it. A+ David 2010/3/23 Christian Costa > Hello David, Indeed. shader.c has the same problem. Fe

Re: configure.ac: detect libusb-1.0

On Wed, 24 Mar 2010 19:43:22 +0200, Damjan Jovanovic wrote: > On Wed, Mar 24, 2010 at 6:58 PM, Albert Lee wrote: >> On Wed, 24 Mar 2010 16:15:59 +0200, Damjan Jovanovic >> wrote: >>> Changelog: >>> * configure.ac: detect libusb-1.0 >>> >> >> There are multiple libusb implementations (notably, So

Re: WineD3D BltOverride overhaul

On Wed, Mar 24, 2010 at 1:19 PM, Henri Verbeet wrote: > On 24 March 2010 12:53, Roderick Colenbrander wrote: >> Now back to the blitter design. Henri's proposal is to have several >> blitters for this discussion reduce it to shader_blit and cpu_blit. >> The cpu_blit would be the software fall bac

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

Mike Kaplinskiy writes: > POLLIN/POLLOUT are selected if we have pending asyncs (as they should > be), but we shouldn't add these as pending events since the associated > overlapped operations aren't done yet. We can't say for sure if we > should notify about these events or not until the async i

Re: usbhub.sys: add stubbed usbhub.sys

On Wed, Mar 24, 2010 at 8:30 PM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> Changelog: >> * usbhub.sys: add stubbed usbhub.sys > > What is this going to be useful for? > > -- > Alexandre Julliard > julli...@winehq.org > The same as Etersoft's USB patches: for doing USB I/O to USB

Re: i7 920 not quite twice as fast as Q9300 at building wine

On Wed, Mar 24, 2010 at 6:44 AM, Dan Kegel wrote: > On Wed, Mar 24, 2010 at 1:08 AM, Lei Zhang wrote: >> Even though Nehalem is a better architecture, you don't get the 2x (or >> better) speed up because the extra 4 cores are from hyperthreading. >> With 8 real Nehalem cores and -j9, I got 3m24s.

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

On Wed, Mar 24, 2010 at 2:28 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> --- >>  server/async.c |    8 >>  server/file.h  |    1 + >>  server/sock.c  |   26 +++--- >>  3 files changed, 20 insertions(+), 15 deletions(-) > > This doesn't look right. You

Re: crypt32: Don't dereference a potentially NULL pointer without checking it (Coverity)

Juan Lang writes: > Fixes Coverity ids 1046 and 1047. Thanks to Paul Vriens for bringing > it to my attention. Setting sep to an empty string would probably make the whole thing a lot cleaner. -- Alexandre Julliard julli...@winehq.org

Re: usbhub.sys: add stubbed usbhub.sys

Damjan Jovanovic writes: > Changelog: > * usbhub.sys: add stubbed usbhub.sys What is this going to be useful for? -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

Mike Kaplinskiy writes: > --- > server/async.c |8 > server/file.h |1 + > server/sock.c | 26 +++--- > 3 files changed, 20 insertions(+), 15 deletions(-) This doesn't look right. You shouldn't ignore POLLIN/POLLOUT, they shouldn't have been selected in

Re: [PATCH 1/8] msvcrt: Update msvcrt.spec (try3)

Piotr Caban writes: > @@ -826,3 +826,579 @@ > @ cdecl wctomb(ptr long) MSVCRT_wctomb > @ varargs wprintf(wstr) MSVCRT_wprintf > @ varargs wscanf(wstr) MSVCRT_wscanf > +@ stub ??0bad_cast@@a...@pbqbd@Z > +@ stub ??0bad_cast@@q...@pbd@Z > +@ stub ??0exception@@q...@abqbdh@Z The added functions

Re: configure.ac: detect libusb-1.0

On Wed, Mar 24, 2010 at 6:58 PM, Albert Lee wrote: > On Wed, 24 Mar 2010 16:15:59 +0200, Damjan Jovanovic > wrote: >> Changelog: >> * configure.ac: detect libusb-1.0 >> > > There are multiple libusb implementations (notably, Solaris libusb and > FreeBSD libusb20) and it would be necessary to do a

Re: configure.ac: detect libusb-1.0

On Wed, 24 Mar 2010 16:15:59 +0200, Damjan Jovanovic wrote: > Changelog: > * configure.ac: detect libusb-1.0 > There are multiple libusb implementations (notably, Solaris libusb and FreeBSD libusb20) and it would be necessary to do an API test for those, rather than using pkgconfig. -Albert

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests

On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: --- dlls/ws2_32/tests/Makefile.in |2 +- dlls/ws2_32/tests/sock.c | 735 + 2 files changed, 672 insertions(+), 65 deletions(-) Hi Mike, I took the liberty of running your new tests on winetest

Re: i7 920 not quite twice as fast as Q9300 at building wine

On Wed, Mar 24, 2010 at 1:08 AM, Lei Zhang wrote: > Even though Nehalem is a better architecture, you don't get the 2x (or > better) speed up because the extra 4 cores are from hyperthreading. > With 8 real Nehalem cores and -j9, I got 3m24s. With 8 cores + > hyperthreading, I get 2m49s. Is that

Re: WineD3D BltOverride overhaul

On 24 March 2010 12:53, Roderick Colenbrander wrote: > Now back to the blitter design. Henri's proposal is to have several > blitters for this discussion reduce it to shader_blit and cpu_blit. > The cpu_blit would be the software fall back for a blit, colorfill or > whatever operation. It's not ne

Re: WineD3D BltOverride overhaul

On Wed, Mar 24, 2010 at 12:35 PM, Stefan Dösinger wrote: > Am Mittwoch 24 März 2010 12:00:48 schrieb Henri Verbeet: >> On 24 March 2010 11:55, Roderick Colenbrander > wrote: >> > Sure color keying needs to be handled by the fragment pipe. Though I >> > would like to avoid touching that area right

Re: WineD3D BltOverride overhaul

Am Mittwoch 24 März 2010 12:00:48 schrieb Henri Verbeet: > On 24 March 2010 11:55, Roderick Colenbrander wrote: > > Sure color keying needs to be handled by the fragment pipe. Though I > > would like to avoid touching that area right now since I don't know > > anything about it and I had a feelin

Re: WineD3D BltOverride overhaul

On 24 March 2010 11:55, Roderick Colenbrander wrote: > Sure color keying needs to be handled by the fragment pipe. Though I > would like to avoid touching that area right now since I don't know > anything about it and I had a feeling when I talked about it with > Stefan that this code is a bit fra

Re: WineD3D BltOverride overhaul

On Tue, Mar 23, 2010 at 11:05 PM, Henri Verbeet wrote: > On 23 March 2010 18:41, Roderick Colenbrander wrote: >> Hi, > ... >> > How about something along these general lines: > > blitter_setup_context(src, dst, rop, ...) > { >    context = context_acquire(src/dst/NULL); >    select shader / setup

Re: include: Add some multimedia defines not present in win9x.

wrote: > +#define MOD_WAVETABLE 6 /* hardware watetable internal synth */ A typo? -- Dmitry.

Re: steam regressed?

On 24 March 2010 06:57, Dan Kegel wrote: > Oh, foo.  OK, the real result is: > > > 7b52c2fbed561ac381f63826bab97802d0070e46 is first bad commit > commit 7b52c2fbed561ac381f63826bab97802d0070e46 > Author: Henri Verbeet > Date:   Tue Mar 16 19:02:20 2010 +0100 > >    wined3d: Cleanup IWineD3DDevice

Re: i7 920 not quite twice as fast as Q9300 at building wine

On Tue, Mar 23, 2010 at 4:11 PM, Dan Kegel wrote: > Not as exciting an improvement as I'd hoped: > > 4 GB RAM > Intel(R) Core(TM)2 Quad  CPU   Q9300  @ 2.50GHz > make -j5 > real    7m35.985s > user    24m54.741s > sys     3m15.628s > > 6 GB RAM > model name      : Intel(R) Core(TM) i7 CPU