d3dx9_36: Add stubbed interface for ID3DXEffect

2010-03-22 Thread David Adam
Hello, the 2 lines + #include "d3dx9.h" + #include "d3dx9effect.h" in the d3dx9_36/effect.c file are useless, since in the d3dx9_private file, one calls d3dx9.h file which calls d3dx9effect.h A+ David

Re: [PATCH 5/6] msvcr90: Implement _encode_pointer and _decode_pointer

2010-03-22 Thread Piotr Caban
On 03/22/10 17:27, Alexandre Julliard wrote: This doesn't build on 64-bit Mingw because it comes with its own version of these functions. He's away for a week, can I fix it? Or should I wait until he's back before sending patches that depends on this functions?

Re: 4/4 wined3d: move color keyed blitting in its own function

2010-03-22 Thread Henri Verbeet
On 22 March 2010 22:36, Roderick Colenbrander wrote: > +static HRESULT > surface_blt_color_keyed_surface_to_drawable(IWineD3DSurfaceImpl *This, const > RECT *DestRect, IWineD3DSurfaceImpl *Src, const RECT *SrcRect, DWORD Flags, > WINEDDCOLORKEY SrcColorkey) Calling the destination surface "Thi

Re: [PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-22 Thread Eric Lanz
Thank you, I will take a look at your changes, correct my work and re-submit. Eric On Mar 22, 2010, at 4:44 PM, Nikolay Sivov wrote: > On 3/22/2010 23:26, Eric Lanz wrote: >> Hello, >> >> Decided to keep it simple for my first patch. SysStringLen was returning 0 >> for bstrs from our updater

Re: [PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-22 Thread Nikolay Sivov
On 3/22/2010 23:26, Eric Lanz wrote: Hello, Decided to keep it simple for my first patch. SysStringLen was returning 0 for bstrs from our updater application which caused the domdoc_createNode function to exit early even though the bstr actually contained a valid name. It seems that other f

Re: Google Summer of Code ideas

2010-03-22 Thread Charles Davis
On 3/22/10 12:22 PM, Roderick Colenbrander wrote: > Previous attempts at a Quartz driver roughly the tried to create a new > driver in a design similar to winex11. If we start a new driver, the > current driver design and winex11 need to be cleaned up. This requires > a dib engine :( Further I expe

[PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-22 Thread Eric Lanz
Hello, Decided to keep it simple for my first patch. SysStringLen was returning 0 for bstrs from our updater application which caused the domdoc_createNode function to exit early even though the bstr actually contained a valid name. It seems that other functions in this file use strlenW for t

Re: [8/10] shell32: Implement some IShellFolderView methods over IFolderView

2010-03-22 Thread Nikolay Sivov
On 3/22/2010 22:09, Paul Vriens wrote: On 03/22/2010 01:01 PM, Nikolay Sivov wrote: Implement some IShellFolderView methods over IFolderView Hi Nikolay, +/* ::MoveIcons */ +hr = IShellFolderView_MoveIcons(folderview, NULL); +ok(hr == E_NOTIMPL, "got (0x%08x)\n", hr); + This one

Re: [8/10] shell32: Implement some IShellFolderView methods over IFolderView

2010-03-22 Thread Paul Vriens
On 03/22/2010 01:01 PM, Nikolay Sivov wrote: Implement some IShellFolderView methods over IFolderView Hi Nikolay, +/* ::MoveIcons */ +hr = IShellFolderView_MoveIcons(folderview, NULL); +ok(hr == E_NOTIMPL, "got (0x%08x)\n", hr); + This one makes Win98 and win95 (both with shell32

Re: Google Summer of Code ideas

2010-03-22 Thread Stefan Dösinger
Am Montag 22 März 2010 18:49:36 schrieb Charles Davis: > 1. Quartz Driver. This is something a lot of Wine-on-Mac users (myself > included) have been wanting for while now. Of course, the entire driver > itself is a big project, so I would limit the scope to implementing a > small piece of it--say,

Re: [2/2] dlls/crypt32: unit test PFXImportCertStore()

2010-03-22 Thread Juan Lang
Hi Philippe, in addition to the question I had on patch 1/2, I'd like to know, what is the purpose of this test? +static void test_createCertificateStore(void) +{ +HCERTSTORE certStore = NULL; + +certStore = CertOpenStore(CERT_STORE_PROV_SYSTEM, 0, (HCRYPTPROV)NULL, +CERT_SYSTEM_ST

Re: [1/2] dlls/crypt32: implement PFXImportCertStore()

2010-03-22 Thread Juan Lang
Hi Phillippe, this attempt looks pretty incomplete. First off: +ret = pPKCS12_verify_mac(pkcs12, password, len); +if (ret == 0) +ERR_(crypt)("failed to verify pkcs12 {%p} with password \"%s\" using func {%p}\n", pkcs12, password, pPKCS12_verify_mac); +else +TRACE_(cry

Re: Google Summer of Code ideas

2010-03-22 Thread Roderick Colenbrander
On Mon, Mar 22, 2010 at 6:49 PM, Charles Davis wrote: > Hi, > > I intend to participate in the Google Summer of Code this year, and I > have several ideas for Wine that I'd like to bounce off you guys to see > what you think. Note that all my proposals are Mac OS-based (I run Mac > OS X), so many

Google Summer of Code ideas

2010-03-22 Thread Charles Davis
Hi, I intend to participate in the Google Summer of Code this year, and I have several ideas for Wine that I'd like to bounce off you guys to see what you think. Note that all my proposals are Mac OS-based (I run Mac OS X), so many of you will never see the results of what I'm working on. Here th

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Alexandre Julliard
Joel Holdsworth writes: > Speaking personally: This project has already taken me over a year to get this > far, and after all this painstaking work I'm really keen to get it out to the > world, but I'm so short of time right now, and it feels like every time I try > and submit, there are more of

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Juan Lang
Hi Joel, I'm piping up not because I can speak for Alexandre--I can't--but to express that you're not the only one interested in seeing this work merged. > It is possible with a multipage SVG (which Inkscape doesn't support yet, and > can't be rendered RSVG) and embedded bitmaps for the hand twea

Re: Re : shell32: Add IShellFolderView:: GetSelectedObjects implementation for IShellView.

2010-03-22 Thread Nikolay Sivov
On 3/22/2010 19:35, Juan Lang wrote: Hi Nikolay, I know this one's already been comitted, but I have a small complaint about a comment: +/* it's documented that caller shouldn't PIDLs, only array itself */ I think you're missing a verb there. A caller shouldn't do what to PIDLs, exactl

Re: Verbose explanation about the cygwin issue

2010-03-22 Thread Steven Edwards
On Mon, Mar 22, 2010 at 12:47 PM, Steven Edwards wrote: > My thinking was, if we require mingw on cygwin, then that would solve > the winegcc problem and the rest of wine could be built including wine > msvcrt, applications that linked to msvcrt would of course have to use > Wine msvcrt because if

Re: Verbose explanation about the cygwin issue

2010-03-22 Thread Steven Edwards
On Sat, Mar 20, 2010 at 2:49 PM, Alexandre Julliard wrote: >> And what about #ifdef __CYGWIN__ ? >> It sounds ugly but ... why not ? > > You can't use #ifdefs in winegcc. I suppose you could try to resolve > __wargv dynamically at run-time. I was wondering if it was possible under current cygwin

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Joel Holdsworth
  On 22 March 2010 at 15:37 Alexandre Julliard wrote: > Joel Holdsworth writes: > > >> I still think that having to commit 10 source files per icon is not > >> acceptable, even with subdirectories. > > I agree it is a lot of source files, but I don't see that that's a problem > > if > > they're

Re : shell32: Add IShellFolderView:: GetSelectedObjects implementation for IShellView.

2010-03-22 Thread Juan Lang
Hi Nikolay, I know this one's already been comitted, but I have a small complaint about a comment: +/* it's documented that caller shouldn't PIDLs, only array itself */ I think you're missing a verb there. A caller shouldn't do what to PIDLs, exactly? Perhaps it should be obvious to me,

Re: [PATCH 5/6] msvcr90: Implement _encode_pointer and _decode_pointer

2010-03-22 Thread Alexandre Julliard
Detlef Riekenberg writes: > --- > dlls/msvcr90/msvcr90.c| 21 + > dlls/msvcr90/msvcr90.spec |4 ++-- > 2 files changed, 23 insertions(+), 2 deletions(-) This doesn't build on 64-bit Mingw because it comes with its own version of these functions. -- Alexandre Jull

Re: [PATCH 1/7] msvcr90: Added _encode_pointer and _decode_pointer tests

2010-03-22 Thread Paul Vriens
On 03/22/2010 05:01 PM, Piotr Caban wrote: +if(!p_encode_pointer || !p_decode_pointer) { +skip("_encode_pointer or _decode_pointer not found\n"); +return; +} win_skip() is more appropriate as these are implemented on Wine. -- Cheers, Paul.

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Alexandre Julliard
Joel Holdsworth writes: >> I still think that having to commit 10 source files per icon is not >> acceptable, even with subdirectories. > I agree it is a lot of source files, but I don't see that that's a problem if > they're stored neatly within a resources subdirectory. user32.dll has a lot of

Re: Warnings on ignored returned values

2010-03-22 Thread Alexandre Julliard
Nate Gallaher writes: > Should --enable-maintainer-mode be purged then, or should some > additional flag magic be added? I ran into this a long time ago as > well and made the assumption that it had bitrotted. Maintainer mode is meant to be used by the maintainer, i.e. by me. It works just fine

Re: Warnings on ignored returned values

2010-03-22 Thread Marcus Meissner
On Mon, Mar 22, 2010 at 03:28:17PM +0200, Octavian Voicu wrote: > On Mon, Mar 22, 2010 at 3:21 PM, Nate Gallaher > wrote: > > Should --enable-maintainer-mode be purged then, or should some additional > > flag magic be added?  I ran into this a long time ago as well and made the > > assumption that

Re: Warnings on ignored returned values

2010-03-22 Thread Octavian Voicu
On Mon, Mar 22, 2010 at 3:21 PM, Nate Gallaher wrote: > Should --enable-maintainer-mode be purged then, or should some additional > flag magic be added?  I ran into this a long time ago as well and made the > assumption that it had bitrotted. Actually, in my case the problem is with Ubuntu -- the

Re: Warnings on ignored returned values

2010-03-22 Thread Nate Gallaher
Alexandre Julliard wrote: Octavian Voicu writes: Hello, I'm trying to compile wine with --enable-maintainer-mode and I get lots of errors like `ignoring return value of ‘xxx’, declared with attribute warn_unused_result'. I would like to submit a few patches to fix them. Please don't

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Joel Holdsworth
  > I still think that having to commit 10 source files per icon is not > acceptable, even with subdirectories. I agree it is a lot of source files, but I don't see that that's a problem if they're stored neatly within a resources subdirectory. user32.dll has a lot of images, but that's not a prob

Re: Warnings on ignored returned values

2010-03-22 Thread Alexandre Julliard
Octavian Voicu writes: > Hello, > > I'm trying to compile wine with --enable-maintainer-mode and I get > lots of errors like `ignoring return value of ‘xxx’, declared with > attribute warn_unused_result'. I would like to submit a few patches to > fix them. Please don't. The warnings are spurious

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Alexandre Julliard
Joel Holdsworth writes: > Sure - I > can understand that. The reason I sent so many was that I wanted to show you > that I don't plan to leave a depreciated SVG build rule lying around. I also > wanted you to see and comment on my approach of creating resources > subdirectories in these dlls like

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Joel Holdsworth
  Alexandre Julliard wrote: > Joel Holdsworth writes: > > > @@ -188,6 +188,11 @@ filter: dummy > >  .man.in.man: > >          LC_ALL=C sed -e 's,@bindir\@,$(bindir),g' -e > >'s,@dlldir\@,$(dlldir),g' -e 's,@PACKAGE_STRING\@,@PACKAGE_STRING@,g' $< >$@ > >|| ($(RM) $@ && false) > >  > > +# Rules f

Warnings on ignored returned values

2010-03-22 Thread Octavian Voicu
Hello, I'm trying to compile wine with --enable-maintainer-mode and I get lots of errors like `ignoring return value of ‘xxx’, declared with attribute warn_unused_result'. I would like to submit a few patches to fix them. I noticed there's a page on the wiki for this: http://wiki.winehq.org/Ignor

Re: rpcrt4: Added stub function CreateStubFromTypeInfo

2010-03-22 Thread Nikolay Sivov
On 3/22/2010 12:32, Alistair Leslie-Hughes wrote: Hi, Changelog: rpcrt4: Added stub function CreateStubFromTypeInfo +typedef INT (WINAPI *MessageBoxA)(HWND,LPCSTR,LPCSTR,UINT); +HMODULE hUser32 = LoadLibraryA("user32"); +MessageBoxA pMessageBoxA = (void *)GetProcAddress(hUse

Re: [PATCH 02/48] Added new icon build rule

2010-03-22 Thread Alexandre Julliard
Joel Holdsworth writes: > @@ -188,6 +188,11 @@ filter: dummy > .man.in.man: > LC_ALL=C sed -e 's,@bindir\@,$(bindir),g' -e 's,@dlldir\@,$(dlldir),g' > -e 's,@PACKAGE_STRING\@,@PACKAGE_STRING@,g' $< >$@ || ($(RM) $@ && false) > > +# Rules for icons > + > +ifdef SVG_SRCS > + > +# Deprecia

Re: [PATCH 01/11] ws2_32: use ntstatus in overlapped functions (try 3)

2010-03-22 Thread Alexandre Julliard
Mike Kaplinskiy writes: > Make get_sock_events return error codes in unix format. Also some > style fixes. Sorry for the fuss over this :) The server should not be returning errno values directly. It should return NT status codes. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 3/8] [Include]: added a wine/dwarf.h to share dwarf2 debug information data where needed

2010-03-22 Thread Alexandre Julliard
Eric Pouech writes: > A+ > --- > > dlls/dbghelp/dwarf.c |2 > dlls/dbghelp/dwarf.h | 420 > dlls/ntdll/signal_x86_64.c | 207 > include/wine/dwarf.h | 465 > > 4

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 2]

2010-03-22 Thread Paul Vriens
On 03/22/2010 07:59 AM, Ilya Basin wrote: Hi! Sorry for being annoying, will you accept my patch? http://www.winehq.org/pipermail/wine-patches/2010-March/086009.html Hi Ilya, That's not up to us. Whenever you sent a patch to wine-patch everybody is free to comment (or sent a reply that they

Re: makefiles: Use the standard C_SRCS variable as the list of test files

2010-03-22 Thread Ilya Basin
Looks like after this commit: http://source.winehq.org/git/wine.git/?a=commit;h=6164ce2d820546ae5b26eb504bc108091c5679ea the command ./tools/winapi/msvcmaker --no-wine silently fails: only 'winetest.dsp' created

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 2]

2010-03-22 Thread Ilya Basin
Hi! Sorry for being annoying, will you accept my patch? http://www.winehq.org/pipermail/wine-patches/2010-March/086009.html --