Re: winegcc: Link with msvcrt on windows because of __wargv

2010-03-20 Thread James McKenzie
GOUJON Alexandre wrote: > Le 03/19/10 03:42, James McKenzie a écrit : >> Please use [try 2] for any second send. Keeps things in order and lets >> others know that you have responded to errors. Also, put comments in >> the same message as the patch they apply to at the top of the message. >> >> T

Re: Verbose explanation about the cygwin issue

2010-03-20 Thread Alexandre Julliard
GOUJON Alexandre writes: > Le 03/20/10 15:57, Alexandre Julliard a écrit : >> You can't add include or lib options, that will break the Mingw >> build. >> > > And what about #ifdef __CYGWIN__ ? > It sounds ugly but ... why not ? You can't use #ifdefs in winegcc. I suppose you could try to re

Re: Verbose explanation about the cygwin issue

2010-03-20 Thread GOUJON Alexandre
Le 03/20/10 15:57, Alexandre Julliard a écrit : You can't add include or lib options, that will break the Mingw build. And what about #ifdef __CYGWIN__ ? It sounds ugly but ... why not ? Thanks

Re: Wanted: Summer of Code Mentors

2010-03-20 Thread Austin English
On Sat, Mar 20, 2010 at 9:48 AM, Maarten Lankhorst wrote: > Hi all, > > Any contributing wine members wishing to mentor for summer of code, or > help out with ranking proposals, please sign up as mentor for wine at > http://socghop.appspot.com/gsoc Of course if you want to apply as > student, you

Re: Verbose explanation about the cygwin issue

2010-03-20 Thread Alexandre Julliard
GOUJON Alexandre writes: > To fix it, we need to add msvcrt include (not to link with msvcrt : > it's a .o) > > ccache gcc-4 -D__WINE__ -c -o cmd.exe-iqnSoR-q4unrB.o cmd.exe-iqnSoR.c > -I../../include -I../../include/msvcrt/ > succeeds. > > At this point, we return from mingw_unicode_hack to line

Wanted: Summer of Code Mentors

2010-03-20 Thread Maarten Lankhorst
Hi all, Any contributing wine members wishing to mentor for summer of code, or help out with ranking proposals, please sign up as mentor for wine at http://socghop.appspot.com/gsoc Of course if you want to apply as student, you can't be a mentor. More feedback on the proposals is appreciated as we

Re: FIXME: shader trailing '\n's.

2010-03-20 Thread Henri Verbeet
On 20 March 2010 15:27, Francois Gouget wrote: > On Sat, 20 Mar 2010, Francois Gouget wrote: > >> --- >>  dlls/wined3d/shader.c |  132 >> >>  1 files changed, 66 insertions(+), 66 deletions(-) > > Argh! > > Ignore this one. I need to check it out a

Verbose explanation about the cygwin issue

2010-03-20 Thread GOUJON Alexandre
Alexandre, (I hope I'm not being direspectful) your patch (561a3e643ea8b35adfc032d3afa979c622fcec23) did not work. I know that there is no Cygwin VM in WineTestBot yet to test such a patch. I think I was not very clear about the issue on cygwin so this time I'll be more .. verbose. Here is t

Re: shell32: Add IPersistFile::GetCurFile implementation for IShellLink

2010-03-20 Thread Paul Vriens
On 03/18/2010 10:55 PM, Nikolay Sivov wrote: Fixes http://bugs.winehq.org/show_bug.cgi?id=19627 from 1.2 list. Hi Nikolay, This introduces some test failures on Win9x (not WinMe) and NT4 in the shlexec tests. Could you agree with the attached patch? -- Cheers, Paul. diff --git a/dlls/she

Re: inconsistencies in MCI headers w.r.t. to 64bit

2010-03-20 Thread Dmitry Timoshkov
wrote: > On 1/1/2004 you changed include/digitalv.h: > DWORD dwReturn to DWORD_PTR > However mmsystem.h uses DWORD. > > This is indeed what MSDN documents > http://msdn.microsoft.com/en-us/library/dd798406%28VS.85%29.aspx > http://msdn.microsoft.com/en-us/library/dd743409%28VS.85%29.aspx > > ye

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-20 Thread Dmitry Timoshkov
Eric Pouech wrote: > hmm sounds like most of the code we have in not in sync > > [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep > "%[0-9]*d" | wc -l > 8767 > [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep > "%[0-9]*x" | wc -l > 4136 I specifiacally me

Re: oleaut32: Use FADF_HAVEVARTYPE before FADF_RECORD for safearrays

2010-03-20 Thread Alistair Leslie-Hughes
A test case would be a good idea. After spending a consider amount of time trying to writing a test case, It always failed on an XP box. This patch would just hide the issue instead of truly fixing it. Best Regards Alistair Leslie-Hughes

Re: [PATCH] msvcr90/tests: Add tests for _initterm_e [try 2]

2010-03-20 Thread Detlef Riekenberg
On Sa, 2010-03-20 at 01:08 +0100, Piotr Caban wrote: > > You forgot to attach changes to configure.ac. Nope. That part is auto-generated, when Makefile.in is in the git tree: tools/make_makefiles Never add auto-generated changes to a patch -- By by ... Detlef