Re: [1/2] urlmon: Add stub IUriBuilder interface (try2)

2010-03-17 Thread Nikolay Sivov
On 3/18/2010 04:16, Nikolay Sivov wrote: I know comdlg32 doesn't seem to be very close to urlmon, but stub I added shows a problems in included headers order. SetPort method from IUriBuilder collides with SetPort define from winspool.h and a build error comes up saying I'm using unprefixed call

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline

2010-03-17 Thread Clemens Fruhwirth
On Wed, Mar 17, 2010 at 3:17 PM, Alexandre Julliard wrote: > Clemens Fruhwirth writes: > >> Would it be ok to add some override to Software\\Wine\\Fonts*? I'm >> using a rotated monitor and at least in Wine I would like to have >> properly rendered fonts. > > The first step would be to investigat

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline

2010-03-17 Thread Clemens Fruhwirth
On Wed, Mar 17, 2010 at 11:03 AM, Alexandre Julliard wrote: > Clemens Fruhwirth writes: > >> @@ -3090,8 +3090,10 @@ typedef struct tagCBTACTIVATESTRUCT >>  #define FE_FONTSMOOTHINGCLEARTYPE      0x0002 >>  #define FE_FONTSMOOTHINGDOCKING        0x8000 >> >> -#define FE_FONTSMOOTHINGORIENTATIONBGR

Re: [PATCH] attrib.exe: Add stubbed command

2010-03-17 Thread Detlef Riekenberg
On Mi, 2010-03-17 at 12:22 +0100, Christian Costa wrote: > +printf("attrib.exe is currently only a stub command\n"); > +printf("cmdline:"); UNICODE would be better, even for a stub. -- By by ... Detlef

Re: Small spelling fixes.

2010-03-17 Thread Vincent Povirk
Thanks for sending a patch for this. It seems it was not committed, probably because your mailer added line-breaks, making it difficult to apply. Could you resend as an attachment, or without the line breaks if you can configure your mailer to do that? Or, if you prefer, I can send this with fixe

Re: Measuring game FPS in wine/windows?

2010-03-17 Thread Roderick Colenbrander
On Wed, Mar 17, 2010 at 5:27 PM, Austin English wrote: > Howdy, > > I've been testing some games lately on Windows/Wine, and wanted to see > the difference in framerates. On windows, I've been using Fraps, which > works decently well, but not under wine (and it doesn't work for > Assassin's creed)

Measuring game FPS in wine/windows?

2010-03-17 Thread Austin English
Howdy, I've been testing some games lately on Windows/Wine, and wanted to see the difference in framerates. On windows, I've been using Fraps, which works decently well, but not under wine (and it doesn't work for Assassin's creed). I found D3DGears online, which supposedly works for Assassin's cr

Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in

2010-03-17 Thread Austin English
On Tue, Mar 16, 2010 at 7:57 PM, wrote: > Alright--I'll update and resubmit when I get home from work. > > The patch submission guidelines mentioned something about not including > Makefile or Makefile.in in patches and splitting them out instead.  Should I > be worried about that submission gu

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile

2010-03-17 Thread Paul Vriens
On 03/17/2010 04:21 PM, Ilya Basin wrote: @@ -1013,7 +1011,7 @@ static void test_filename(void) "%s failed: rc=%d err=%d\n", shell_call, rc, GetLastError()); } -else todo_wine +else { ok(rc==test->rc, "%s failed:

Re: winemp3.acm: support mp3 decoding on Mac OS/X systems

2010-03-17 Thread Alexandre Julliard
Aric Stewart writes: > uses CoreAudio's AudioConverter, AudioFile and AudioFileStream. > uses prefered systems for either (Snow) Leopard or Tiger deciding at > runtime. I don't think we have to care about Tiger compatibility here, especially since it involves so much extra code. -- Alexandre J

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline

2010-03-17 Thread Alexandre Julliard
Clemens Fruhwirth writes: > Would it be ok to add some override to Software\\Wine\\Fonts*? I'm > using a rotated monitor and at least in Wine I would like to have > properly rendered fonts. The first step would be to investigate how Windows handles that case. -- Alexandre Julliard julli...@win

Re: 1/3 wined3d: disable hw accelerated 8-bit blits in BltOverride

2010-03-17 Thread Henri Verbeet
On 17 March 2010 15:08, Roderick Colenbrander wrote: > Well, I discussed the situation with Stefan last weekend. He preferred > if I would make BltOverride a little bit nicer before I improved the > p8 stuff. He considered it a safe move to disable this for now. Within Cleaning things up is ok, bu

Re: 2/3 wined3d: add a helper function for drawing a textured quad

2010-03-17 Thread Henri Verbeet
On 17 March 2010 14:53, Roderick Colenbrander wrote: > This patch introduces a helper function for drawing a textured quad. A > future patch will also make use of it for the quad drawing part of > 'offscreen surface -> render target' in BltOverride (actually that > part will become two functions l

Re: 1/3 wined3d: disable hw accelerated 8-bit blits in BltOverride

2010-03-17 Thread Roderick Colenbrander
On Wed, Mar 17, 2010 at 2:54 PM, Henri Verbeet wrote: > On 17 March 2010 14:48, Roderick Colenbrander wrote: >> This first patch disables hardware accelerated 8-bit blitting. This >> code will completely use the shader backend later on and won't require >> hacks like 'paletteOverride'. >> > I'm n

Re: 1/3 wined3d: disable hw accelerated 8-bit blits in BltOverride

2010-03-17 Thread Henri Verbeet
On 17 March 2010 14:48, Roderick Colenbrander wrote: > This first patch disables hardware accelerated 8-bit blitting. This > code will completely use the shader backend later on and won't require > hacks like 'paletteOverride'. > I'm not sure breaking things is the right approach?

lstrcmpW on Windows ignores some special unicode characters

2010-03-17 Thread Paul Vriens
Hi, I already mentioned this in my last shlwapi patch. lstrcmpW (and CompareStringW for that matter) ignore some special unicode characters like 0x200e (and also loads of others). Do we care? I.o.w. is there a need for implementing this? I only tested these characters at the start of the str

Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.

2010-03-17 Thread Paul Vriens
On 03/17/2010 02:22 PM, Jacek Caban wrote: --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -16,6 +16,7 @@ bar ~dp0 should be directory containing batch file @p...@\ @p...@\ +...@pwd@@or_bro...@echo is off. Won't this fail on non English loc

Re: cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.

2010-03-17 Thread Jacek Caban
On 3/17/10 2:14 PM, Paul Vriens wrote: On 03/17/2010 02:10 PM, Jacek Caban wrote: --- programs/cmd/tests/batch.c | 39 - programs/cmd/tests/test_builtins.cmd.exp | 2 +- 2 files changed, 33 insertions(+), 8 deletions(-) Hi Jacek, Wasn't this test removed (for NT4 b

Re: [PATCH] cmd: removed %CD% test.

2010-03-17 Thread Jacek Caban
On 3/16/10 5:42 PM, Yann Droneaud wrote: Le mardi 16 mars 2010 à 11:25 -0500, Austin English a écrit : On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud wrote: %CD% seems not supported on Windows NT 4. The patch which introduce this test was based on MSDN documentation and only tested

Re: cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.

2010-03-17 Thread Paul Vriens
On 03/17/2010 02:10 PM, Jacek Caban wrote: --- programs/cmd/tests/batch.c | 39 - programs/cmd/tests/test_builtins.cmd.exp | 2 +- 2 files changed, 33 insertions(+), 8 deletions(-) Hi Jacek, Wasn't this test removed (for NT4 btw)? -- Cheers, Paul.

Re: [PATCH 09/13] shdocvw: Added more navigation tests.

2010-03-17 Thread Jacek Caban
Hi Paul, On 3/17/10 8:40 AM, Paul Vriens wrote: Hi Jacek, This one has introduced several test failures on a variety of platforms (or IE versions): http://test.winehq.org/data/tests/shdocvw:webbrowser.html Could you have a look? Sure, I've already sent a patch for most common failure. Th

Re: [PATCH] d3dx9_36: Add stub for D3DXCreateTextureFromFileInMemoryE

2010-03-17 Thread Henri Verbeet
On 17 March 2010 12:21, Christian Costa wrote: > +FIXME("(%p, %p, %d, %d, %d, %d, %x, %x, %x, %d, %d, %x, %p, %p, %p): > stub\n", device, srcdata, srcdatasize, width, > +height, miplevels, usage, format, pool, filter, mipfilter, colorkey, > srcinfo, palette, texture); Those integers

Re: [PATCH 2/3] d3dx9_36: Add missing GetSamplerIndex method to ID3DXConstantTable

2010-03-17 Thread Henri Verbeet
On 17 March 2010 12:20, Christian Costa wrote: > +#define ID3DXConstantTable_GetSamplerIndex(p,a) > (p)->lpVtbl->GetConstantDesc(p,a) > +#define ID3DXConstantTable_GetSamplerIndex(p,a) > (p)->GetConstantDesc(p,a) Looks wrong.

Re: [PATCH 1/2] d3dx9: Add d3dx9effect.h include file

2010-03-17 Thread Henri Verbeet
On 17 March 2010 12:21, Christian Costa wrote: > > +typedef struct _D3DXPASS_DESC { > +LPCSTR Name; > +UINT Annotations; > +DWORD VSVersion; > +DWORD PSVersion; > +UINT VSSemanticsUsed; > +D3DXSEMANTIC VSSemantics[MAXD3DDECLLENGTH]; > +UINT PSSemanticsUsed; > +D3DXS

Re: [PATCH 1/3] d3dx9_36: Implement ID3DXConstantTableImpl_GetDesc + tests (try 2)

2010-03-17 Thread Henri Verbeet
On 17 March 2010 12:20, Christian Costa wrote: > +error: > + > +if (object) > +HeapFree(GetProcessHeap(), 0, object->ctab); > +HeapFree(GetProcessHeap(), 0, object); "object" should never be NULL, all jumps to "error" are after the NULL check.

Re: usbd.sys: add usbd.sys (try 4)

2010-03-17 Thread Damjan Jovanovic
On Wed, Mar 17, 2010 at 11:10 AM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> Changelog: >> * usbd.sys: add usbd.sys >> >> Try 4 is the shortest possible patch. >> >> Copyright assigned to both me and Alexandre Morozov, since his patch >> is the basis of this one. > > The proper way

Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in

2010-03-17 Thread jgilik
Alright--I'll update and resubmit when I get home from work. The patch submission guidelines mentioned something about not including Makefile or Makefile.in in patches and splitting them out instead. Should I be worried about that submission guideline? --Original Message-- From: Dan Keg

Re: [3/4] d3d9: Remove the double unlock test

2010-03-17 Thread Henri Verbeet
On 17 March 2010 11:56, Stefan Dösinger wrote: > Windows 7 returns a different value than the test expects, and since its a > todo_wine it seems no game depends on it. > http://bugs.winehq.org/show_bug.cgi?id=19862 depends on that.

Re: [1/4] d3d9: Remove old debug messages from the tests

2010-03-17 Thread Henri Verbeet
On 17 March 2010 11:22, Stefan Dösinger wrote: > Adding a Sleep() instead isn't much of an improvement.

Re[2]: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 7]

2010-03-17 Thread Ilya Basin
There's a block of code in dlls/shell32/shlexec.c http://source.winehq.org/git/wine.git/?a=blob;f=dlls/shell32/shlexec.c;h=a81cada91fed264816a0946c06e83a00b7fb6484;hb=HEAD#l1681 It specially handles lpFile with '"' or containing spaces. Does anyone know a real situation when you need this handling

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline

2010-03-17 Thread Alexandre Julliard
Clemens Fruhwirth writes: > @@ -3090,8 +3090,10 @@ typedef struct tagCBTACTIVATESTRUCT > #define FE_FONTSMOOTHINGCLEARTYPE 0x0002 > #define FE_FONTSMOOTHINGDOCKING0x8000 > > -#define FE_FONTSMOOTHINGORIENTATIONBGR 0x > -#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define F

Re: [patch] DNS_SD bridge, v2

2010-03-17 Thread Marcus Meissner
On Tue, Mar 16, 2010 at 04:41:02PM -0600, C.W. Betts wrote: > Excuse my ignorance, but what would happen if it didn't find the library > dynamically? You would check this condition (like NULL handle or NULL function pointer) in every wrapped function and return an error condition in that case. O

Re: mmdevapi: Implement IMMDeviceEnumerator::GetDevice. patch

2010-03-17 Thread Maarten Lankhorst
Hoi Joris, On 16-03-10 21:31, Joris Huizer wrote: Hello, Maarten Lankhorst, I was browsing through the recent patches in git, I noticed some possible issue in this code: +for (i = 0; i< MMDevice_count; ++i) +{ +WCHAR *str; +dev = (IMMDevice*)MMDevice_head[i]; +

Re: usbd.sys: add usbd.sys (try 4)

2010-03-17 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * usbd.sys: add usbd.sys > > Try 4 is the shortest possible patch. > > Copyright assigned to both me and Alexandre Morozov, since his patch > is the basis of this one. The proper way to assign credit is not by adding copyright lines in the source, but by m

Re: [PATCH 09/13] shdocvw: Added more navigation tests.

2010-03-17 Thread Paul Vriens
On 03/13/2010 04:44 PM, Jacek Caban wrote: --- dlls/shdocvw/tests/webbrowser.c | 293 +-- 1 files changed, 218 insertions(+), 75 deletions(-) Hi Jacek, This one has introduced several test failures on a variety of platforms (or IE versions): http://test.w