Re: .net 3.5sp1 status check, blocking GFWL

2010-03-14 Thread Vitaliy Margolen
On 03/14/2010 07:27 PM, Edward Savage wrote: > My list currently includes Batman Arkham Asylum, Red Faction: > Guerrilla, Dawn of War 2 and several less popular titles. I wouldn't call Bioshock 2 a less popular title, which also uses gfwl. Vitaliy.

Re: [3/7] dxdiagn: Fix string copy behavior with an excessively short buffer in IDxDiagContainer::EnumChildContainerNames. (try 2)

2010-03-14 Thread Vitaliy Margolen
On 03/14/2010 03:14 PM, Andrew Nguyen wrote: > On Sun, Mar 14, 2010 at 3:08 PM, Vitaliy Margolen > wrote: >> On 03/14/2010 11:04 AM, Andrew Nguyen wrote: >>> +if (dwIndex == i) { >>>lstrcpynW(pwszContainer, p->contName, cchContainer); >>> - return S_OK; >>> + return (cchConta

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames. (try 2)

2010-03-14 Thread Vitaliy Margolen
On 03/14/2010 03:09 PM, Andrew Nguyen wrote: > On Sun, Mar 14, 2010 at 3:05 PM, Vitaliy Margolen > wrote: >> On 03/14/2010 11:03 AM, Andrew Nguyen wrote: >>> --- >>> >>> - >>> - TRACE("(%p, %u, %s, %u)\n", iface, dwIndex, debugstr_w(pwszContainer), >>> cchContainer); >> Please add printing of de

.net 3.5sp1 status check, blocking GFWL

2010-03-14 Thread Edward Savage
Several high profile games are currently being blocked from working by Games for Windows - Live. GFWL installs successfully under wine how ever is unable to run due to its reliance on .net 3.5sp1. Neither mono 2.4 or 2.6 currently for-fill its requirements. The games affected either install and

Re: msxml3: Treat input BSTR as general WCHAR string for ::loadXML()

2010-03-14 Thread Nikolay Sivov
On 3/14/2010 23:55, Vitaliy Margolen wrote: On 03/14/2010 02:08 PM, Nikolay Sivov wrote: http://bugs.winehq.org/show_bug.cgi?id=22020 Some applications don't bother to pass properly allocated BSTR as a ::loadXML() parameter, so we crash on invalid length taken from DWORD before passed poin

Re: [3/7] dxdiagn: Fix string copy behavior with an excessively short buffer in IDxDiagContainer::EnumChildContainerNames. (try 2)

2010-03-14 Thread Andrew Nguyen
On Sun, Mar 14, 2010 at 3:08 PM, Vitaliy Margolen wrote: > On 03/14/2010 11:04 AM, Andrew Nguyen wrote: >> --- a/dlls/dxdiagn/container.c >> +++ b/dlls/dxdiagn/container.c >> @@ -97,12 +97,10 @@ static HRESULT WINAPI >> IDxDiagContainerImpl_EnumChildContainerNames(PDXDIAGCONTAI >> >>    p = This-

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames. (try 2)

2010-03-14 Thread Andrew Nguyen
On Sun, Mar 14, 2010 at 3:05 PM, Vitaliy Margolen wrote: > On 03/14/2010 11:03 AM, Andrew Nguyen wrote: >> --- >>  dlls/dxdiagn/container.c       |   15 +-- >>  dlls/dxdiagn/tests/container.c |   49 >> >>  2 files changed, 56 insertions(+), 8 delet

Re: [3/7] dxdiagn: Fix string copy behavior with an excessively short buffer in IDxDiagContainer::EnumChildContainerNames. (try 2)

2010-03-14 Thread Vitaliy Margolen
On 03/14/2010 11:04 AM, Andrew Nguyen wrote: > --- a/dlls/dxdiagn/container.c > +++ b/dlls/dxdiagn/container.c > @@ -97,12 +97,10 @@ static HRESULT WINAPI > IDxDiagContainerImpl_EnumChildContainerNames(PDXDIAGCONTAI > >p = This->subContainers; >while (NULL != p) { > -if (dwIndex == i

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames. (try 2)

2010-03-14 Thread Vitaliy Margolen
On 03/14/2010 11:03 AM, Andrew Nguyen wrote: > --- > dlls/dxdiagn/container.c | 15 +-- > dlls/dxdiagn/tests/container.c | 49 > > 2 files changed, 56 insertions(+), 8 deletions(-) > > - > - TRACE("(%p, %u, %s, %u)\n", iface, dwIndex,

Re: msxml3: Treat input BSTR as general WCHAR string for ::loadXML()

2010-03-14 Thread Vitaliy Margolen
On 03/14/2010 02:08 PM, Nikolay Sivov wrote: > http://bugs.winehq.org/show_bug.cgi?id=22020 > > Some applications don't bother to pass properly allocated BSTR as a > ::loadXML() parameter, > so we crash on invalid length taken from DWORD before passed pointer. > Some tests verifying this would b

Re: Documentation?

2010-03-14 Thread Juan Lang
> Would documentation-only patches be accepted? For example, I can use > my lunch break at work to document functions but it's not long enough > to do any serious hacking. I only ask because I can't remember seeing > documentation only patches on wine-patches :) Indeed, yes. There have been some

Re: Documentation?

2010-03-14 Thread Luke Benstead
On 14 March 2010 12:08, Paul Vriens wrote: > On 03/14/2010 11:58 AM, Paul Vriens wrote: >> >> On 03/14/2010 11:45 AM, Luke Benstead wrote: >>> >>> On 14 March 2010 10:03, Roderick Colenbrander >>> wrote: On Sat, Mar 13, 2010 at 11:40 PM, Scott Ritchie wrote: > > On 03/12/201

Re: Documentation?

2010-03-14 Thread Paul Vriens
On 03/14/2010 11:58 AM, Paul Vriens wrote: On 03/14/2010 11:45 AM, Luke Benstead wrote: On 14 March 2010 10:03, Roderick Colenbrander wrote: On Sat, Mar 13, 2010 at 11:40 PM, Scott Ritchie wrote: On 03/12/2010 11:01 AM, André Hentschel wrote: Hi Folks, As we are getting somehow closer to Win

Re: Documentation?

2010-03-14 Thread Paul Vriens
On 03/14/2010 11:45 AM, Luke Benstead wrote: On 14 March 2010 10:03, Roderick Colenbrander wrote: On Sat, Mar 13, 2010 at 11:40 PM, Scott Ritchie wrote: On 03/12/2010 11:01 AM, André Hentschel wrote: Hi Folks, As we are getting somehow closer to Wine 1.2 i wonder how important updates on th

Re: winex11.drv: Set WM_COMMAND property so that xlsclients can list Wine.

2010-03-14 Thread Kusanagi Kouichi
On 2010-03-13 15:01:47 -0600, Vincent Povirk wrote: > You should create a WM_CLIENT_LEADER window as described here: > http://tronche.com/gui/x/icccm/sec-5.html > > That way, the windows belonging to a single client can be reliably > linked together. > > I think you can ignore the requirement tha

Re: Documentation?

2010-03-14 Thread Luke Benstead
On 14 March 2010 10:03, Roderick Colenbrander wrote: > On Sat, Mar 13, 2010 at 11:40 PM, Scott Ritchie wrote: >> On 03/12/2010 11:01 AM, André Hentschel wrote: >>> >>> Hi Folks, >>> As we are getting somehow closer to Wine 1.2 i wonder how important >>> updates on the Documentation are. >>> Furth

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames.

2010-03-14 Thread Paul Vriens
On 03/13/2010 11:39 PM, Vitaliy Margolen wrote: On 03/13/2010 11:27 AM, Paul Vriens wrote: On 03/13/2010 05:19 PM, Andrew Nguyen wrote: +lstrcpyW(container, testW); This won't work on Win9x/WinMe as most of these W-functions are not available. According to MS: Windows 95/98/Me: lstrcmpW

Re: Documentation?

2010-03-14 Thread Roderick Colenbrander
On Sat, Mar 13, 2010 at 11:40 PM, Scott Ritchie wrote: > On 03/12/2010 11:01 AM, André Hentschel wrote: >> >> Hi Folks, >> As we are getting somehow closer to Wine 1.2 i wonder how important >> updates on the Documentation are. >> Further i am confused about sending patches, should they just chang

Re: Wiki - 3D driver issues

2010-03-14 Thread Roderick Colenbrander
On Sun, Mar 14, 2010 at 4:23 AM, James McKenzie wrote: > Stefan Dösinger wrote: >> Am 08.03.2010 um 13:23 schrieb Roderick Colenbrander: >> >> >>> Hi, >>> >>> Multiple times a day you encounter people who can't get 3D working in >>> Wine. I'm getting so sick of these questions, that I decided to s