Re: Wiki - 3D driver issues

2010-03-13 Thread Charles Davis
On 3/13/10 8:23 PM, James McKenzie wrote: > Stefan Dösinger wrote: >> Am 08.03.2010 um 13:23 schrieb Roderick Colenbrander: >> >> >>> Hi, >>> >>> Multiple times a day you encounter people who can't get 3D working in >>> Wine. I'm getting so sick of these questions, that I decided to start >>> a

Re: [Try 2] WCMD_run_program overflow fix

2010-03-13 Thread James McKenzie
Eric Ho wrote: > Sorry Ive accidentally attached the patch for the expected test > outputs in the first patch, please replace the previous 1/4 and 4/4 > patch with these new ones, thanks > -Eric > > > Eric: Please resend the

Re: Wiki - 3D driver issues

2010-03-13 Thread James McKenzie
Stefan Dösinger wrote: > Am 08.03.2010 um 13:23 schrieb Roderick Colenbrander: > > >> Hi, >> >> Multiple times a day you encounter people who can't get 3D working in >> Wine. I'm getting so sick of these questions, that I decided to start >> a new page on the Wiki. >> http://wiki.winehq.org/3DDr

Re: Documentation?

2010-03-13 Thread Scott Ritchie
On 03/12/2010 11:01 AM, André Hentschel wrote: Hi Folks, As we are getting somehow closer to Wine 1.2 i wonder how important updates on the Documentation are. Further i am confused about sending patches, should they just change the git-repo "docs" or the pages on the website or both? The web

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames.

2010-03-13 Thread Vitaliy Margolen
On 03/13/2010 11:27 AM, Paul Vriens wrote: > On 03/13/2010 05:19 PM, Andrew Nguyen wrote: >> +lstrcpyW(container, testW); > This won't work on Win9x/WinMe as most of these W-functions are not > available. According to MS: Windows 95/98/Me: lstrcmpW is supported by the Microsoft Layer for Unic

Re: winex11.drv: Set WM_COMMAND property so that xlsclients can list Wine.

2010-03-13 Thread Vincent Povirk
You should create a WM_CLIENT_LEADER window as described here: http://tronche.com/gui/x/icccm/sec-5.html That way, the windows belonging to a single client can be reliably linked together. I think you can ignore the requirement that the client leader window have an id from the session manager. I

Re: usbd.sys: add usbd.sys (try 2)

2010-03-13 Thread Damjan Jovanovic
Nothing "works" with these patches applied (yet), but drivers importing usbd.sys start to load successfully. Damjan On Sat, Mar 13, 2010 at 6:36 PM, Uwe Bonnes wrote: > Damjan, > > can you tell us what to expect to work with these patches applied? > > And to  Alexandre: Please -vv if rejected...

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames.

2010-03-13 Thread Paul Vriens
On 03/13/2010 08:11 PM, Andrew Nguyen wrote: On Sat, Mar 13, 2010 at 12:27 PM, Paul Vriens wrote: On 03/13/2010 05:19 PM, Andrew Nguyen wrote: +/* Test the conditions in which the output buffer can be modified. */ +lstrcpyW(container, testW); +hr = IDxDiagContainer_EnumChildConta

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames.

2010-03-13 Thread Andrew Nguyen
On Sat, Mar 13, 2010 at 12:27 PM, Paul Vriens wrote: > On 03/13/2010 05:19 PM, Andrew Nguyen wrote: >> >> +    /* Test the conditions in which the output buffer can be modified. */ >> +    lstrcpyW(container, testW); >> +    hr = IDxDiagContainer_EnumChildContainerNames(pddc, 0, container, 0); >>

Re: windowscodecs: Make component enumerators thread-safe.

2010-03-13 Thread Vincent Povirk
I'm told I need to unset DebugInfo->Spare[0] before deleting the critical section. Which makes this wrong. On Sat, Mar 13, 2010 at 12:37 PM, Vincent Povirk wrote: > > > > > >

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames.

2010-03-13 Thread Paul Vriens
On 03/13/2010 05:19 PM, Andrew Nguyen wrote: +/* Test the conditions in which the output buffer can be modified. */ +lstrcpyW(container, testW); +hr = IDxDiagContainer_EnumChildContainerNames(pddc, 0, container, 0); +ok(hr == E_INVALIDARG, + "Expected IDxDiagContainer::EnumC

Re: usbd.sys: add usbd.sys (try 2)

2010-03-13 Thread Uwe Bonnes
Damjan, can you tell us what to expect to work with these patches applied? And to Alexandre: Please -vv if rejected... -- Uwe Bonnesb...@elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt - Tel. 06151 162516 F

Re: usbd.sys: add usbd.sys (try 2)

2010-03-13 Thread André Hentschel
> + * Copyright (C) 2010 Damjan Jovanovic > + * Copyright (C) 2009 Alexander Morozov Hi Damjan, I would rotate theese lines to be ordered by Year like: > + * Copyright (C) 2009 Alexander Morozov > + * Copyright (C) 2010 Damjan Jovanovic -- Best Regards, André Hentschel

Re: [1/2] usbd.sys: add usbd.sys to configure.ac

2010-03-13 Thread Nikolay Sivov
On 3/13/2010 15:28, Damjan Jovanovic wrote: Changelog: * usbd.sys: add usbd.sys to configure.ac Damjan Jovanovic That makes no sense to separate this from next patch.

Re: comctl32: [Bug 17251] cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-03-13 Thread Nikolay Sivov
On 3/13/2010 13:38, Alexandru Balut wrote: On Sat, Mar 13, 2010 at 10:30, Nikolay Sivov wrote: Also I'm not sure what you mean here --- textlenT(pszText, isW)+2 --- pszText is Edit control text at this point (or NULL). How it's related to LISTVIEW_GetItemW? And what this +2 adding mean?

Re: comctl32: [Bug 17251] cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-03-13 Thread Alexandru Balut
On Sat, Mar 13, 2010 at 10:30, Nikolay Sivov wrote: > Also I'm not sure what you mean here > --- > textlenT(pszText, isW)+2 > --- > pszText is Edit control text at this point (or NULL). How it's related to > LISTVIEW_GetItemW? And what this +2 adding mean? The +2 appears because cchTextMax "inclu

Re: comctl32: [Bug 17251] cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-03-13 Thread Nikolay Sivov
On 3/13/2010 06:35, Jeff Latimer wrote: If not set then no value is returned and in the case of uTorrent the next entry selected is renamed. http://bugs.winehq.org/show_bug.cgi?id=17251 No value returned from what? A test case has proved difficult to construct as the event is triggered by

Re: wineaudiofile.acm: Initial commit

2010-03-13 Thread Ken Thomases
On Mar 12, 2010, at 12:12 PM, Aric Stewart wrote: > Henri Verbeet wrote: >>> +ERR("Feed Error %c%c%c%c\n", (char) (ret>> 24), >>> + (char) (ret>> 16), >>> + (char) (ret>> 8), >>> + (