Re: [2/3] shell32: Implement SHParseDisplayName with basic tests

2010-03-03 Thread Paul Vriens
On 03/03/2010 03:18 AM, Nikolay Sivov wrote: This call is used by open file function of IE7. Some added tests crash on W2K and below. I already sent a patch for that (http://source.winehq.org/patches/data/58988). There are however also failures introduced on Vista+: http://test.winehq.org/

Re: [PATCH] d3dx9_36: Avoid dereferencing null pointers in trace (spotted by Paul Vriens)

2010-03-03 Thread Paul Vriens
On 03/04/2010 08:20 AM, Christian Costa wrote: --- dlls/d3dx9_36/shader.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) I just spotted it in the Coverity reports ;) -- Cheers, Paul.

Re: Change Journal and VSS analog in Wine

2010-03-03 Thread James McKenzie
Michael Stefaniuc wrote: > Dmitry Konnov wrote: > >> MS> well I would phrase that differently: the backend that collects and >> MS> restores the data from the filesystem needs to be a native application. >> >> but Change Journal is ntdll.dll DeviceIoControl with certain >> options call. >>

Re: Help testing a test

2010-03-03 Thread Juan Lang
> Hi, Juan. Bot accepts patches as well, it does a build/crossbuild job too. Sweet! Thanks! :) --Juan

Re: winmm/midi tests and VMware

2010-03-03 Thread Ben Klein
On 3 March 2010 19:26, Paul Vriens wrote: > On 03/03/2010 08:47 AM, Ben Klein wrote: >> Given that hardware connections to external synthesisers are, at least >> in the Linux-side context, considered "synthesisers", I'm not sure >> what you mean by this. >> > > For the record, I'm running VMware W

Re: Help testing a test

2010-03-03 Thread Nikolay Sivov
On 3/3/2010 22:48, Juan Lang wrote: Hi all, apologies that I don't have a crosstest build system set up at the moment, so I'm unable to compile this and run it on WineTestBot. Does anyone have a few spare moments to try these tests for me? If they fail, please tell me which platform and include

Re: mountmgr.sys not running on OpenBSD - depends on dbus/hal, or a timing issue?

2010-03-03 Thread Ken Thomases
On Mar 3, 2010, at 12:12 PM, Austin English wrote: > The main question I have though, is that I can't get winetest to run > there. When I run ./wine winetest or ./wine winetest-latest.exe, > winetest begins to load, then bails out, saying mountmgr.sys isn't > running, likely because my wineprefix

Help testing a test

2010-03-03 Thread Juan Lang
Hi all, apologies that I don't have a crosstest build system set up at the moment, so I'm unable to compile this and run it on WineTestBot. Does anyone have a few spare moments to try these tests for me? If they fail, please tell me which platform and include output. Thanks very much, --Juan Fro

mountmgr.sys not running on OpenBSD - depends on dbus/hal, or a timing issue?

2010-03-03 Thread Austin English
Howdy, I asked this in #winehackers yesterday, but didn't get a reply. Perhaps someone here knows. I've been testing wine on OpenBSD, with their patches from port, and with a few patches/hacks, notepad runs :-). The big issues are mmap, which OpenBSD is really protective of. Luckily, their port h

Re: wined3d: Don't crash when opengl is not available.

2010-03-03 Thread Austin English
On Wed, Mar 3, 2010 at 4:55 AM, Stefan Dösinger wrote: > > Am 02.03.2010 um 18:39 schrieb Henri Verbeet: >> (I also still haven't seen anyone make a *convincing* argument for why >> we'd want to have a "somewhat working, but not quite" wined3d if we >> don't have OpenGL in the first place.) > In t

GetKeyboardLayout: actual keyboard or locale-dependent?

2010-03-03 Thread Joerg-Cyril.Hoehle
Hi, I believe either user32/input.c erroneously skips some tests, or the wording of the skip message is misleading. It says: input.c:897: Tests skipped: Skipping Input_blackbox test on non-US keyboard It bases its choice on GetKeyboardLayout(0) == 0x04090x0409. However, GetKeyboardLayout's value

Re: [PATCH 01/14] include: Added IHTMLPrivateWindow declaration.

2010-03-03 Thread Jacek Caban
On 3/3/10 12:26 PM, Alexandre Julliard wrote: Jacek Caban writes: Following patch series implements changes in MSHTML needed to change navigation in MSHTML/WebBrowser control. WebBrowser should reuse existing document if it declares that it can handle navigation (via another almost undocum

Re: 3/2 wined3d: move palette uploading code over to blit_shader

2010-03-03 Thread Henri Verbeet
On 3 March 2010 13:51, Roderick Colenbrander wrote: > -HRESULT (*set_shader)(IWineD3DDevice *iface, const struct > GlPixelFormatDesc *format_desc, > +HRESULT (*set_shader)(IWineD3DDevice *iface, IWineD3DSurfaceImpl > *surface, > GLenum textype, UINT width, UINT height); If y

Re: Change Journal and VSS analog in Wine

2010-03-03 Thread Michael Stefaniuc
Dmitry Konnov wrote: > MS> well I would phrase that differently: the backend that collects and > MS> restores the data from the filesystem needs to be a native application. > > but Change Journal is ntdll.dll DeviceIoControl with certain > options call. No. It is a functionality of the NTFS filesy

Re: [PATCH 1/2] user32: Fix return value of EDIT_EM_Scroll. (try 2)

2010-03-03 Thread David Hedberg
On Wed, Mar 3, 2010 at 12:53 PM, Alexandre Julliard wrote: > David Hedberg writes: > >> Brings the return value in line with msdn and test results. >> >> This time without the skips. Return values other than 0 are somewhat >> unlikely, but strictly speaking only one value is wrong (and important

Re: [PATCH 1/2] user32: Fix return value of EDIT_EM_Scroll. (try 2)

2010-03-03 Thread Alexandre Julliard
David Hedberg writes: > Brings the return value in line with msdn and test results. > > This time without the skips. Return values other than 0 are somewhat > unlikely, but strictly speaking only one value is wrong (and important > for the tests here). I wouldn't expect it to ever return somethi

Re: [PATCH 01/14] include: Added IHTMLPrivateWindow declaration.

2010-03-03 Thread Alexandre Julliard
Jacek Caban writes: > Following patch series implements changes in MSHTML needed to change > navigation in MSHTML/WebBrowser control. WebBrowser should reuse > existing document if it declares that it can handle navigation (via > another almost undocumented method that is mentioned: > http://msdn

Re: Change Journal and VSS analog in Wine

2010-03-03 Thread Michael Stefaniuc
Hello Dmitry, Dmitry Konnov wrote: > MS> what do you try to do? Porting a Windows backup software to MacOSX using > MS> Wine? > > yes. > > MS> That won't work if the intent is to backup the whole MacOSX > MS> system. The native filesystems have their peculiarities that Wine > MS> doesn't expose

Re: wined3d: Don't crash when opengl is not available.

2010-03-03 Thread Stefan Dösinger
Am 02.03.2010 um 18:39 schrieb Henri Verbeet: > (I also still haven't seen anyone make a *convincing* argument for why > we'd want to have a "somewhat working, but not quite" wined3d if we > don't have OpenGL in the first place.) In the past there have been two reasons: *) Gentoo users "OMG I don

Re: [PATCH 1/2] user32: Fix return value of EDIT_EM_Scroll.

2010-03-03 Thread Alexandre Julliard
David Hedberg writes: > +static void test_edit_control_scroll(void) > +{ > +static const char *single_line_str = "a"; > +HWND hwEdit; > +LONG ret; > + > +/* Check the return value when EM_SCROLL doesn't actually scroll > + * anything. Should not return true if 0 lines were scr

Re: 1/2 wined3d: prepare yuv code for 8-bit palette support

2010-03-03 Thread Henri Verbeet
On 2 March 2010 20:24, Roderick Colenbrander wrote: > Hi, > > This patch is the first of two patches which will start a cleanup of > the surface code which is a big mess due to the 8-bit palette code. > The 8-bit code will be moved to the blit_shader code in a way similar > as is done for YUV. Thi

Re: 2/2 wined3d: start cleanup of 8-bit palette code

2010-03-03 Thread Henri Verbeet
On 2 March 2010 20:28, Roderick Colenbrander wrote: > +idx = getFmtIdx(WINED3DFMT_P8_UINT); > +gl_info->gl_formats[idx].color_fixup = > create_complex_fixup_desc(COMPLEX_FIXUP_P8); Strictly speaking this should be behind the extension check for paletted textures. Also, you have a couple

Re: Change Journal and VSS analog in Wine

2010-03-03 Thread Michael Stefaniuc
Hello Dmitry, Dmitry Konnov wrote: > I'm doing backup software. > > Can somebody advise on weather Wine has functionality of > ChangeJournal NTFS and Shadow Copy mechanism. > > I understand that ChangeJournal NTFS is NTFS file system feature > and Shadow Copy perhaps heavily dependent on Windows

Re: wined3d: Don't crash when opengl is not available.

2010-03-03 Thread Roderick Colenbrander
On Wed, Mar 3, 2010 at 8:14 AM, Kusanagi Kouichi wrote: > On 2010-03-02 18:06:00 +0100, Roderick Colenbrander wrote: >> In what situation does it exactly crash for you? Is it crashing >> because there is no libGL around? I'm not sure what the right thing to >> do is. Due to it our wglGetProcAddres

Re: winmm/midi tests and VMware

2010-03-03 Thread Paul Vriens
On 03/03/2010 08:47 AM, Ben Klein wrote: On 3 March 2010 18:10, Paul Vriens wrote: On 03/03/2010 01:30 AM, Ben Klein wrote: If I understand this correctly, Wine/the tests are correctly detecting an MPU-401 "hardware" synth device because the driver is loaded, but VMware doesn't emulate the ha

Change Journal and VSS analog in Wine

2010-03-03 Thread Dmitry Konnov
Hi All, I'm doing backup software. Can somebody advise on weather Wine has functionality of ChangeJournal NTFS and Shadow Copy mechanism. I understand that ChangeJournal NTFS is NTFS file system feature and Shadow Copy perhaps heavily dependent on Windows system. But I wonder weather these feat