Re: winmm/midi tests and VMware

2010-03-02 Thread Ben Klein
On 3 March 2010 18:10, Paul Vriens wrote: > On 03/03/2010 01:30 AM, Ben Klein wrote: >> >> If I understand this correctly, Wine/the tests are correctly detecting >> an MPU-401 "hardware" synth device because the driver is loaded, but >> VMware doesn't emulate the hardware and ends up confusing Win

Re: wined3d: Don't crash when opengl is not available.

2010-03-02 Thread Kusanagi Kouichi
On 2010-03-02 18:06:00 +0100, Roderick Colenbrander wrote: > In what situation does it exactly crash for you? Is it crashing > because there is no libGL around? I'm not sure what the right thing to > do is. Due to it our wglGetProcAddress won't function because it > relies on glXGetProcAddress. >

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/03/2010 01:30 AM, Ben Klein wrote: If I understand this correctly, Wine/the tests are correctly detecting an MPU-401 "hardware" synth device because the driver is loaded, but VMware doesn't emulate the hardware and ends up confusing Windows and hanging (presumably due to some I/O wait). I'd

Re: winmm/midi tests and VMware

2010-03-02 Thread Ben Klein
On 3 March 2010 06:47, Julius Schwartzenberg wrote: > Paul Vriens wrote: >> >> I give up. Tried several combinations on XP (old and newer driver with or >> without waveset files), to no avail. > > I found a solution. The earlier stuff I wrote here is completely unrelated. > The Creative soft-synth

Re: [PATCH 1/2] kernel32/tests: Add a test case for calling TlsFree on a freed index.

2010-03-02 Thread Nikolay Sivov
On 3/2/2010 23:04, Reece Dunn wrote: Hi, TlsFree should return FALSE if there wasn't a TLS slot of the specified index allocated, as well as returning ERROR_INVALID_PARAMETER. - Reece - ok(TlsFree(tlsIndex)!=0,"TlsFree failed\n"); + ok(TlsFree(tlsIndex)!=0,"TlsFree failed: %08x\n", Get

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 08:54 PM, Paul Vriens wrote: On 03/02/2010 08:47 PM, Julius Schwartzenberg wrote: Paul Vriens wrote: I give up. Tried several combinations on XP (old and newer driver with or without waveset files), to no avail. I found a solution. The earlier stuff I wrote here is completely un

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 08:47 PM, Julius Schwartzenberg wrote: Paul Vriens wrote: I give up. Tried several combinations on XP (old and newer driver with or without waveset files), to no avail. I found a solution. The earlier stuff I wrote here is completely unrelated. The Creative soft-synth included wi

Re: winmm/midi tests and VMware

2010-03-02 Thread Julius Schwartzenberg
Paul Vriens wrote: I give up. Tried several combinations on XP (old and newer driver with or without waveset files), to no avail. I found a solution. The earlier stuff I wrote here is completely unrelated. The Creative soft-synth included with the drivers using the wave sets works fine. It'

Re: [2/2] shlwapi: Implement SHFormatDateTimeA/SHFormatDateTimeW with tests

2010-03-02 Thread Nikolay Sivov
On 3/2/2010 21:13, Reece Dunn wrote: On 1 March 2010 17:39, Nikolay Sivov wrote: On 3/1/2010 20:01, Paul Vriens wrote: On 03/01/2010 12:56 AM, Nikolay Sivov wrote: Implement SHFormatDateTimeA/SHFormatDateTimeW with tests. Spotted in logs while testing IE6. Hi Ni

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 07:03 PM, Lei Zhang wrote: VMware can also emulate a Soundblaster 16. Does that have the MIDI capabilities needed? You need to change sound.virtualDev = "es1371" to sound.virtualdev = "sb16" in the .vmx file. Tried that, but then I have no device. The log shows: vcpu-0| SB16 does

Re: [2/2] shlwapi: Implement SHFormatDateTimeA/SHFormatDateTimeW with tests

2010-03-02 Thread Reece Dunn
On 1 March 2010 17:39, Nikolay Sivov wrote: > On 3/1/2010 20:01, Paul Vriens wrote: >> >> On 03/01/2010 12:56 AM, Nikolay Sivov wrote: >>> >>> Implement SHFormatDateTimeA/SHFormatDateTimeW with tests. >>> >>> Spotted in logs while testing IE6. >>> >> Hi Nikolay, >> >> This one introduces failures

Re: winmm/midi tests and VMware

2010-03-02 Thread Lei Zhang
On Tue, Mar 2, 2010 at 3:07 AM, Paul Vriens wrote: > On 03/02/2010 11:47 AM, Julius Schwartzenberg wrote: >> >> Hi Paul, >> >> Paul Vriens wrote: >>> >>> There are 2 ways (I can see) to fix this issue: >>> >>> 1. Get rid of (or disable) the sound device on the failing boxes. This >>> means of cour

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 06:51 PM, Maarten Lankhorst wrote: If you remove the midiOutReset call it works? What happens if you try to play a single note first? Hi Maarten, I will give that a try although I know I tried to use Microsoft Media Player 10 with that device and it hung as well. Removing the

Re: winmm/midi tests and VMware

2010-03-02 Thread Maarten Lankhorst
Hoi Paul, On 02-03-10 17:38, Paul Vriens wrote: On 03/02/2010 04:19 PM, Paul Vriens wrote: On 03/02/2010 04:05 PM, Maarten Lankhorst wrote: Instead of trying to work around the problem, could you try to find out exactly where and why it is hanging first? Hi Maarten, I've been in talks with

Re: wined3d: Don't crash when opengl is not available.

2010-03-02 Thread Henri Verbeet
On 2 March 2010 18:06, Roderick Colenbrander wrote: > I'm not sure about the shader backend part of the patch (I don't know > that code well), so I'm leaving that to Henri and Stefan. > You shouldn't be calling those if there's no GL. (I also still haven't seen anyone make a *convincing* argument

Re: wined3d: Don't crash when opengl is not available.

2010-03-02 Thread Roderick Colenbrander
In what situation does it exactly crash for you? Is it crashing because there is no libGL around? I'm not sure what the right thing to do is. Due to it our wglGetProcAddress won't function because it relies on glXGetProcAddress. Our use of wglGetProcAddress isn't correct (but it works on WINE :))

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Nikolay Sivov
On 3/2/2010 19:31, Alexandre Julliard wrote: Nikolay Sivov writes: Unfortunately I don't have a 64bit to cross-build a test on it. Should it just be 4? or there's something more complicated? Most likely more complicated, test cases are probably in order. Ok, just tried with test

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 04:19 PM, Paul Vriens wrote: On 03/02/2010 04:05 PM, Maarten Lankhorst wrote: Instead of trying to work around the problem, could you try to find out exactly where and why it is hanging first? Hi Maarten, I've been in talks with Jörg for several weeks now trying to figure out wh

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Alexandre Julliard
Nikolay Sivov writes: > Unfortunately I don't have a 64bit to cross-build a test on it. Should > it just be 4? or there's something more complicated? Most likely more complicated, test cases are probably in order. -- Alexandre Julliard julli...@winehq.org

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Paul Vriens
On 03/02/2010 05:26 PM, Nikolay Sivov wrote: On 3/2/2010 19:21, Paul Vriens wrote: On 03/02/2010 05:16 PM, Nikolay Sivov wrote: On 3/2/2010 19:01, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -239,6 +239,8 @@ static unsigned int get_type_size(ULONG *pFlags, VARTYPE vt) case VT_DISPATCH

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Nikolay Sivov
On 3/2/2010 19:21, Paul Vriens wrote: On 03/02/2010 05:16 PM, Nikolay Sivov wrote: On 3/2/2010 19:01, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -239,6 +239,8 @@ static unsigned int get_type_size(ULONG *pFlags, VARTYPE vt) case VT_DISPATCH: case VT_RECORD: return 0; + case VT_INT_PTR:

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Paul Vriens
On 03/02/2010 05:16 PM, Nikolay Sivov wrote: On 3/2/2010 19:01, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -239,6 +239,8 @@ static unsigned int get_type_size(ULONG *pFlags, VARTYPE vt) case VT_DISPATCH: case VT_RECORD: return 0; + case VT_INT_PTR: + return sizeof(INT_PTR); This won't

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Nikolay Sivov
On 3/2/2010 19:01, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -239,6 +239,8 @@ static unsigned int get_type_size(ULONG *pFlags, VARTYPE vt) case VT_DISPATCH: case VT_RECORD: return 0; +case VT_INT_PTR: +return sizeof(INT_PTR); This won't do

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize

2010-03-02 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -239,6 +239,8 @@ static unsigned int get_type_size(ULONG *pFlags, VARTYPE > vt) > case VT_DISPATCH: > case VT_RECORD: > return 0; > +case VT_INT_PTR: > +return sizeof(INT_PTR); This won't do the right thing on 64-bit. -- Alexandre Jull

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 04:05 PM, Maarten Lankhorst wrote: Instead of trying to work around the problem, could you try to find out exactly where and why it is hanging first? Hi Maarten, I've been in talks with Jörg for several weeks now trying to figure out why it fails. I tried dozens of combinations

Re: Improve Cygwin compatibility

2010-03-02 Thread John Klehm
On Mon, Mar 1, 2010 at 2:39 PM, Alexandre Goujon wrote: > /* >  *   __ A bit off topic __ >  * >  *      Replying "You need to give your real name in addition to the patch." >  * >  *      I hope this time all's ok. >  *      You now know who I am but I think it shouldn't be mandatory. >  *      I

Re: winmm/midi tests and VMware

2010-03-02 Thread Maarten Lankhorst
Hi Paul, On 02-03-10 11:28, Paul Vriens wrote: Just wanted your opinion on the following: VMware Workstation officially only supports MIDI output via the synthesizer device. The problem I'm having with several of my VMware boxes (and from the looks, Francois' boxes have the same issues) is t

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 02:27 PM, Julius Schwartzenberg wrote: Paul Vriens wrote: On 03/02/2010 01:33 PM, Julius Schwartzenberg wrote: I think some versions of the drivers come with with the required wavesets for the software synthesizer, while with others you had to get it from the original CD. You shou

Re: winmm/midi tests and VMware

2010-03-02 Thread Julius Schwartzenberg
Paul Vriens wrote: On 03/02/2010 01:33 PM, Julius Schwartzenberg wrote: I think some versions of the drivers come with with the required wavesets for the software synthesizer, while with others you had to get it from the original CD. You should make sure this ecw file is also present I guess. Th

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 01:33 PM, Julius Schwartzenberg wrote: I think some versions of the drivers come with with the required wavesets for the software synthesizer, while with others you had to get it from the original CD. You should make sure this ecw file is also present I guess. There seems to be some

Re: winmm/midi tests and VMware

2010-03-02 Thread Julius Schwartzenberg
Paul Vriens wrote: On 03/02/2010 11:47 AM, Julius Schwartzenberg wrote: Hi Paul, Paul Vriens wrote: There are 2 ways (I can see) to fix this issue: 1. Get rid of (or disable) the sound device on the failing boxes. This means of course far less coverage of tests. 2. There is an option in the A

Re: [PATCH 2/5] wined3d: refactoring - add a real gl vendor detection

2010-03-02 Thread Henri Verbeet
On 1 March 2010 19:27, PAUL ANDREW PANON wrote: > +gl_vendor = wined3d_guess_gl_vendor(gl_info, gl_string, gl_renderer); > card_vendor = wined3d_guess_card_vendor(gl_string, gl_renderer); > -TRACE_(d3d_caps)("found GL_VENDOR (%s)->(0x%04x)\n", > debugstr_a(gl_string), card_vendor); >

Re: winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
On 03/02/2010 11:47 AM, Julius Schwartzenberg wrote: Hi Paul, Paul Vriens wrote: There are 2 ways (I can see) to fix this issue: 1. Get rid of (or disable) the sound device on the failing boxes. This means of course far less coverage of tests. 2. There is an option in the Audio control panel t

Re: [PATCH] ole32: fix composite moniker behaviour.

2010-03-02 Thread Alexandre Julliard
Reece Dunn writes: > @@ -365,8 +365,7 @@ CompositeMonikerImpl_BindToObject(IMoniker* iface, > IBindCtx* pbc, > /* if the requested class was loaded before ! we don't need to > reload it */ > res = > IRunningObjectTable_GetObject(prot,iface,(IUnknown**)ppvResult); >

Re: winmm/midi tests and VMware

2010-03-02 Thread Alexandre Julliard
Paul Vriens writes: > 2. There is an option in the Audio control panel to only use the > default devices. This doesn't prevent the 'enumeration' from listing > the failing device but we could have the tests skip 'non default' > devices. The attached patch is a first attempt and does work on my XP

Re: winmm/midi tests and VMware

2010-03-02 Thread Julius Schwartzenberg
Hi Paul, Paul Vriens wrote: There are 2 ways (I can see) to fix this issue: 1. Get rid of (or disable) the sound device on the failing boxes. This means of course far less coverage of tests. 2. There is an option in the Audio control panel to only use the default devices. This doesn't prevent

winmm/midi tests and VMware

2010-03-02 Thread Paul Vriens
Hi Alexandre, Just wanted your opinion on the following: VMware Workstation officially only supports MIDI output via the synthesizer device. The problem I'm having with several of my VMware boxes (and from the looks, Francois' boxes have the same issues) is that the midi tests hang (not on al

Re: [PATCH] msvcrt: Add more exports as stubs (alphabetic sorted) [try 2]

2010-03-02 Thread Alexandre Julliard
Detlef Riekenberg writes: > stubs, which are used in the cpp tests are now commented out In general the others should be commented out too, for the same reason. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] d3dxof: Turn some TRACEs into WARNs in case of parsing error

2010-03-02 Thread Christian Costa
Yeah ! Absolutely ! I did a stg refresh and it took Henri's patch also. Thanks. > Message du 02/03/10 08:54 > De : "Paul Vriens" > A : "Christian Costa" > Copie à : wine-devel@winehq.org > Objet : Re: [PATCH] d3dxof: Turn some TRACEs into WARNs in case of parsing > error > > > On 03/02/2010