Re: msvcrt: Implement _mbctombb.

2010-02-23 Thread Maarten Lankhorst
Hi David, David Hedberg wrote: On Wed, Feb 24, 2010 at 7:12 AM, Maarten Lankhorst wrote: Hi David, Hi Maarten, David Hedberg wrote: +/* Maps multibyte cp932 punctuation marks to single byte equivalents */ +static unsigned int mbctombb_932_punct[] = { + 0x20,0xa4,0xa1,0x2

Re: msvcrt: Implement _mbctombb.

2010-02-23 Thread Maarten Lankhorst
Hi David, David Hedberg wrote: +/* Maps multibyte cp932 punctuation marks to single byte equivalents */ +static unsigned int mbctombb_932_punct[] = { + 0x20,0xa4,0xa1,0x2c,0x2e,0xa5,0x3a,0x3b,0x3f,0x21,0xde,0xdf,0x00,0x00,0x00,0x5e, + 0x7e,0x5f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x

Re: "make distclean" failing?

2010-02-23 Thread Austin English
On Tue, Feb 23, 2010 at 10:54 PM, Dan Kegel wrote: > James McKenzie wrote: >> Dan Kegel wrote: >>> "make distclean" failed for me today... >> >> I usually use just plain make clean.  Is this before/after today's commits? > > After. > > And I saw a similar error today in the valgrind continuous bu

Re: "make distclean" failing?

2010-02-23 Thread Dan Kegel
James McKenzie wrote: > Dan Kegel wrote: >> "make distclean" failed for me today... > > I usually use just plain make clean.  Is this before/after today's commits? After. And I saw a similar error today in the valgrind continuous build, which only does clean and testclean.

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-23 Thread Vincent Povirk
You should probably use a Bitmap object rather than the display for this, since the pixel format is important. That should make it possible to test other depths, even though they can't yet be implemented properly in Wine. Also, you should mark tests that fail in wine with todo_wine and remove the

"make distclean" failing?

2010-02-23 Thread Dan Kegel
"make distclean" failed for me today... after cleaning lots of stuff, it started trying to *build* something: ... make[1]: Leaving directory `/home/dank/wine-git/tools' config.status: creating tools/widl/Makefile make[1]: Entering directory `/home/dank/wine-git/tools/widl' ../../tools/makedep -C.

Re: dns-sd dll implementation -- Needs work

2010-02-23 Thread Gert van den Berg
On Tue, Feb 23, 2010 at 18:57, Steven Edwards wrote: > Do you really want to run the Windows version of VLC on OS X? I > believe there is a better case to be made with Safari/Quicktime/iTunes > as I believe they also install Bonjour services on Windows. If you > wanted to validate/compare how the

Re: [PATCH 9/9] oleaut32/tests: Added more typelib creation tests

2010-02-23 Thread Piotr Caban
Hi, On 02/23/10 19:38, Paul Vriens wrote: This one crashes on NT4 with just SP6a and W2K with just SP4 (tested Win98 just now and it crashes as well). Should we just "if (0)" this one? I'll remove this test. I was testing the function with incorrect parameter, probably it's not validated on

Re: [PATCH 9/9] oleaut32/tests: Added more typelib creation tests

2010-02-23 Thread Paul Vriens
On 02/22/2010 11:16 PM, Piotr Caban wrote: + +hres = ITypeInfo_GetRefTypeInfo(interface1, 16,&ti); +ok(hres == E_FAIL, "got %08x\n", hres); + Hi Piotr, This one crashes on NT4 with just SP6a and W2K with just SP4 (tested Win98 just now and it crashes as well). Should we just "if (0)

Re: [PATCH] include: Don't accidentally redefine a member in struct _IRP (LLVM/Clang).

2010-02-23 Thread Charles Davis
Disregard this patch, it breaks ntoskrnl. New patch forthcoming. Chip

Re: dns-sd dll implementation -- Needs work

2010-02-23 Thread Steven Edwards
On Tue, Feb 23, 2010 at 7:08 AM, Gert van den Berg wrote: > On OS X, it would also eliminate the need to install the Windows > version of Apple applications bundled with OS X in order to run things > that uses a single library provided by them. (e.g. Bonjour support in > VLC) Do you really want t

Re: Summer of code idea: make tiny game demos to expose problems in Wine

2010-02-23 Thread Dan Kegel
2010/2/23 Alexander Nicolaysen Sørnes : > Maybe someone can work on implementing dxdiag.exe in Wine? We could add some > extra tests compared to the Windows versions, and the small games could be a > part of that. Yeah, I've updated my proposal to mention that possibility, and to refer to http://w

Re: Summer of code idea: make tiny game demos to expose problems in Wine

2010-02-23 Thread Dan Kegel
On Tue, Feb 23, 2010 at 5:29 AM, Francois Gouget wrote: >> http://wiki.winehq.org/SummerOfCode#head-5cdc861e4369f94f0af19d09710d33d76b1f5c64 >> Current text: >> ... >> Let's try making the smallest possible demo games that show problems >> in Wine, and file bugs for what we find (along with the so

Re: Summer of code idea: make tiny game demos to expose problems in Wine

2010-02-23 Thread Julius Schwartzenberg
Alexander Nicolaysen Sørnes wrote: Maybe someone can work on implementing dxdiag.exe in Wine? We could add some extra tests compared to the Windows versions, and the small games could be a part of that. I'd say Wine's dxdiag should mainly run the existing DirectX tests and report any failure

Re: Summer of code idea: make tiny game demos to expose problems in Wine

2010-02-23 Thread Alexander Nicolaysen Sørnes
Tirsdag 23 februar 2010 14:51:09 skrev Roderick Colenbrander : > On Tue, Feb 23, 2010 at 2:29 PM, Francois Gouget wrote: > > On Sun, 21 Feb 2010, Dan Kegel wrote: > >> I've just added > >> http://wiki.winehq.org/SummerOfCode#head-5cdc861e4369f94f0af19d09710d33d > >>76b1f5c64 Current text: > >> "B

Re: Summer of code idea: make tiny game demos to expose problems in Wine

2010-02-23 Thread Roderick Colenbrander
On Tue, Feb 23, 2010 at 2:29 PM, Francois Gouget wrote: > On Sun, 21 Feb 2010, Dan Kegel wrote: > >> I've just added >> http://wiki.winehq.org/SummerOfCode#head-5cdc861e4369f94f0af19d09710d33d76b1f5c64 >> Current text: >> "Big games are hard to debug. >> Small demo games show interesting problems

Re: [2/5] WineD3D: Add an internal event query finish function

2010-02-23 Thread Henri Verbeet
On 16 February 2010 14:59, Stefan Dösinger wrote: > Patch 1: > if (!pData || !dwSize) return S_OK; ... > +if (data) This should be unnecessary, since you already checked "pData" above. Otherwise the patch looks reasonable. Patch 4: > +GLenum gl_ret = GL_EXTCALL(glClientWaitSync(

Re: Summer of code idea: make tiny game demos to expose problems in Wine

2010-02-23 Thread Francois Gouget
On Sun, 21 Feb 2010, Dan Kegel wrote: > I've just added > http://wiki.winehq.org/SummerOfCode#head-5cdc861e4369f94f0af19d09710d33d76b1f5c64 > Current text: > "Big games are hard to debug. > Small demo games show interesting problems in Wine (see e.g. > http://bugs.winehq.org/buglist.cgi?quicksearc

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.

2010-02-23 Thread Paul Vriens
On 02/23/2010 01:26 PM, Alexandre Julliard wrote: Paul Vriens writes: hi Alexandre, Is the idea to now use this function instead of all those different ones currently present in the tests? Sure. I'll keep that in mind when touching those files. -- Cheers, Paul.

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.

2010-02-23 Thread Alexandre Julliard
Paul Vriens writes: > hi Alexandre, > > Is the idea to now use this function instead of all those different > ones currently present in the tests? Sure. -- Alexandre Julliard julli...@winehq.org

Re: dns-sd dll implementation -- Needs work

2010-02-23 Thread Gert van den Berg
On Tue, Feb 23, 2010 at 09:37, Dmitry Timoshkov wrote: > "C.W. Betts" wrote: > >> What do you guys think? it's a wrapper for multicast DNS, aka Bonjour®. > > Looks like this is not a part of Windows or PSDK Neither is OpenAL It might provide functionality as part of Wine that might be hard

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.

2010-02-23 Thread Paul Vriens
On 02/20/2010 10:52 PM, Mikołaj Zalewski wrote: As I've learned, lstrcmpW doesn't work under Windows 9x, thus it is not a good choice to test functionality that existed in these version of Windows. On the other hand, strcmpW is not available on standalone builds on Windows. However, this funct

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.

2010-02-23 Thread Paul Vriens
On 02/20/2010 10:52 PM, Mikołaj Zalewski wrote: As I've learned, lstrcmpW doesn't work under Windows 9x, thus it is not a good choice to test functionality that existed in these version of Windows. On the other hand, strcmpW is not available on standalone builds on Windows. However, this funct

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams.

2010-02-23 Thread Alexandre Julliard
Reece Dunn writes: > @@ -395,9 +395,11 @@ static HRESULT WINAPI HGLOBALStreamImpl_Seek( > * If the file pointer ends-up after the end of the stream, the next Write > operation will > * make the file larger. This is how it is documented. > */ > - if (dlibMove.QuadPart < 0 && newPosit

Re: ptrace regression in Linux 2.6.33-rcX breaking Wine

2010-02-23 Thread Michael Stefaniuc
Hello! On 02/11/2010 05:54 PM, Michael Stefaniuc wrote: in case you have a Wine app that stopped working on Linux and you use 2.6.33-rcX kernels please give 2.6.32 a whirl. I finally sat down to track why the ntdll exception tests started to fail on my machines but not on other Fedora boxes. Tur

Re: PeekMsg/MsgWaitForMultipleObjects question

2010-02-23 Thread Alexandre Julliard
writes: > hopefully somebody familiar with messaging can immediately spot what's wrong > with the code below. > > The winmm/midi tests currently in git, using PeekMsg, show that the messages > (from CALLBACK_WINDOW) are almost always immediately available. > > Yet the code below, based on MsgWait

PeekMsg/MsgWaitForMultipleObjects question

2010-02-23 Thread Joerg-Cyril.Hoehle
Hi, hopefully somebody familiar with messaging can immediately spot what's wrong with the code below. The winmm/midi tests currently in git, using PeekMsg, show that the messages (from CALLBACK_WINDOW) are almost always immediately available. Yet the code below, based on MsgWaitFor... times out

Re: Another aspiring GSoC applicant..

2010-02-23 Thread Mikołaj Zalewski
David Hedberg pisze: > I've also looked a bit at implementing support for IFileDialog, and > the Explorer, but I have yet to dig too deep into either of them. Are > there currently any known applications out there that uses IFileDialog > explicitly? I've looked a bit, probably not enough, but I hav