Henri Verbeet a écrit :
On 22 February 2010 15:15, Christian Costa wrote:
More generally I would say that over-reviewing is not a good thing. It does
not bring much in term of
quality and slow down development. Thrust is the base of a community.
Sure, but that trust has to be justified
On 23 February 2010 07:33, Paul Vriens wrote:
> On 02/23/2010 01:28 AM, Reece Dunn wrote:
>>
>> + if (ret == E_INVALIDARG) /* Win98 SE */ {
>> + skip("Not supported\n");
>> + return;
>> + }
>
> Hi Reece,
>
> Could you turn that (and the other one) into a win_skip() ?
Done, tha
"C.W. Betts" wrote:
> What do you guys think? it's a wrapper for multicast DNS, aka Bonjour®.
Looks like this is not a part of Windows or PSDK, so Wine shouldn't include
it either.
--
Dmitry.
On 02/23/2010 01:28 AM, Reece Dunn wrote:
+if (ret == E_INVALIDARG) /* Win98 SE */ {
+skip("Not supported\n");
+return;
+}
Hi Reece,
Could you turn that (and the other one) into a win_skip() ?
--
Cheers,
Paul.
Hi C.W.,
> I know there's probably a patches mailing list, but I put this here for
> feedback.
This is the appropriate place to ask about patches that aren't ready
to commit yet.
+#include
At the least, you'll need to add configure checks for this header
file. I imagine you'll need to load th
What do you guys think? it's a wrapper for multicast DNS, aka Bonjour®.
I know there's probably a patches mailing list, but I put this here for
feedback.
dnssd.diff
Description: Binary data
Check create_event return value.
---
server/console.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/console.c b/server/console.c
index a79dc67..3758a71 100644
--- a/server/console.c
+++ b/server/console.c
@@ -294,7 +294,7 @@ static struct object *create_console_i
El 22/02/10 12:41, Austin English escribió:
On Mon, Feb 22, 2010 at 11:03 AM, Alex Villacís Lasso
wrote:
I have a VB6 application that requires oledb32 to convert from
DBTYPE_VARIANT to DBTYPE_BYTES, and fails with builtin oledb32 since
conversions to DBTYPE_BYTES are unimplemented. I set
On Mon, Feb 22, 2010 at 11:03 AM, Alex Villacís Lasso
wrote:
> I have a VB6 application that requires oledb32 to convert from
> DBTYPE_VARIANT to DBTYPE_BYTES, and fails with builtin oledb32 since
> conversions to DBTYPE_BYTES are unimplemented. I set up a VirtualBox VM with
> Windows XP and the
Maarten Lankhorst writes:
>> That doesn't match the PSDK I have, and yes it has a C definition that
>> is different from the C++ one, but is also different from yours.
> Mine doesn't seem to have a C definition at all, but from the
> devpropdef one I assume the C version takes a PROPERTYKEY as pa
Hi AJ,
2010/2/22 Alexandre Julliard :
> Maarten Lankhorst writes:
>
>>> This doesn't match the PSDK. Where does this come from?
>> In C, REFPROPERTYKEY becomes PROPERTYKEY*, in C++ it's PROPERTYKEY &,
>> so IsEqualPropertyKey will need a different macro. The psdk doesn't
>> define this properly f
Maarten Lankhorst writes:
>> This doesn't match the PSDK. Where does this come from?
> In C, REFPROPERTYKEY becomes PROPERTYKEY*, in C++ it's PROPERTYKEY &,
> so IsEqualPropertyKey will need a different macro. The psdk doesn't
> define this properly for the C case, but since I need it in C code I
Hi AJ,
2010/2/22 Alexandre Julliard :
> Maarten Lankhorst writes:
>
>> @@ -48,7 +48,11 @@
>> #endif
>>
>> #ifndef IsEqualPropertyKey
>> +#ifdef __cplusplus
>> #define IsEqualPropertyKey(a,b) (((a).pid == (b).pid) &&
>> IsEqualIID((a).fmtid,(b).fmtid))
>> +#else
>> +#define IsEqualPropertyKey(
I have a VB6 application that requires oledb32 to convert from
DBTYPE_VARIANT to DBTYPE_BYTES, and fails with builtin oledb32 since
conversions to DBTYPE_BYTES are unimplemented. I set up a VirtualBox VM
with Windows XP and the latest Cygwin in order to add a oledb32 test to
show me what should
On 22 February 2010 15:15, Christian Costa wrote:
> More generally I would say that over-reviewing is not a good thing. It does
> not bring much in term of
> quality and slow down development. Thrust is the base of a community.
Sure, but that trust has to be justified. I can certainly stop looking
Wrt the correctness of the behaviour about these parameters, it seems the
documentation is not
something we should rely on. That's why it's better to write test. So until
there is an app which rely
on this particular behaviour, this does not worth the trouble.
It's not from me. This is something
On 22 February 2010 13:43, Christian Costa wrote:
>
> Sure. Having tests is better but in this case there is no chance for
> regression.
> I usually write tests for my personnal pursose or to compare behaviour
> against real windows or native dll.
You write tests to prove your implementation is co
Sure. Having tests is better but in this case there is no chance for regression.
I usually write tests for my personnal pursose or to compare behaviour against
real windows or native dll.
I don't think lack of tests in this case should prevent integration. Tests can
be added later if needed.
Tha
I think tests would be appropriate.
On 21 February 2010 22:30, Christian Costa wrote:
> +if (IsEqualGUID(riid, &IID_IUnknown) ||
> +IsEqualGUID(riid, &IID_ID3DXConstantTable))
ID3DXConstantTable extends ID3DXBuffer.
> +ERR("Interface %s not found\n", debugstr_guid(riid));
Not implementing a random interface an appli
Christian Costa writes:
> @@ -627,6 +627,14 @@ static DWORD SHNotifyCopyFileW(LPCWSTR src, LPCWSTR
> dest, BOOL bFailIfExists)
>
> TRACE("(%s %s %s)\n", debugstr_w(src), debugstr_w(dest), bFailIfExists
> ? "failIfExists" : "");
>
> +if (PathFileExistsW(dest))
> +{
> +
Maarten Lankhorst writes:
> @@ -48,7 +48,11 @@
> #endif
>
> #ifndef IsEqualPropertyKey
> +#ifdef __cplusplus
> #define IsEqualPropertyKey(a,b) (((a).pid == (b).pid) &&
> IsEqualIID((a).fmtid,(b).fmtid))
> +#else
> +#define IsEqualPropertyKey(a,b) (((a)->pid == (b)->pid) &&
> IsEqualIID(&(a
2010/2/22 Dmitry Timoshkov :
> Mikołaj Zalewski wrote:
>
>> +/* strcmpW is avaiable for tests compiled under Wine, but not in standalone
>> + * builds under Windows, so we reimplement it under a different name. */
>> +static inline int winetest_strcmpW( const WCHAR *str1, const WCHAR *str2 )
>> +{
23 matches
Mail list logo
