Re: Adding wikipedia links to appdb?

2010-02-15 Thread Dan Kegel
On Thu, Feb 11, 2010 at 3:57 AM, Alexander Nicolaysen Sørnes wrote: >> > Dan Kegel wrote: >> >> I often want to learn more about an app while >> >> I'm in the appdb, and particularly, I want to know >> >> whether it has a good reputation.  Wikipedia >> >> can often tell me what I need to know.  I

re: Status of Patchwatcher

2010-02-15 Thread Dan Kegel
Seth Shelnutt wrote: > I am wondering what that status of patchwatcher is? It's waiting around for somebody to have time to start it up again. It's ugly code, written in shell and perl, which scares most people off. One has to wonder whether it shouldn't be done over again using buildbot, just t

Status of Patchwatcher

2010-02-15 Thread Seth Shelnutt
Hey guys, I am wondering what that status of patchwatcher is? I haven't seen anything on it since August where Scott Richie said he and Luke were working on reviving it. I see the code is still on Dan's google page. I am looking to do a GSoC project on appinstall and patchwatcher. I saw the ideal

Patch 1 for EM_FORMATRANGE

2010-02-15 Thread James McKenzie
All: I am working on the final version of the EM_FORMATRANGE patches. Thanks to Dylan Smith who has provided much feedback and corrections to these patches. James McKenzie >From ef39f8e81f6ffbcef1588356552fd05fce491978 Mon Sep 17 00:00:00 2001 From: James McKenzie Date: Mon, 15 Feb 2010 14:18:

Re: Intercepting GDI calls

2010-02-15 Thread Ove Kaaven
Steve Brown skrev: > On Mon, 15 Feb 2010, Ove Kaaven wrote: > >> James McKenzie skrev: >>> I'll agree that this is duplication of the existing X11 code, but the >>> effect is more pleasant to the eye and leads to less user confusion, not >>> to speak of a less expensive solution (I have yet to fin

Re: shlwapi: URL_ParseUrl should not fail if there is not :\\

2010-02-15 Thread Aric Stewart
Thanks for the nudge. I am finding that there are more extensive issues with our UrlGetPart that this was just masking. I am working on a new patch and tests. -aric Nikolay Sivov wrote: On 2/15/2010 22:07, Aric Stewart wrote: allows acceptance of urls such as about:blank --- dlls/shlwapi/u

Re: Intercepting GDI calls

2010-02-15 Thread Steve Brown
On Mon, 15 Feb 2010, Ove Kaaven wrote: James McKenzie skrev: I'll agree that this is duplication of the existing X11 code, but the effect is more pleasant to the eye and leads to less user confusion, not to speak of a less expensive solution (I have yet to find a 'free' X11 client that is worth

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]

2010-02-15 Thread Justin Chevrier
On Mon, Feb 15, 2010 at 9:34 AM, Aric Stewart wrote: > Hi, > >  I am really happy that you are helping with the msctf stuff I started. Very > cool! > >  2 quick things. > > 1) typedef struct tagACLMulti,   don't call it tagACLMulti.  I am sure this > is from copying from threadmgr.c where it is a

Re: shlwapi: URL_ParseUrl should not fail if there is not :\\

2010-02-15 Thread Nikolay Sivov
On 2/15/2010 22:07, Aric Stewart wrote: allows acceptance of urls such as about:blank --- dlls/shlwapi/url.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Could you add a small test for that?

Re: Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?

2010-02-15 Thread Roderick Colenbrander
On Mon, Feb 15, 2010 at 3:40 PM, Warren Dumortier wrote: > As a simple user i have a question. > Will WIne include the patch once it exists and is accepted or will the > Wine team only include it once all major distros use the new Xorg? > I'm really looking forward XInput2 in Wine, but maybe both

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling

2010-02-15 Thread Marcus Meissner
On Mon, Feb 15, 2010 at 06:46:06PM +0200, Paul Chitescu wrote: > > -strcpy(pData->u.network.szNames, "Entire Network"); > > +memcpy(pData->u.network.szNames, "Entire Network", sizeof("Entire > Network")+1); > > Please use a const buffer as "Entire Network" is a string literal, not

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling

2010-02-15 Thread Paul Chitescu
> -strcpy(pData->u.network.szNames, "Entire Network"); > +memcpy(pData->u.network.szNames, "Entire Network", sizeof("Entire Network")+1); Please use a const buffer as "Entire Network" is a string literal, not something with a clearly defined size (not even talking about length).

Re: [jscript]add korean translation

2010-02-15 Thread James McKenzie
Hwangsee: This needs to be resubmitted in UTF format, not HTML as Piotr pointed out. Very good work otherwise. Also, thank you for using the formal version rather than the informal. James McKenize Hwang YunSong(황윤성) wrote: > --- a/dlls/jscript/Makefile.in 2010-02-12 10:23:39.603312863 +0900 >

Re: Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?

2010-02-15 Thread Vitaliy Margolen
On 02/15/2010 02:51 AM, Roderick Colenbrander wrote: > On Mon, Feb 15, 2010 at 2:13 AM, Dan Kegel wrote: >> On Sun, Feb 14, 2010 at 4:46 PM, Ben Klein wrote: >>> On 15 February 2010 11:13, Dan Kegel wrote: I recall that Paul Hampson did a first cut at using XI2, linked to from the bott

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]

2010-02-15 Thread Aric Stewart
Hi, I am really happy that you are helping with the msctf stuff I started. Very cool! 2 quick things. 1) typedef struct tagACLMulti, don't call it tagACLMulti. I am sure this is from copying from threadmgr.c where it is a copy/paste thing from when I started that framework. It has al

Re: [ddraw/tests] Fix a test failure on VMware and VirtualBox on W2K and below

2010-02-15 Thread Paul Vriens
On 02/15/2010 02:18 PM, Henri Verbeet wrote: On 15 February 2010 13:50, Paul Vriens wrote: Hi, Henri agrees that this looks like it's broken on these platforms and thus marked as such. I've used an explicit color value for the broken() statement. Changelog Fix a test failure on VMware and V

Re: [ddraw/tests] Fix a test failure on VMware and VirtualBox on W2K and below

2010-02-15 Thread Henri Verbeet
On 15 February 2010 13:50, Paul Vriens wrote: > Hi, > > Henri agrees that this looks like it's broken on these platforms and thus > marked as such. I've used an explicit color value for the broken() > statement. > > Changelog >  Fix a test failure on VMware and VirtualBox on W2K and below > The br

Re: [jscript]add korean translation

2010-02-15 Thread Paul Vriens
On 02/15/2010 01:20 AM, Hwang YunSong(황윤성) wrote: > --- a/dlls/jscript/Makefile.in2010-02-12 10:23:39.603312863 +0900 > +++ b/dlls/jscript/Makefile.in2010-02-10 09:58:16.684464491 +0900 > @@ -13,6 +13,7 @@ > jscript_Nl.rc \ > jscript_Pt.rc \ > jscript_Ru.rc \ > +jscri

Re: Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?

2010-02-15 Thread Roderick Colenbrander
On Mon, Feb 15, 2010 at 2:13 AM, Dan Kegel wrote: > On Sun, Feb 14, 2010 at 4:46 PM, Ben Klein wrote: >> On 15 February 2010 11:13, Dan Kegel wrote: >>> I recall that Paul Hampson did a first cut at using XI2, >>> linked to from the bottom of http://wiki.winehq.org/DInput, >>> and http://wiki.wi

Re: [PATCH 4/5] ddraw: Add depth clamp tests.

2010-02-15 Thread Henri Verbeet
Paul Vriens wrote: > On 01/26/2010 06:31 PM, Henri Verbeet wrote: >> +color = getPixelColor(device, 150, 150); >> +todo_wine ok(color_match(color, 0x00ff, 1), "color >> 0x%08x.\n", color); > > Hi Henri, > > This particular test fails on some VMware and VirtualBox boxes. We've > been t

Re: Intercepting GDI calls

2010-02-15 Thread Ove Kaaven
James McKenzie skrev: > I'll agree that this is duplication of the existing X11 code, but the > effect is more pleasant to the eye and leads to less user confusion, not > to speak of a less expensive solution (I have yet to find a 'free' X11 > client that is worth anything on Windows.) You mean X