Re: Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)

2010-02-12 Thread James Mckenzie
Ilya Basin wrote at Feb 12, 2010 4:39 AM about Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend) > >Thanks for review. Not sending to wine-patches this time. New patch is >in the bottom. What's better, to attach a generated patch or to use it >as a messa

Re: wined3d: Add surface conversion function from WINED3DFMT_YUY2 to WINED3DFMT_B8G8R8X8_UNORM (try 2)

2010-02-12 Thread Stefan Dösinger
> +dst_line[x] = 0xff00 > +| cliptobyte((c2 + r2) >> 8) << 16/* red */ > +| cliptobyte((c2 + g2) >> 8) << 8 /* green */ > +| cliptobyte((c2 + b2) >> 8); /* blue */ I'm not sure if 0xff is the correct value for the X

Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)

2010-02-12 Thread Ilya Basin
Thanks for review. Not sending to wine-patches this time. New patch is in the bottom. What's better, to attach a generated patch or to use it as a message body? PV> On 02/11/2010 03:37 PM, Ilya Basin wrote: >> Hi! This should expose this bug: >> http://bugs.winehq.org/show_bug.cgi?id=19385 ( the '

Re: Student Interested in Contributing to Wine

2010-02-12 Thread Juan Lang
Hi Michael, On Fri, Feb 12, 2010 at 1:54 AM, Michael Griepentrog wrote: > I'm primarily interested in improving the Wine experience on OS X. I read > pages from http://wiki.winehq.org/MacOSX, but I'm not sure how much of that > reflects the current direction of Wine development on Mac. What are

Re: New Spanish translations [1/4]: dlls/hhctrl.ocx

2010-02-12 Thread Alexandre Julliard
Paul Vriens writes: > Just saw that your original patches where created from the > top-level. I guess it's due to the patchwatcher site disliking non Git > patches? Yes, the filtering script has some issues with non-git patches that only create new files. I put in some fixes, but using git patch

Re: New Spanish translations [1/4]: dlls/hhctrl.ocx

2010-02-12 Thread Paul Vriens
On 02/12/2010 04:41 PM, Paul Vriens wrote: On 02/11/2010 02:36 PM, José Manuel Ferrer Ortiz wrote: As requested, I'll resend these patches, splitting them one message per module. This way it looks a lot more professional :D I've also fixed a few things that were wrong or could be better: - Swit

Re: New Spanish translations [1/4]: dlls/hhctrl.ocx

2010-02-12 Thread Paul Vriens
On 02/11/2010 02:36 PM, José Manuel Ferrer Ortiz wrote: As requested, I'll resend these patches, splitting them one message per module. This way it looks a lot more professional :D I've also fixed a few things that were wrong or could be better: - Switched to UTF-8 encoding, and added the requir

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries

2010-02-12 Thread Alexandre Julliard
James Mckenzie writes: > Alexandre: > > libhal does not work on Macs and I don't think it works on Sparc based > equipment. How would this work for MacOSX/Solaris? Obviously, using whatever is the equivalent on those platforms, same way we do for disk devices. -- Alexandre Julliard julli...@w

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries

2010-02-12 Thread James Mckenzie
Alexandre Julliard wrote at Feb 12, 2010 5:00 AM (Arizona Time Zone) about Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries > >A C Hurst writes: > >> Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its >> duplicates. >> This patch sent some time back (over a year) was ig

Re: rpcrt4: Add tests for multi-dimensional conformant arrays.

2010-02-12 Thread Huw Davies
On Fri, Feb 12, 2010 at 11:27:38AM +, Huw Davies wrote: > On Fri, Feb 12, 2010 at 11:53:30AM +0100, Paul Vriens wrote: > > On 02/11/2010 05:18 PM, Huw Davies wrote: > >> +ptr = NdrSimpleStructMarshall(&StubMsg, (unsigned char *)&memsrc, > >> +&fmtstr_complex_array[32] ); > > > > Hi Huw, > >

AppDB: add graphic card info field?

2010-02-12 Thread burp
Hi, currently the AppDB test results include (besides the obvious wine related fields) only the distribution as distinguishing attribute for a test(er). Now, my view point is the game(r) perspective. Maybe that's far too narrow, but still... Many times I looked at test results and wished to

Re: [msi/tests] Fix a test failure on Win9x/WinMe

2010-02-12 Thread Paul Vriens
On 02/12/2010 01:28 PM, Hans Leidekker wrote: On Friday 12 February 2010 12:15:48 Paul Vriens wrote: Changelog Fix a test failure on Win9x/WinMe Can you find the string "msi test font" anywhere in the registry after running that test? -Hans Wait, this is probably because you used W-f

Re: [msi/tests] Fix a test failure on Win9x/WinMe

2010-02-12 Thread Hans Leidekker
On Friday 12 February 2010 12:15:48 Paul Vriens wrote: > Changelog >Fix a test failure on Win9x/WinMe Can you find the string "msi test font" anywhere in the registry after running that test? -Hans

Re: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)

2010-02-12 Thread Paul Vriens
On 02/12/2010 12:39 PM, Ilya Basin wrote: Thanks for review. Not sending to wine-patches this time. New patch is in the bottom. What's better, to attach a generated patch or to use it as a message body? Depends on your mail client I guess. I usually attach but there are others who inline. P

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries

2010-02-12 Thread Alexandre Julliard
A C Hurst writes: > Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its > duplicates. > This patch sent some time back (over a year) was ignored/lost in noise. > Could someone review please? It has already been explained that this belongs in mountmgr, and should be based on t

Re: rpcrt4: Add tests for multi-dimensional conformant arrays.

2010-02-12 Thread Huw Davies
On Fri, Feb 12, 2010 at 11:53:30AM +0100, Paul Vriens wrote: > On 02/11/2010 05:18 PM, Huw Davies wrote: >> +ptr = NdrSimpleStructMarshall(&StubMsg, (unsigned char *)&memsrc, >> +&fmtstr_complex_array[32] ); > > Hi Huw, > > This particular test crashes on Win9x, WinMe and NT4. > > They all show

Re: rpcrt4: Add tests for multi-dimensional conformant arrays.

2010-02-12 Thread Paul Vriens
On 02/11/2010 05:18 PM, Huw Davies wrote: +ptr = NdrSimpleStructMarshall(&StubMsg, (unsigned char *)&memsrc, +&fmtstr_complex_array[32] ); Hi Huw, This particular test crashes on Win9x, WinMe and NT4. They all show: ndr_marshall.c:1973: Test failed: length 96 just before the crash so ma

Re: cmd: Add test for %~dp0 expansion (bug 21382)

2010-02-12 Thread Alexandre Julliard
Dan Kegel writes: > --- /dev/null > +++ b/programs/cmd/tests/test_dp0.cmd > @@ -0,0 +1,10 @@ > +...@echo off > +echo Begin test for bug 21382 > +rem On old wine, ~dp0 was always current directory rather than "directory > containing batch file" > +echo %~dp0 > +mkdir dummydir > +cd dummydir > +ec

Student Interested in Contributing to Wine

2010-02-12 Thread Michael Griepentrog
Hi, I'm interested in contributing to Wine, and I'm posting here for guidance on how to get started. I'll start off with a bit about myself: I'm currently a senior majoring in Computer Science at the University of Wisconsin - Madison and will be graduating in May. Most of my upper-level coursew

Re: Intercepting GDI calls

2010-02-12 Thread Roderick Colenbrander
On Fri, Feb 12, 2010 at 8:01 AM, Charles Davis wrote: > Jui-Hao Chiang wrote: >> Hi, all: >> >> I am currently starting a project which tries to run a window >> application on one (source) machine, and display on another >> (destination) machine. Of course, the VNC or X11 forwarding technique >> c

Re: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)

2010-02-12 Thread Paul Vriens
On 02/11/2010 03:37 PM, Ilya Basin wrote: Hi! This should expose this bug: http://bugs.winehq.org/show_bug.cgi?id=19385 ( the 'wine start' launcher does not open MS Office documents that have spaces in their path ). Although the title is misleading, many other tickets are marked as duplicates of