Re: [PATCH 4/5] d3drm: Add some tests

2010-02-02 Thread Paul Vriens
On 02/03/2010 08:50 AM, Christian Costa wrote: While you are at it. This patch introduces a test failure on NT4: http://test.winehq.org/data/tests/d3drm:d3drm.html Could you have a look? Just submitted patches should help with this problem. Thanks for looking into this. Isn't it strange th

Re: [PATCH 4/5] d3drm: Add some tests

2010-02-02 Thread Christian Costa
Paul Vriens a écrit : On 02/01/2010 10:10 PM, Christian Costa wrote: Paul Vriens a écrit : On 02/01/2010 08:56 AM, Stefan Dösinger wrote: On Monday 01 February 2010 08:18:42 Christian Costa wrote: +void Test(void) +{ ... Test(); I think the function name Test() won't be too helpful once mo

Re: [1/2] msxml3/doc: Implement IXMLDOMDocument::get_url() with some tests

2010-02-02 Thread Nikolay Sivov
Please disregard this and next [2/2] patches. I'll try another way.

Re: [1/2] msxml3/doc: Implement IXMLDOMDocument::get_url() with some tests

2010-02-02 Thread Nikolay Sivov
On 2/3/2010 02:58, Jacek Caban wrote: Hi Nikolay, On 2/2/10 11:23 PM, Nikolay Sivov wrote: Implement IXMLDOMDocument::get_url() with some tests You probably should use GetDisplayName result of moniker used to load the document to obtain its URL. I'll try with it, thanks. Thanks, Jacek

Re: libpng dependency issue

2010-02-02 Thread Vincent Povirk
We use png_set_gray_1_2_4_to_8 to expand grayscale PNG's to an RGB format. It'd be nice to have libpng do this (if there's a non-deprecated way to do it), but it's a trivial operation that we could do without if necessary.

Re: [1/2] msxml3/doc: Implement IXMLDOMDocument::get_url() with some tests

2010-02-02 Thread Jacek Caban
Hi Nikolay, On 2/2/10 11:23 PM, Nikolay Sivov wrote: Implement IXMLDOMDocument::get_url() with some tests You probably should use GetDisplayName result of moniker used to load the document to obtain its URL. Thanks, Jacek

re: msi: copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl

2010-02-02 Thread Dan Kegel
> makes an installer run farther Please, when posting patches like that, mention *which* installer, unless you have some good reason to keep it private. Thanks!

Re: Several msxmlX modules

2010-02-02 Thread Alexandre Julliard
Nikolay Sivov writes: > I don't, you're right =). So you mean just add empty msxml4, register > it as windows does and forward object > creation to functional module? Pretty much, yes. -- Alexandre Julliard julli...@winehq.org

Re: libpng dependency issue

2010-02-02 Thread Roderick Colenbrander
On Tue, Feb 2, 2010 at 8:46 PM, Luca Bennati wrote: > First: should i open a bug for this? > The problem is from the new libpng 1.4.0: this evening i just updated this > lib, and now i get compile error in dlls/windowscodecs/pngformat.c > I'm still investigating the issue to find a solution, but t

Re: Several msxmlX modules

2010-02-02 Thread Nikolay Sivov
On 2/3/2010 01:26, Alexandre Julliard wrote: Nikolay Sivov writes: No need to care of differences between version for a start, will be ideally not to check for version at all. And yes, winexml should be superset of course. You don't want a winexml if it can be helped at all. Non-sta

Re: Several msxmlX modules

2010-02-02 Thread Alexandre Julliard
Nikolay Sivov writes: > No need to care of differences between version for a start, will be > ideally not to check for version at all. > And yes, winexml should be superset of course. You don't want a winexml if it can be helped at all. Non-standard dlls should be avoided. Just implement one of

libpng dependency issue

2010-02-02 Thread Luca Bennati
First: should i open a bug for this? The problem is from the new libpng 1.4.0: this evening i just updated this lib, and now i get compile error in dlls/windowscodecs/pngformat.c I'm still investigating the issue to find a solution, but the change that introduced this is clear, directly from their

Re: ws2_32: Fix parameter validation order in getpeername.

2010-02-02 Thread Andrew Nguyen
On Tue, Feb 2, 2010 at 4:58 AM, Alexandre Julliard wrote: > Andrew Nguyen writes: > >> Invalid pointers appear to be handled by getpeername in all versions >> of Windows, so adding an exception handler seems to be justified. > > It's only justified if there is a real app that passes a bad pointer

Re: [PATCH] userenv: Implement DestroyEnvironmentBlock().

2010-02-02 Thread Lei Zhang
On Mon, Feb 1, 2010 at 11:05 PM, Maarten Lankhorst wrote: > Hi Lei, > > 2010/2/2 Lei Zhang : >> Hi, >> >> Over the weekend, someone wrote a Chromium base unit test that calls >> DestroyEnvironmentBlock(). So I guess it's time to implement it. The >> modified Wine test case passed on my WinXP machi

Re: Several msxmlX modules

2010-02-02 Thread Nikolay Sivov
On 2/2/2010 20:28, Reece Dunn wrote: On 2 February 2010 16:19, Nikolay Sivov wrote: Hi. Wine currently has only one module for MSXML parser - msxml3. Since the third one v4 and v6 are already out. There is also an msxml 5. This is only available via Office 2003/2007, and is installe

Re: Several msxmlX modules

2010-02-02 Thread Reece Dunn
On 2 February 2010 16:19, Nikolay Sivov wrote: > Hi. > > Wine currently has only one module for MSXML parser - msxml3. Since the > third one v4 and v6 are already out. There is also an msxml 5. This is only available via Office 2003/2007, and is installed by that. See http://support.microsoft.com

Re: [1/3] gdiplus: Implement GdipSetImageAttributesGamma.

2010-02-02 Thread Vincent Povirk
On Tue, Feb 2, 2010 at 2:14 AM, Paul Vriens wrote: > On 01/31/2010 02:03 AM, Vincent Povirk wrote: >> >> +    stat = GdipBitmapGetPixel(bitmap2, 0, 0,&color); >> +    expect(Ok, stat); >> +    todo_wine expect(0xff20, color); > > Hi Vincent, > > This one introduces a test failure on what appea

Several msxmlX modules

2010-02-02 Thread Nikolay Sivov
Hi. Wine currently has only one module for MSXML parser - msxml3. Since the third one v4 and v6 are already out. Judging from file size I don't think native modules reuse some code between them, instead it looks like a completely independent builds. What Wine's policy should be about that? Is

Re: [PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter

2010-02-02 Thread Paul Chitescu
On Tuesday 02 February 2010 03:30:20 pm Nikolay Sivov wrote: > On 2/2/2010 16:21, Paul Chitescu wrote: > > Changelog: > > qedit: Mostly stubbed out implementation of SampleGrabber filter > > > > Until the last patch component is applied most application will crash as they > > rarely check for

Re: [PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter

2010-02-02 Thread Nikolay Sivov
On 2/2/2010 16:21, Paul Chitescu wrote: Changelog: qedit: Mostly stubbed out implementation of SampleGrabber filter Until the last patch component is applied most application will crash as they rarely check for errors. +if (IsEqualIID(riid,&IID_IUnknown) || +IsEqualIID

user32: A window is after a call to SetParent invisible when hwnd and newParent is equal (bug 21497)

2010-02-02 Thread Bernhard Übelacker
(Resent, my first mail has not appeared on the list?) Hello, in SetParent the window (hwnd) get hidden by ShowWindow( hwnd, SW_HIDE ), then a call to wineserver is done and then the window is made visible again. If this call to wineserver fails the window stays invisible. This patch at least avo

Re: ws2_32: Fix parameter validation order in getpeername.

2010-02-02 Thread Alexandre Julliard
Andrew Nguyen writes: > Invalid pointers appear to be handled by getpeername in all versions > of Windows, so adding an exception handler seems to be justified. It's only justified if there is a real app that passes a bad pointer that is not the result of some other Wine bug. Please provide more

Qemu using the appdb code for their OS support list.

2010-02-02 Thread Paul Vriens
Hi, Just saw this: http://www.claunia.com/qemu/ -- Cheers, Paul.

Re: [PATCH 4/5] d3drm: Add some tests

2010-02-02 Thread Paul Vriens
On 02/01/2010 10:10 PM, Christian Costa wrote: Paul Vriens a écrit : On 02/01/2010 08:56 AM, Stefan Dösinger wrote: On Monday 01 February 2010 08:18:42 Christian Costa wrote: +void Test(void) +{ ... Test(); I think the function name Test() won't be too helpful once more tests are added. You

Re: [1/3] gdiplus: Implement GdipSetImageAttributesGamma.

2010-02-02 Thread Paul Vriens
On 01/31/2010 02:03 AM, Vincent Povirk wrote: +stat = GdipBitmapGetPixel(bitmap2, 0, 0,&color); +expect(Ok, stat); +todo_wine expect(0xff20, color); Hi Vincent, This one introduces a test failure on what appears to be mostly VMware boxes. Not all VMware boxes show this failure