Re: [PATCH] userenv: Implement DestroyEnvironmentBlock().

2010-02-01 Thread Maarten Lankhorst
Hi Lei, 2010/2/2 Lei Zhang : > Hi, > > Over the weekend, someone wrote a Chromium base unit test that calls > DestroyEnvironmentBlock(). So I guess it's time to implement it. The > modified Wine test case passed on my WinXP machine. Are you sure that DestroyEnvironmentBlock needs that null pointer

MS installer frustration: "compressed file wasn't extracted"

2010-02-01 Thread Dan Kegel
Now that plain old Visual C++ 2005 installs pretty well, I've been trying to get Visual C++ 2005 sp1 and Visual C++ 2008 to install. The latter requires .net 3.5. And all of them appear to be blocked by "err:msi:ACTION_InstallFiles compressed file wasn't extracted", http://bugs.winehq.org/show_bug

New winetricks 20100201: new verbs d3dx10, directx-beta, ddr=, mspaint, multisampling=, rtlm=, sound=disabled, usp10, vc2005hotfix, vc2005load/vc2005save,

2010-02-01 Thread Dan Kegel
Oh, my, we've been busy. Lots and lots of improvements. Runs better on Windows, too. Cygwin is kinda broken with current wine, so we've rewound back to an old version, but you have to copy and paste a URL from winetricks' output into the mirror selector to use it. Sigh. Online as always at ht

Re: [PATCH 4/5] d3drm: Add some tests

2010-02-01 Thread Christian Costa
Paul Vriens a écrit : On 02/01/2010 08:56 AM, Stefan Dösinger wrote: On Monday 01 February 2010 08:18:42 Christian Costa wrote: +void Test(void) +{ ... Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call

Re: [PATCH 4/5] d3drm: Add some tests

2010-02-01 Thread Christian Costa
Stefan Dösinger a écrit : On Monday 01 February 2010 08:18:42 Christian Costa wrote: +void Test(void) +{ ... Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call it from another .c file. Yeap

Re: msi: Fix crash with access to component

2010-02-01 Thread James Hawkins
2010/1/30 André Hentschel : > Hans Leidekker schrieb: >> On Saturday 30 January 2010 12:55:21 André Hentschel wrote: >> >>> --- >>>  dlls/msi/files.c |    2 ++ >>>  1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/dlls/msi/files.c b/dlls/msi/files.c >>> index 7e74dca..afeb451 1

Re: msi: Don't fail if the service to start is already running.

2010-02-01 Thread Hans Leidekker
On Monday 01 February 2010 16:39:38 Paul Vriens wrote: > 'TermService' is not available on my NT and W2K boxes, so using > 'Spooler' would give us greater coverage. > > Do you agree with the attached? Sure, go ahead. -Hans

Re: msi: Don't fail if the service to start is already running.

2010-02-01 Thread Paul Vriens
On 02/01/2010 04:39 PM, Paul Vriens wrote: On 02/01/2010 04:31 PM, Hans Leidekker wrote: On Monday 01 February 2010 16:20:56 Paul Vriens wrote: On 02/01/2010 09:55 AM, Hans Leidekker wrote: + + scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); + ok(scm != NULL, "Failed to open the SC Ma

Re: msi: Don't fail if the service to start is already running.

2010-02-01 Thread Paul Vriens
On 02/01/2010 04:31 PM, Hans Leidekker wrote: On Monday 01 February 2010 16:20:56 Paul Vriens wrote: On 02/01/2010 09:55 AM, Hans Leidekker wrote: + +scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); +ok(scm != NULL, "Failed to open the SC Manager\n"); + +service = OpenServic

Re: msi: Don't fail if the service to start is already running.

2010-02-01 Thread Hans Leidekker
On Monday 01 February 2010 16:20:56 Paul Vriens wrote: > On 02/01/2010 09:55 AM, Hans Leidekker wrote: > > + > > +scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > > +ok(scm != NULL, "Failed to open the SC Manager\n"); > > + > > +service = OpenService(scm, "TermService", SC_MAN

Re: msi: Don't fail if the service to start is already running.

2010-02-01 Thread Paul Vriens
On 02/01/2010 09:55 AM, Hans Leidekker wrote: + +scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); +ok(scm != NULL, "Failed to open the SC Manager\n"); + +service = OpenService(scm, "TermService", SC_MANAGER_ALL_ACCESS); +ok(service != NULL, "Failed to open TermService\n");

Re: [2/5] WineD3D: Implement dynamic buffers with GL_ARB_map_buffer_range

2010-02-01 Thread Henri Verbeet
On 1 February 2010 13:19, Stefan Dösinger wrote: > On Monday 01 February 2010 11:27:48 Henri Verbeet wrote: >> On 30 January 2010 12:37, Stefan Dösinger wrote: >> > +            const struct wined3d_gl_info *gl_info = >> > &device->adapter->gl_info; >> >> I think you should retrieve gl_info from

Re: oleaut32: rewrite RollUdate to be easier to change and to support more conversions

2010-02-01 Thread Alexandre Julliard
André Hentschel writes: > Old version of that function only used if-statements which is not the best > solution for a math problem. It doesn't work here: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so vartest.c && touch vartest.ok vartest.c:1759: Test fa

Re: includes: Add amaudio.h

2010-02-01 Thread Henri Verbeet
On 31 January 2010 20:34, Maarten Lankhorst wrote: > +    STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID riid, void** ppvObject) Looking at some other headers this seems a common thing to do, but is there really a reason to use STDMETHOD_(HRESULT,QueryInterface) over just STDMETHOD(QueryInterface

Re: dwmapi: add a stub for DwmDefWindowProc

2010-02-01 Thread Reece Dunn
On 1 February 2010 11:11, Nikolay Sivov wrote: > On 2/1/2010 07:35, Austin English wrote: >> >> See http://bugs.winehq.org/show_bug.cgi?id=20443 >> >>   +    FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); > > Also don't forget to correct format here. Austin fixed that in the updated version as

Re: dwmapi: add a stub for DwmDefWindowProc

2010-02-01 Thread Nikolay Sivov
On 2/1/2010 07:35, Austin English wrote: See http://bugs.winehq.org/show_bug.cgi?id=20443 +FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); Also don't forget to correct format here.

Re: wined3d: Add newer ATI/AMD cards vendor recognition

2010-02-01 Thread Stefan Dösinger
Am 01.02.2010 um 11:35 schrieb Henri Verbeet: > On 31 January 2010 14:59, Luca Bennati wrote: >> As seen in bug #21515, newer ATI cards used with radeon open driver return a >> GL_VENDOR string not present in wined3d_guess_vendor(). >> This oneliner merely adds that so that the function return V

Re: d3dx9: Implement point filtering of ARGB surface data in D3DXLoadSurfaceFromMemory

2010-02-01 Thread Henri Verbeet
On 31 January 2010 13:00, Tony Wasserka wrote: > - the other filters basically do the same, but the end effect looks > nice, so we can fallback to point filtering for linear, triangle and box > filters for now. > - apparently, D3DERR_INVALIDCALL gets returned if the specified > destination rect ex

Re: wined3d: Add newer ATI/AMD cards vendor recognition

2010-02-01 Thread Henri Verbeet
On 31 January 2010 14:59, Luca Bennati wrote: > As seen in bug #21515, newer ATI cards used with radeon open driver return a > GL_VENDOR string not present in wined3d_guess_vendor(). > This oneliner merely adds that so that the function return VENDOR_MESA > instead of VENDOR_WINE that could make a

Re: [2/5] WineD3D: Implement dynamic buffers with GL_ARB_map_buffer_range

2010-02-01 Thread Henri Verbeet
On 30 January 2010 12:37, Stefan Dösinger wrote: > +const struct wined3d_gl_info *gl_info = > &device->adapter->gl_info; I think you should retrieve gl_info from the context where possible.

Re: [3/5] d3d9: Test buffer lock flags (try 2)

2010-02-01 Thread Henri Verbeet
On 30 January 2010 12:38, Stefan Dösinger wrote: > +static HMODULE d3d9_handle = 0; That's still redundant. Note that the variable doesn't have to be static in the first place though, you can just pass it to init_d3d9().

Re: [1/5] WineD3D: Add GL_ARB_map_buffer_range

2010-02-01 Thread Henri Verbeet
On 30 January 2010 12:35, Stefan Dösinger wrote: > +/* GL_ARB_map_buffer_range */ > +#ifndef GL_ARB_map_buffer_range > +#define GL_ARB_map_buffer_range > +typedef GLvoid *(WINE_GLAPI *PGLFNMAPBUFFERRANGE)(GLenum target, GLintptr > offset, GLsizeiptr length, GLbitfield access); > +typedef void (WI

Re: dwmapi: add a stub for DwmDefWindowProc

2010-02-01 Thread Austin English
On Mon, Feb 1, 2010 at 4:10 AM, Reece Dunn wrote: > On 1 February 2010 04:35, Austin English wrote: > > + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam, > LPARAM lParam, LRESULT *plResult) > > Minor nitpick here -- there is a space before the BOOL return type. Fixed. > +{ > +

Re: wined3d: Add newer ATI/AMD cards vendor recognition

2010-02-01 Thread Stefan Dösinger
Am 31.01.2010 um 14:59 schrieb Luca Bennati: > As seen in bug #21515, newer ATI cards used with radeon open driver return a > GL_VENDOR string not present in wined3d_guess_vendor(). > This oneliner merely adds that so that the function return VENDOR_MESA > instead of VENDOR_WINE that could make

Re: dwmapi: add a stub for DwmDefWindowProc

2010-02-01 Thread Reece Dunn
On 1 February 2010 04:35, Austin English wrote: + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, LRESULT *plResult) Minor nitpick here -- there is a space before the BOOL return type. +{ +FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); + +return E_NOTI

Re: [PATCH 4/5] d3drm: Add some tests

2010-02-01 Thread Paul Vriens
On 02/01/2010 08:56 AM, Stefan Dösinger wrote: On Monday 01 February 2010 08:18:42 Christian Costa wrote: +void Test(void) +{ ... Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call it from another .c file

Re: [PATCH 4/5] d3drm: Add some tests

2010-02-01 Thread Stefan Dösinger
On Monday 01 February 2010 08:18:42 Christian Costa wrote: > +void Test(void) > +{ > ... > Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call it from another .c file.