Student Interested in Google Summer of Code 2010

2010-01-26 Thread Arjun Comar
Hey all, I'm new here and interested in the Wine project for GSoC this year and figured I'd start by introducing myself and hopefully getting to know who's who on this list. I'm a Sophomore CS major at Rose-Hulman Institute of Technology, a science and engineering school in Indiana. I've been writi

Loader, mapping and sharing issues with main exe

2010-01-26 Thread Jason Edmeades
Hello, I've been debugging a problem with an application which checks itself for consistency before it runs. It does this extremely simply and fails in a trivial way under wine, but for the life of me I do not know how to fix it, and I would appreciate any thoughts - its not everyday I delve into

Re: WINEDLLPATH and /usr/lib/wine

2010-01-26 Thread Hin-Tak Leung
--- On Tue, 26/1/10, Alexandre Julliard wrote: > Michael Ost > writes: > > > I agree. And that's what your patch does, right? Would > you like to > > submit it to the wine-patches list? I think the case > for it is strong, > > especially since (1) you found that it fixes a > behavior change in

Re: WINEDLLPATH and /usr/lib/wine

2010-01-26 Thread Hin-Tak Leung
--- On Tue, 26/1/10, Ben Klein wrote: > For DLLs at least, you should be able to rename the .dll.so > to a .dll > and stick it in the application's directory. I don't recall > the last > time I tried this, but it certainly worked (I was using a > hacked > ddraw.dll.so to get Diablo and Worms Arma

Re: [PATCH 2/5] d3d9: Add depth clamp tests.

2010-01-26 Thread Stefan Dösinger
Am 26.01.2010 um 19:23 schrieb Henri Verbeet: > On 26 January 2010 18:56, Stefan Dösinger wrote: >> It would be interesting to see how D3DCMP_GREATER behaves with clipping off. >> Does the clamping occur before the depth test, or after the test but before >> writing the values into the depth b

Re: [PATCH 2/5] d3d9: Add depth clamp tests.

2010-01-26 Thread Henri Verbeet
On 26 January 2010 18:56, Stefan Dösinger wrote: > It would be interesting to see how D3DCMP_GREATER behaves with clipping off. > Does the clamping occur before the depth test, or after the test but before > writing the values into the depth buffer. (ie, is 3.0 > 1.0 or is 3.0 == 1.0) > It's not

Re: WINEDLLPATH and /usr/lib/wine

2010-01-26 Thread Alexandre Julliard
Michael Ost writes: > I agree. And that's what your patch does, right? Would you like to > submit it to the wine-patches list? I think the case for it is strong, > especially since (1) you found that it fixes a behavior change in > WINEDLLPATH from November 2006 --- arguably a regression; and (2)

Re: [PATCH 2/5] d3d9: Add depth clamp tests.

2010-01-26 Thread Stefan Dösinger
Am 26.01.2010 um 18:31 schrieb Henri Verbeet: > +/* This test tests depth clamping / clipping behaviour: > + * - When D3DRS_CLIPPING is disabled depth values are *clamped* to the > + * minimum/maximum z value.+hr = > IDirect3DDevice9_SetRenderState(device, D3DRS_ZFUNC, D3DCMP_LESSEQUAL);

Re: WINEDLLPATH and /usr/lib/wine

2010-01-26 Thread Michael Ost
Hin-Tak Leung wrote: --- On Mon, 25/1/10, Michael Ost wrote: Alexandre Julliard wrote: Not necessarily, the behavior could probably be tweaked, feel free to suggest changes. You can't require users to set WINEDLLPATH for normal usage though, including running from the build tree or fro

Re: WINEDLLPATH and /usr/lib/wine

2010-01-26 Thread Ben Klein
2010/1/26 Hin-Tak Leung : > --- On Mon, 25/1/10, Michael Ost wrote: > >> Alexandre Julliard wrote: > >> > Not necessarily, the behavior could probably be >> tweaked, feel free to >> > suggest changes. You can't require users to set >> WINEDLLPATH for normal >> > usage though, including running fro

Re: [2/5] WineD3D: Add an internal event query finish function

2010-01-26 Thread Henri Verbeet
On 26 January 2010 13:42, Stefan Dösinger wrote: > If I let the buffer code create a wined3d_event_query then I'll have to > create internal functions like this for _Issue and _GetData as well, and the > real IWineD3DEventQueryImpl_Issue and IWineD3DEventQueryImpl_GetData would > just be simple

Re: [2/5] WineD3D: Add an internal event query finish function

2010-01-26 Thread Stefan Dösinger
Am 26.01.2010 um 12:44 schrieb Henri Verbeet: > On 26 January 2010 11:51, Stefan Dösinger wrote: >> +HRESULT wined3d_event_query_finish(IWineD3DQuery* iface) { > Please don't create function prototypes (or other code) by copy/paste. > Also, why does this take a IWineD3DQuery pointer in the first

Re: [2/5] WineD3D: Add an internal event query finish function

2010-01-26 Thread Henri Verbeet
On 26 January 2010 11:51, Stefan Dösinger wrote: > +HRESULT wined3d_event_query_finish(IWineD3DQuery* iface) { Please don't create function prototypes (or other code) by copy/paste. Also, why does this take a IWineD3DQuery pointer in the first place? You only really access wined3d_event_query fiel

Re: Wine coding style

2010-01-26 Thread Alexandre Julliard
Uwe Bonnes writes: > Hello, > > are there any examples for Editor settings (e.g. emacs c-mode) resulting in > acceptable indentation? I'm using the "stroustrup" style in Emacs. Also make sure to set indent-tabs-mode to nil. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] [Include]: push/pop pack fixes on 64 bit platforms

2010-01-26 Thread Alexandre Julliard
Eric Pouech writes: > (try #2) > > A+ > --- > > include/commctrl.h | 16 > include/fci.h |4 > include/fdi.h |8 > include/mmsystem.h |4 > include/richedit.h |4 > include/shlwapi.h |6 +- > include/wingdi.h |6

Re: [kernel32] Add testcase for bug 21292(corrected)

2010-01-26 Thread Paul Vriens
On 01/25/2010 06:30 PM, Uwe Bonnes wrote: This time deleting an eventual created file and with hopefully better indentation Indentation is still not what it's supposed to be. You are not sticking to the surrounding style, but worse your own patch uses different styles as well. -- Cheers, P

Re: WINEDLLPATH and /usr/lib/wine

2010-01-26 Thread Hin-Tak Leung
--- On Mon, 25/1/10, Michael Ost wrote: > Alexandre Julliard wrote: > > Not necessarily, the behavior could probably be > tweaked, feel free to > > suggest changes. You can't require users to set > WINEDLLPATH for normal > > usage though, including running from the build tree or > from a relocat