Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-22 Thread James McKenzie
Lauri Kenttä wrote: > My apologies for bringing up something that is actually none of my > business, but I think you should pay more attention to the way you write > your comments. First, even small positive comments are considered > psychologically very important, but you have given none. Second,

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-22 Thread Lauri Kenttä
> The SetCursorPos() calls hooks on Wine because Wine has big issue - it doesn't filter pointer move messages that were caused by Wine itself. The first patch (http://source.winehq.org/patches/data/57569) tries to address exactly this. I think XWarpCursor is not a problem, as the event comes async

cygwin, perl, wine, rebase, and ReBaseImage()

2010-01-22 Thread Dan Kegel
While building chromium with visual c++ 2005 on wine, step 'webcore_bindings_sources' tries to run WebCore/bindings/scripts/generate-bindings.pl, and sometimes it fails with 13 [main] perl 29 C:\chromium\src\third_party\cygwin\bin\perl.exe: *** fatal error - unable to remap C:\chromium\src\th

Re: GSoC D3DX9 work

2010-01-22 Thread Tony Wasserka
> Hello, > I might be interested as a side project. I've been poking around in the > wine code looking for something interesting for the last few weeks and > this might be it. However I know I wouldn't have much interest in it if > it doesn't actually help me, so I'd like to know a few additional

comctl32 listview notification assert

2010-01-22 Thread Aric Stewart
Hello, I am seeing something in listview.c that really make me feel like there is something really wrong going on. So maybe it is something I am having a lack of understanding in. I have an application that is sending 'A' style notification codes to the listview header. Specifically I am

Re: shell32: Dynamically load an ordinal only export.

2010-01-22 Thread Huw Davies
On Fri, Jan 22, 2010 at 02:51:04PM +0100, Alexandre Julliard wrote: > Huw Davies writes: > > > On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote: > >> Huw Davies writes: > >> > >> > --- > >> > dlls/shell32/tests/shlfileop.c | 18 +- > >> > 1 files changed, 9

Re: shell32: Dynamically load an ordinal only export.

2010-01-22 Thread Alexandre Julliard
Huw Davies writes: > On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote: >> Huw Davies writes: >> >> > --- >> > dlls/shell32/tests/shlfileop.c | 18 +- >> > 1 files changed, 9 insertions(+), 9 deletions(-) >> >> This shouldn't be needed, import by ordinal wor

Re: shell32: Dynamically load an ordinal only export.

2010-01-22 Thread Huw Davies
On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote: > Huw Davies writes: > > > --- > > dlls/shell32/tests/shlfileop.c | 18 +- > > 1 files changed, 9 insertions(+), 9 deletions(-) > > This shouldn't be needed, import by ordinal works just fine. I get a failure

Re: shell32: Dynamically load an ordinal only export.

2010-01-22 Thread Alexandre Julliard
Huw Davies writes: > --- > dlls/shell32/tests/shlfileop.c | 18 +- > 1 files changed, 9 insertions(+), 9 deletions(-) This shouldn't be needed, import by ordinal works just fine. -- Alexandre Julliard julli...@winehq.org

Re: winmm: Add a bunch of new mmio tests which discover some bugs in mmio handling.

2010-01-22 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -45,6 +45,20 @@ static DWORD RIFF_buf[] = > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 > }; > > +#define expect_buf_offset(_hmmio, _off) \ > +do \ > +{ \ > +MMIOINFO _mmio; \ > +LONG _ret; \ > +memset(&_mmio, 0, sizeof(

Re: [PATCH 1/2] ws2_32: use ntstatus in overlapped functions (try 2)

2010-01-22 Thread Alexandre Julliard
Mike Kaplinskiy writes: > Also some style fixes and move case 0 to the top - it's the most likely Nothing says that likely cases have to be at the top, and anyway 0 is probably the least likely of all (and should in fact never happen). -- Alexandre Julliard julli...@winehq.org

Re: "Mockba to Berlin" game - mouse not clicking

2010-01-22 Thread Henri Verbeet
2010/1/22 Pavel Troller : >  But the bug, together with other similar ones, has been closed as fixed in > 1.1.36, while this bug is still here. I cannot test the game with wine-1.1.34, It was closed as fixed because the specific game happened to start working, but the problem of ddraw switching to

Re: "Mockba to Berlin" game - mouse not clicking

2010-01-22 Thread Pavel Troller
> 2010/1/22 Vitaliy Margolen : > > Pavel Troller wrote: > >> BUT: The mouse buttons are DEAD. All I cannot left-click, right-click, > >> mid-click, simply nothing. > > Sounds like a new bug in wined3d. Try older Wine version(s) (wine-1.1.28 > > ish). > > > Yeah, if the game uses ddraw it's probab

Re: "Mockba to Berlin" game - mouse not clicking

2010-01-22 Thread Henri Verbeet
2010/1/22 Vitaliy Margolen : > Pavel Troller wrote: >> BUT: The mouse buttons are DEAD. All I cannot left-click, right-click, >> mid-click, simply nothing. > Sounds like a new bug in wined3d. Try older Wine version(s) (wine-1.1.28 ish). > Yeah, if the game uses ddraw it's probably the same issue a

Re: [2/2] xmllite/reader: Basic input object creation on IXmlReader::SetInput()

2010-01-22 Thread Nikolay Sivov
On 1/22/2010 11:37, Paul Vriens wrote: On 01/21/2010 07:08 PM, Nikolay Sivov wrote: This patch depends on previously sent, forget it properly, sorry. Basic input object creation on IXmlReader::SetInput() Hi Nikolay, This one doesn't apply cleanly on top of: "xmllite/tests: Test query for

Re: [2/2] xmllite/reader: Basic input object creation on IXmlReader::SetInput()

2010-01-22 Thread Paul Vriens
On 01/21/2010 07:08 PM, Nikolay Sivov wrote: This patch depends on previously sent, forget it properly, sorry. Basic input object creation on IXmlReader::SetInput() Hi Nikolay, This one doesn't apply cleanly on top of: "xmllite/tests: Test query for supported interface sequence while crea

Re: [PATCH 4/5] xmllite/tests: Add basic test structure for IXmlReader

2010-01-22 Thread Nikolay Sivov
On 1/22/2010 11:20, Paul Vriens wrote: On 01/21/2010 07:20 PM, Reece Dunn wrote: ?_? Hmmm. According to http://msdn.microsoft.com/en-us/magazine/cc163436.aspx, this should work (but then msdn isn't always right). Do you know what happens if the CoGetMalloc/IMalloc_DidAlloc call is not made?

Re: [PATCH 3/3] jscript: Add error handling to Array.reverse

2010-01-22 Thread Paul Vriens
Hi Piotr, On 01/20/2010 05:23 PM, Piotr Caban wrote: +if(FAILED(hres1)) +return hres1; + hres2 = jsdisp_propget_idx(jsthis, l,&v2, ei, sp); +if(FAILED(hres2)) { +VariantClear(&v1); +return hres2; +} if(hres1 == DISP

Re: [PATCH 4/5] xmllite/tests: Add basic test structure for IXmlReader

2010-01-22 Thread Paul Vriens
On 01/21/2010 07:20 PM, Reece Dunn wrote: ?_? Hmmm. According to http://msdn.microsoft.com/en-us/magazine/cc163436.aspx, this should work (but then msdn isn't always right). Do you know what happens if the CoGetMalloc/IMalloc_DidAlloc call is not made? If I leave this out the test doesn't cr