Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option

2010-01-20 Thread Nikolay Sivov
On 1/20/2010 23:46, Andrew Eikum wrote: --- dlls/wininet/internet.c |6 ++ dlls/wininet/tests/internet.c | 26 ++ 2 files changed, 32 insertions(+), 0 deletions(-) Please mark patches with (tryX) in subject and specify a difference from previous tr

Re: RFC: dwarf merge patch

2010-01-20 Thread Eric Pouech
André Hentschel a écrit : Hi, I made a patch to merge code from ntdll/signal_x86_64.c to dbghelp/dwarf.c The operator DW_OP_deref_size needs to read different sizes of variables from memory into a fixed size variable. Now i am not sure if my solution is the smallest and easiest one, so i would b

RFC: dwarf merge patch

2010-01-20 Thread André Hentschel
Hi, I made a patch to merge code from ntdll/signal_x86_64.c to dbghelp/dwarf.c The operator DW_OP_deref_size needs to read different sizes of variables from memory into a fixed size variable. Now i am not sure if my solution is the smallest and easiest one, so i would be happy for every comment o

Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)

2010-01-20 Thread Paul Vriens
On 01/20/2010 02:39 AM, Peter Dons Tychsen wrote: Hey Paul, Thanks for cleaning up the crashing 9x test-case so fast. Well it still crashes but at least it runs now on Win95. This patch has introduced test failures on NT4 and below (tested locally): http://test.winehq.org/data/tests/user3

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-20 Thread Vitaliy Margolen
Lauri Kenttä wrote: > When the cursor position is clipped with ClipCursor, the cursor should be > confined to that area. This patch fixes cursor position clipping in > X11DRV_ClipCursor, X11DRV_GetCursorPos, X11DRV_SetCursorPos and > X11DRV_send_mouse_input and makes the mouse warp to the new posit

Re: oleaut32: do not crash in logging if string is NULL

2010-01-20 Thread Alexandre Julliard
Aric Stewart writes: > Meaning the place where I am finding this is different bug? > > In deserialize_param in the VT_BSTR case if the byte_length of the > BSTR that we are deserializing is -1 then BSTR_UserUnmarshal places > NULL into *arg. > > I will admit I know very little about this code bu

Re: oleaut32: do not crash in logging if string is NULL

2010-01-20 Thread Aric Stewart
Aric Stewart wrote: Meaning the place where I am finding this is different bug? In deserialize_param in the VT_BSTR case if the byte_length of the BSTR that we are deserializing is -1 then BSTR_UserUnmarshal places NULL into *arg. I will admit I know very little about this code but having i

Re: oleaut32: do not crash in logging if string is NULL

2010-01-20 Thread Aric Stewart
Meaning the place where I am finding this is different bug? In deserialize_param in the VT_BSTR case if the byte_length of the BSTR that we are deserializing is -1 then BSTR_UserUnmarshal places NULL into *arg. I will admit I know very little about this code but having it crash when trying

Re: oleaut32: do not crash in logging if string is NULL

2010-01-20 Thread Alexandre Julliard
Aric Stewart writes: > @@ -68,10 +68,16 @@ typedef struct _marshal_state { > > /* used in the olerelay code to avoid having the L"" stuff added by > debugstr_w */ > static char *relaystr(WCHAR *in) { > -char *tmp = (char *)debugstr_w(in); > -tmp += 2; > -tmp[strlen(tmp)-1] = '\0'

Re: kernel32/tests: do not compare handle with zero directly (Smatch)

2010-01-20 Thread Dan Carpenter
On Tue, Jan 19, 2010 at 03:01:20PM +0300, Dan Carpenter wrote: > On 1/19/10, Dan Carpenter wrote: > > > There is a wine_checker.sh script in smatch_scripts so you can quickly test > > individual files. I just pushed a change to make wine_checker.sh find the > > smatch binary so you may want to p

Re: example code appending files with w32api broken?

2010-01-20 Thread Uwe Bonnes
> "Hin-Tak" == Hin-Tak Leung writes: Hin-Tak> --- On Tue, 19/1/10, Uwe Bonnes Hin-Tak> wrote: >> Register with the winetestbot, upload your test exe and compare the >> test output  Hin-Tak> Thanks for the pointer. I'll bear that in mind. ATM I have a Hin-Tak> patch f

Re: WINEDEBUG=+relay: why unicode arguments printed in form L"\0412\044b" and not L"\x412\x44b"? 044b sure not octal

2010-01-20 Thread Dmitry Timoshkov
Илья Басин wrote: > /// > #include > > int main() > { > MessageBoxExW(NULL, > L"\x412\x44b > \x434\x435\x439\x441\x442\x432\x438\x442\x435\x43b\x44c\x43d\x43e > \x445\x43e\x442\x438\x442\x435 \x443\x434\x430\x43b\x438\x442\x44c > \"\x43f\x440

WINEDEBUG=+relay: why unicode arguments printed in form L"\0412\044b" and not L"\x412\x44b"? 044b sure not octal

2010-01-20 Thread Илья Басин
/// #include int main() { MessageBoxExW(NULL, L"\x412\x44b \x434\x435\x439\x441\x442\x432\x438\x442\x435\x43b\x44c\x43d\x43e \x445\x43e\x442\x438\x442\x435 \x443\x434\x430\x43b\x438\x442\x44c \"\x43f\x440\x438\x43f\x430\x440\x43a\x43e\x432\x430

Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)

2010-01-20 Thread Peter Dons Tychsen
Hey Paul, Thanks for cleaning up the crashing 9x test-case so fast. > This patch has introduced test failures on NT4 and below (tested locally): > > http://test.winehq.org/data/tests/user32:win.html Sorry for that. > The callback is entered several times on NT4 (only once on XP) so it > seems.

Re: [PATCH 4/5] wined3d: Don't use the depth range clipping hack when we have ARB_depth_clamp.

2010-01-20 Thread Chris Robinson
On Tuesday 19 January 2010 11:38:18 pm Stefan Dösinger wrote: > Am 20.01.2010 um 01:08 schrieb Chris Robinson: > > The comment says that it's using MinZ/MaxZ to suppress depth clipping, > > which could otherwise occur with 0..-1. GL_DEPTH_CLAMP needs to be > > enabled if 'untransformed' is false, t

Re: valgrind run called on account of rain

2010-01-20 Thread Ben Klein
2010/1/20 Evil Jay : > Dan Kegel wrote: >> Today's scheduled match between Valgrind and Wine >> was called on account of rain.   The roofers think >> they found where the water was coming in, and >> the rainstorm can't last forever; I'm hoping to >> turn the Valgrind build machine on again later th

Re: [PATCH 4/5] wined3d: Don't use the depth range clipping hack when we have ARB_depth_clamp.

2010-01-20 Thread Henri Verbeet
2010/1/20 Stefan Dösinger : > Feel free to kill it - I can try to get it back in place once I can reproduce > the POP3D behavior in tests, or we just tell people to get a driver with > either ARB_depth_clamp or NV_depth_clamp(read: lobby Mesa to support this > extension) > IIRC at least the Inte