Am 20.01.2010 um 08:45 schrieb Henri Verbeet:
> I'm somewhat tempted to just kill the hack and see what breaks. It
> would have been nice if there were tests for this, of course.
Feel free to kill it - I can try to get it back in place once I can reproduce
the POP3D behavior in tests, or we just
2010/1/20 Stefan Dösinger :
> I am ok with the patch being committed, as in the worst case this is just a
> hack replaced by another hack, and it seems right to me.
>
> That said, I was trying to write some tests about the d3d9 D3DRS_CLIPPING
> behavior, and it seems the near and far clip planes
Am 20.01.2010 um 01:08 schrieb Chris Robinson:
> The comment says that it's using MinZ/MaxZ to suppress depth clipping, which
> could otherwise occur with 0..-1. GL_DEPTH_CLAMP needs to be enabled if
> 'untransformed' is false, to suppress depth clipping as intended.
>
> Since the transformed-v
Am 19.01.2010 um 23:52 schrieb Henri Verbeet:
> -if (!stateblock->device->untransformed)
> +if (!stateblock->device->untransformed && minZ != maxZ)
My tests show that this is not needed, at least in d3d8 and d3d9. My (unsent)
tests show that if you pass MinZ == MaxZ SetViewport ad
Dan Kegel wrote:
> Today's scheduled match between Valgrind and Wine
> was called on account of rain. The roofers think
> they found where the water was coming in, and
> the rainstorm can't last forever; I'm hoping to
> turn the Valgrind build machine on again later this week.
> Once it dries out
2010/1/20 James McKenzie :
> Dan Kegel wrote:
>> Today's scheduled match between Valgrind and Wine
>> was called on account of rain. The roofers think
>> they found where the water was coming in, and
>> the rainstorm can't last forever; I'm hoping to
>> turn the Valgrind build machine on again la
Dan Kegel wrote:
> Today's scheduled match between Valgrind and Wine
> was called on account of rain. The roofers think
> they found where the water was coming in, and
> the rainstorm can't last forever; I'm hoping to
> turn the Valgrind build machine on again later this week.
> Once it dries out
Today's scheduled match between Valgrind and Wine
was called on account of rain. The roofers think
they found where the water was coming in, and
the rainstorm can't last forever; I'm hoping to
turn the Valgrind build machine on again later this week.
Once it dries out :-)
--- On Tue, 19/1/10, Uwe Bonnes
wrote:
> Register with the winetestbot, upload your test exe and
> compare the test
> output
Thanks for the pointer. I'll bear that in mind. ATM I have a patch for one bug
which does not work, possibly because it uncovers another bug in wine - I can
verify th
On Tuesday 19 January 2010 3:37:50 pm Henri Verbeet wrote:
> 2010/1/20 Chris Robinson :
> > I think you need to make sure glEnable(GL_DEPTH_CLAMP) gets called in
> > state_clipping if you're going to bypass the depth range hack with it.
> > Currently it's only called if WINED3DRS_CLIPPING is off.
>
2010/1/20 Chris Robinson :
> I think you need to make sure glEnable(GL_DEPTH_CLAMP) gets called in
> state_clipping if you're going to bypass the depth range hack with it.
> Currently it's only called if WINED3DRS_CLIPPING is off.
>
Possibly, but it's not clear from the description of that hack tha
On Tuesday 19 January 2010 2:52:28 pm Henri Verbeet wrote:
> ARB_depth_clamp should give pretty much the desired behaviour by clamping
> instead of clipping depth values outside the depth range.
I think you need to make sure glEnable(GL_DEPTH_CLAMP) gets called in
state_clipping if you're going t
On 1/19/10 9:26 PM, Nikolay Sivov wrote:
On 1/19/2010 19:36, Jacek Caban wrote:
Hi*Nikolay*,
> If I'm right then only solution is to link to libxml2 statically from
> each module. Is it an acceptable way?
>
> P.S. having a separate copy of libxml2 allows to tweak its namespace
> support (I
> "Hin-Tak" == Hin-Tak Leung writes:
Hin-Tak> I needed a WIN32 API based file-appending solution to fix a bug
Hin-Tak> (http://bugs.winehq.org/show_bug.cgi?id=21394) and using the
Hin-Tak> example code
Hin-Tak> http://msdn.microsoft.com/en-us/library/aa363778%28VS.85%29.aspx
On 1/19/2010 19:36, Jacek Caban wrote:
Hi*Nikolay*,
> If I'm right then only solution is to link to libxml2 statically from
> each module. Is it an acceptable way?
>
> P.S. having a separate copy of libxml2 allows to tweak its namespace
> support (I believe there's some discussions of that
Hi*Nikolay*,
If I'm right then only solution is to link to libxml2 statically from
each module. Is it an acceptable way?
P.S. having a separate copy of libxml2 allows to tweak its namespace
support (I believe there's some discussions of that problem in bugzilla).
I think it would be bet
On 18/01/2010 08:46, Alexandre Julliard wrote:
This seemed to be the easiest and most trivial way to allow
MAPIInitialize to succeed in the tests, which will be added in the
next several patches.
That doesn't seem right. The tests should be able to work without an
extended provider.
Indeed, u
Andrew Eikum writes:
>> This can go with the other internet tests in internet.c, there's no need
>> for a new file.
>>
>
> I can certainly do it this way. My concern is that there are over 100
> options for both Query and Set, and while only 3 are implemented by
> this series, I think the file m
On 01/19/2010 05:34 AM, Alexandre Julliard wrote:
Andrew Eikum writes:
diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in
index ba8f662..66a756f 100644
--- a/dlls/wininet/tests/Makefile.in
+++ b/dlls/wininet/tests/Makefile.in
@@ -10,6 +10,7 @@ CTESTS = \
gener
Mike Kaplinskiy writes:
> @@ -542,6 +542,35 @@ static inline DWORD NtStatusToWSAError( const DWORD
> status )
> return wserr;
> }
>
> +/* most ws2 overlapped functions return an ntstatus-based error code */
> +static inline NTSTATUS WSAErrorToNtStatus( const DWORD error )
> +{
In genera
On 1/19/10, Dan Carpenter wrote:
> There is a wine_checker.sh script in smatch_scripts so you can quickly test
> individual files. I just pushed a change to make wine_checker.sh find the
> smatch binary so you may want to pull the most recent changes.
>
> /path/to/smatch_scripts/wine_checker.sh
Andrew Eikum writes:
> diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in
> index ba8f662..66a756f 100644
> --- a/dlls/wininet/tests/Makefile.in
> +++ b/dlls/wininet/tests/Makefile.in
> @@ -10,6 +10,7 @@ CTESTS = \
> generated.c \
> http.c \
> internet.
Sorry, I'm not on the list.
-ok( file != 0, "CreateFileMapping PAGE_READWRITE error %u\n",
GetLastError() );
+ok( !!file, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError()
);
Smatch sees those as equivelent. (The new version does at least
http://repo.or.cz/w/smatch.git).
23 matches
Mail list logo
