winetestbot changes

2010-01-17 Thread Greg Geldorp
A couple of changes to the test bot: - Maximize number of powered on VMs (Paul Vriens) - Make tag prefix for test.winehq.org submissions configurable (Paul Vriens) - Add support for VMs on multiple hosts, add Windows 95/95B/98/98SE VMs - Make the "File" field on the "Submit job" page accept longer

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name (supercedes first patch)

2010-01-17 Thread Paul Vriens
Hi Uwe, On 01/17/2010 03:56 PM, Uwe Bonnes wrote: +if (hFile != INVALID_HANDLE_VALUE) + { + CloseHandle( hFile ); + DeleteFileA("test/"); + } Indentation is a bit off here (probably because you are mixing tabs and spaces). The rest of your patch also mixes tabs and s

re:CPP Check Runs Clean but found these Style Issues on Latest Git...

2010-01-17 Thread Dan Kegel
You have some false positives, e.g. dlls/gdi32/enhmfdrv/mapping.c 1 The function EMFDRV_ModifyWorldTransform' is never used That function is indeed used in dlls/gdi32/enhmfdrv/init.c; the struct EMFDRV_Funcs is initialized with it. I guess cppcheck doesn't grok function pointers yet? - D

Re: CPP Check Runs Clean but found these Style Issues on Latest Git...

2010-01-17 Thread Nikolay Sivov
On 1/17/2010 21:50, chris ahrendt wrote: Don't know if anyone is interested in this or not but I thought I would send this out to the list. CPPCheck is now running clean on the GIT tree... but its showing some style issues. If they are there for API compatibility let me know and I will ignore t

CPP Check Runs Clean but found these Style Issues on Latest Git...

2010-01-17 Thread chris ahrendt
Don't know if anyone is interested in this or not but I thought I would send this out to the list. CPPCheck is now running clean on the GIT tree... but its showing some style issues. If they are there for API compatibility let me know and I will ignore them from now on. Here they are: File

Re: [PATCH] mmdevapi: Add some basic tests for property store

2010-01-17 Thread Maarten Lankhorst
Hi Paul, Paul Vriens schreef: On 01/17/2010 02:11 PM, Maarten Lankhorst wrote: +static void test_propertystore(IPropertyStore *store) +{ +} Is that one supposed to be empty ? Yeah, I didn't get around to writing decent tests for it yet, it will probably require adding some more headers defi

Re: [PATCH] mmdevapi: Add some basic tests for property store

2010-01-17 Thread Paul Vriens
On 01/17/2010 02:11 PM, Maarten Lankhorst wrote: +static void test_propertystore(IPropertyStore *store) +{ +} Is that one supposed to be empty ? -- Cheers, Paul.

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name

2010-01-17 Thread Paul Vriens
On 01/17/2010 01:27 PM, Uwe Bonnes wrote: CreateFile with an illegal character in the name fail on all systems beside NT4 and wine when ordered to create the file. No test errors on my mchines and the winetestbot (Job 319) If creating the file succeeds you should close the handle and delete th

Re: sti: add launch application registry

2010-01-17 Thread Paul Vriens
On 01/17/2010 10:09 AM, Damjan Jovanovic wrote: +else +skip("No StiCreateInstanceW function\n"); Shouldn't that be a win_skip() ? Why don't you do something like: if (!pStiCreateInstanceW) { win_skip("No StiCreateInstanceW function\n"); return; } That

Re: Winetest: What to do if NT4 behaves other then W2k and up

2010-01-17 Thread Paul Vriens
On 01/17/2010 01:35 AM, Austin English wrote: On Sat, Jan 16, 2010 at 1:06 PM, Uwe Bonnes wrote: Wine Bug 21292 shows a problem with CreateFileA("bla/n", GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL) All winebot systems beside WNT4WSSP6 r

Re: include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OSX (resend) (1/7)

2010-01-17 Thread Alexandre Julliard
Austin English writes: > Subject: [PATCH 1/7] include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent > a conflict on *BSD/OSX Don't do that. Fix the includes order in the files that fail to compile. -- Alexandre Julliard julli...@winehq.org