Re: Code review request, fix for PATH setting bug 21322

2010-01-15 Thread Scott Ritchie
Dan Kegel wrote: I was surprised to find that Wine didn't handle system-wide and user-local PATH together properly. The bug and a proposed fix are at http://bugs.winehq.org/show_bug.cgi?id=21322 Could someone review the patch before I risk sending it to wine-patches? I think it's clean, but my l

Re: include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OS X

2010-01-15 Thread Austin English
On Fri, Jan 15, 2010 at 5:17 PM, Nikolay Sivov wrote: > On 1/16/2010 02:12, Austin English wrote: >> >> See bug 21320. >> > > LIST_FOR_EACH_SAFE is inconsistent after your patch. It probably should, yeah, but that should be a separate patch. I'll resend as a series next week. > Also I think a sh

Usage of libxml2 for several modules

2010-01-15 Thread Nikolay Sivov
I'm thinking about implementing xmllite library - its interface is almost the same as xmlTextReader/Writer from libxml2 so it's potentially a thin wrapper, and it's good. The problem is that libxml2 is not reentrant. This isn't a problem for xmllite itself, cause it's not thread safe too, but:

Re: include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OS X

2010-01-15 Thread Nikolay Sivov
On 1/16/2010 02:12, Austin English wrote: See bug 21320. LIST_FOR_EACH_SAFE is inconsistent after your patch. Also I think a shorter variant something like WLIST_... is preferable, but it's a subject of discussion.

GSoC D3DX9 work

2010-01-15 Thread Tony Wasserka
Hi everyone, I probably should've written this mail a few months earlier, but I had hoped that I'd get some spare time to work on Wine stuff. But to face reality, I'm having A-levels-like graduation (abitur in Germany) in the comming months. I have to prepare a skilled work until the end of january

Re: Legal issues with wine development

2010-01-15 Thread Roderick Colenbrander
Just to provide some reference to another project which had a similar issue. As you likely know Android is based on Linux. Except for the kernel which is obviously GPL, the platform uses as little (L)GPL code as possible. Their libc implementation, Bionic, is based on BSD but they required Linux he

Re: [2/3] user32/tests: Add test for EM_GETIMESTATUS and EM_SETIMESTATUS.

2010-01-15 Thread Paul Vriens
On 01/15/2010 02:22 PM, Kusanagi Kouichi wrote: Signed-off-by: Kusanagi Kouichi --- dlls/user32/tests/Makefile.in |2 +- dlls/user32/tests/edit.c | 59 + 2 files changed, 60 insertions(+), 1 deletions(-) Hi Kusanagi, These tests fail on V

Re: msvcrt/tests: add some demangle tests

2010-01-15 Thread Christian Costa
Maybe you can do it for ?swprintf@@YAHPA_WIPB_WZZ as well... André Hentschel a écrit : somehow regarding http://source.winehq.org/patches/data/57476 --- dlls/msvcrt/tests/cpp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/msvcrt/tests/cpp.c b/dlls/msvcrt/tests

Re: Legal issues with wine development

2010-01-15 Thread Steven Edwards
On Fri, Jan 15, 2010 at 1:41 AM, Benjamin Zink wrote: > I understand you aren't allowed to look at the source code. The question I > have is are you allowed to look at the headers and is an API that's auto > generated from the source ok to look at? http://www.cppdoc.com/ has a > javadoc style mfc

Re: [2/3] user32/tests: Add test for EM_GETIMESTATUS and EM_SETIMESTATUS.

2010-01-15 Thread Nikolay Sivov
On 1/15/2010 16:22, Kusanagi Kouichi wrote: + +imc = ImmGetContext(hwEdit); +if (!imc) +{ + trace("ImmGetContext failed.\n"); + DestroyWindow(hwEdit); + return; +} + Hi. A minor correction needed here - should be win_skip(), not just trace() with something

Re: MFC42.dll implementation

2010-01-15 Thread Michael Stefaniuc
Benjamin Zink wrote: > I was thinking about starting a wine implementation of mfc42.dll and was > wondering if anyone had already started or had some tips on where to start. Well, it is on my extended todo list. And I have started to work on it twice: the first time I found bugs and fixed them in m