Re: [PATCH 1/4] jscript: Added implementation of Array.reverse

2010-01-14 Thread Jacek Caban
Hi Piotr, On 1/15/10 1:17 AM, Piotr Caban wrote: --- dlls/jscript/array.c | 37 +++-- dlls/jscript/tests/api.js | 26 ++ 2 files changed, 61 insertions(+), 2 deletions(-) +if(hres1 == DISP_E_UNKNOWNNAME) +

Legal issues with wine development

2010-01-14 Thread Benjamin Zink
Hello, I understand you aren't allowed to look at the source code. The question I have is are you allowed to look at the headers and is an API that's auto generated from the source ok to look at? http://www.cppdoc.com/ has a javadoc style mfc api auto generated from the mfc source. Is this an

MFC42.dll implementation

2010-01-14 Thread Benjamin Zink
Hello, I was thinking about starting a wine implementation of mfc42.dll and was wondering if anyone had already started or had some tips on where to start. Thank you, Benjamin Zink

Code review request, fix for PATH setting bug 21322

2010-01-14 Thread Dan Kegel
I was surprised to find that Wine didn't handle system-wide and user-local PATH together properly. The bug and a proposed fix are at http://bugs.winehq.org/show_bug.cgi?id=21322 Could someone review the patch before I risk sending it to wine-patches? I think it's clean, but my luck hasn't been goo

Re: TRACE () documentation

2010-01-14 Thread James McKenzie
Nikolay Sivov wrote: > On 1/15/2010 05:31, James McKenzie wrote: >> James Hawkins wrote: >> >>> On Thu, Jan 14, 2010 at 6:19 PM, James McKenzie >>> wrote: >>> >>> All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the co

Re: TRACE () documentation

2010-01-14 Thread Nikolay Sivov
On 1/15/2010 05:31, James McKenzie wrote: James Hawkins wrote: On Thu, Jan 14, 2010 at 6:19 PM, James McKenzie wrote: All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you.

Re: TRACE () documentation

2010-01-14 Thread Nate Gallaher
James McKenzie wrote: James Hawkins wrote: On Thu, Jan 14, 2010 at 6:19 PM, James McKenzie wrote: All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you. There are

Re: TRACE () documentation

2010-01-14 Thread James McKenzie
James Hawkins wrote: > On Thu, Jan 14, 2010 at 6:19 PM, James McKenzie > wrote: > >> All: >> >> Is there documentation anywhere on how to use the TRACE command? >> >> I am trying to print out the contents of a UNICODE string using this commnd. >> >> Thank you. >> >> > > There are thousands

Re: TRACE () documentation

2010-01-14 Thread James Hawkins
On Thu, Jan 14, 2010 at 6:19 PM, James McKenzie wrote: > All: > > Is there documentation anywhere on how to use the TRACE command? > > I am trying to print out the contents of a UNICODE string using this commnd. > > Thank you. > There are thousands and thousands of examples in the source already.

TRACE () documentation

2010-01-14 Thread James McKenzie
All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you. James McKenzie

Re: kernel32/tests: do not compare handle with zero directly (Smatch)

2010-01-14 Thread Michael Stefaniuc
Andre, this is actually a false positive in the file_handles Smatch script. Or a valid bug requiring an other solution; depending on the point of view. On 01/14/2010 11:09 PM, André Hentschel wrote: --- dlls/kernel32/tests/virtual.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(

Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)

2010-01-14 Thread Paul Vriens
On 01/11/2010 09:47 PM, Peter Dons Tychsen wrote: Try 3 of this patch: - Moved check to server. - Removed handling of error code translation after input from AJ. Thanks, /pedro Hi Peter, This patch has introduced test failures on NT4 and below (tested locally): http://test.winehq.org/data

Re: ntoskrnl: Implement ExSystemTimeToLocalTime and ExLocalTimeToSystemTime

2010-01-14 Thread Alexandre Julliard
Erich Hoover writes: > Yup, sorry about that. It's funny how there are convenient functions > like that lying around. Is it acceptable to just forward the call in > the DLL spec when the return value of the function is different > (ExSystemTimeToLocalTime has no return where RtlSystemTimeToLoca

Re: ntoskrnl: Implement ExSystemTimeToLocalTime and ExLocalTimeToSystemTime

2010-01-14 Thread Erich Hoover
On Thu, Jan 14, 2010 at 9:40 AM, Alexandre Julliard wrote: > Erich Hoover writes: >> ... >>    ntoskrnl: Implement ExSystemTimeToLocalTime and ExLocalTimeToSystemTime. > > You most likely want to use RtlSystemTimeToLocalTime etc. > > -- > Alexandre Julliard > julli...@winehq.org > Yup, sorry abo

Re: ntoskrnl: Implement ExSystemTimeToLocalTime and ExLocalTimeToSystemTime

2010-01-14 Thread Alexandre Julliard
Erich Hoover writes: > Real Name: >Erich Hoover > Description: >The attached patch implements ExSystemTimeToLocalTime and > ExLocalTimeToSystemTime (Bug #19395), which are necessary to allow the > Sentinel Protection service to load (the Sentinel Protection service > is required by the fu

Re: [PATCH] Implement OleCreatePropertyFrame (try 2)

2010-01-14 Thread Geoffrey Hausheer
On Wed, Jan 13, 2010 at 10:38 PM, Piotr Caban wrote: > Hi, > > There're still some things that needs to be changed. Thank you for the continued feedback. > > In pixels_to_dialog_units: > +        *basex = ((float)size.cx/26+1)/2; > > +    *x_pixels = MulDiv(*x_pixels, 4, *basex); > I proposed doin

Re: Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

2010-01-14 Thread Jeremy Newman
It also helps if you prepend [website] to the subject. It makes it easier to find in a long list of wine patches. -Newman André Hentschel wrote: Vincent Cadet schrieb: Hi peoople. A couple of months ago, I submitted a patch I wrote to add a backlink to the previous version in WineHQ announc

Re: Wine AppDB xmlexport script

2010-01-14 Thread John Brezerk
2010/1/13 Austin English > On Tue, Jan 12, 2010 at 8:17 AM, John Brezerk wrote: > > Hi to All. > > > > I'd like to present php scripts ( attached xmlexport.tar.gz ) which make > > possible for third party applications to query appdb database. > > After processing user requests, script generates