Re: [PATCH] Implement OleCreatePropertyFrame (try 2)

2010-01-13 Thread Piotr Caban
Hi, There're still some things that needs to be changed. In prop_sheet_proc: +case WM_DESTROY: + { +OLEPropertyFrame *opf = (OLEPropertyFrame *)GetWindowLongPtrW(hwnd, DWLP_USER); +if(opf) { +IPropertyPage_Show(opf->propPage, SW_HIDE); +IPropertyPa

Re: Wine AppDB xmlexport script

2010-01-13 Thread Alexander Nicolaysen Sørnes
Onsdag 13. januar 2010 02.40.25 skrev John Klehm : > On Tue, Jan 12, 2010 at 6:45 PM, Andrew Nguyen wrote: > > On Tue, Jan 12, 2010 at 6:09 PM, Austin English wrote: > >> Is there any chance of a different license? Wine is currently LGPL > >> 2.1, it'd be nice to have the same license, if possi

Re: Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

2010-01-13 Thread André Hentschel
Vincent Cadet schrieb: >> De: André Hentschel >> Objet: Re: Patch: bug 19355, Wine web site, link to the previous version >> announcement in section "changes since" >> À: "Vincent Cadet" , "Wine Devel" > >> only possible problem i spotted is, that the patch is not >> in "git diff" format (or gi

Re: gdi32: Use the LOGFONT charset field on OEM font creation

2010-01-13 Thread Ilya Shpigor
Hi, Is this patch incorrect or more tests are needed? Dmitry said that there are needed additional tests, but you wouldn't like to commit these. Please explain my mistakes. -- Best regards, Ilya Shpigor.

Re: wineoss.drv: Ignore volume settings on primary buffer

2010-01-13 Thread Michael Stefaniuc
Maarten, Maarten Lankhorst wrote: > dsound shouldn't be able to mess with the system-wide volume if this is a deliberate design decision then the FIXME("stub") is wrong. It needs to be replaced by a TRACE (or WARN if you insist) with a message like: "Explicitly ignoring wodSetVolume request; dsoun

RE: [rsaenh/tests] Don't check result twice (Coccinelle)

2010-01-13 Thread Rolf Kalbermatter
Michael Stefaniuc [mailto:mstef...@redhat.com] > > But we are already returning a few lines above: > > > > 271 result = CryptCreateHash(hProv, CALG_MD2, 0, 0, &hHash); > > 272 if (!result) { > > 273 /* rsaenh compiled without OpenSSL */ > > 274 ok(GetLastError()==NTE_

Re: Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

2010-01-13 Thread Vincent Cadet
> De: André Hentschel > Objet: Re: Patch: bug 19355, Wine web site, link to the previous version > announcement in section "changes since" > À: "Vincent Cadet" , "Wine Devel" > only possible problem i spotted is, that the patch is not > in "git diff" format (or git format-patch) ? I used diff