This doesn't seem correct to me. According to MSDN, sprintf_s checks for valid
formatting chars (in addition to the buffer and format arguments) and invokes
an invalid parameter handler if something bad turns up. It then returns -1
with errno set to EINVAL if execution is allowed to continue. Ad
On Sun, Jan 10, 2010 at 12:57 PM, Paul Vriens
wrote:
> On 01/05/2010 11:50 AM, Paul Vriens wrote:
>>
>> On 01/05/2010 02:46 AM, James Hawkins wrote:
>>>
>>> ---
>>> dlls/advpack/tests/advpack.c | 7 +--
>>> 1 files changed, 1 insertions(+), 6 deletions(-)
>>>
>>
>> Hi James,
>>
>> Don't think t
James McKenzie wrote:
C++ type comments are not allowed.
Of course, it was a stupid mistake of me. The whole comment wasn't
relevant anymore.
Please mark second and subsequent submissions with [Try #] in the
message header. It keeps us from guessing which submission is the latest.
There
Julius Schwartzenberg wrote:
> Paul Vriens wrote:
>> Do any of these patches fix any of the tests? If so you should also
>> change the tests by removing one or more todo_wine()'s.
>>
>> This could become tricky though if your tests patches are not
>> committed before these ones.
>
> Yes, all the te
Julius Schwartzenberg wrote:
> These are resents of last week which are cleaned up more and with
> Detlef's patch on which they depend in front.
>
> While looking at avifile, I noticed some strange behaviour. Because
> some fixes may seem strange, I felt a test suite was really necessary
> to show
On 01/05/2010 11:50 AM, Paul Vriens wrote:
On 01/05/2010 02:46 AM, James Hawkins wrote:
---
dlls/advpack/tests/advpack.c | 7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
Hi James,
Don't think this works:
advpack: 0 tests executed (0 marked as todo, 0 failures), 0 skipped.
Hi
André Hentschel a écrit :
thanks Eric Pouech for the reviews
---
dlls/dbghelp/dwarf.c | 229 +-
dlls/dbghelp/dwarf.h | 15
2 files changed, 204 insertions(+), 40 deletions(-)
diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c
index 4
On 01/10/2010 06:00 PM, André Hentschel wrote:
Hi Paul,
sorry didnt see your patch, it was not my purpose to compete for that.
I also had broken() in mind, but using
http://www.winehq.org/pipermail/wine-devel/2008-October/069721.html i am not
sure.
The 'problem' with broken() is that it just
Paul Vriens schrieb:
> On 01/10/2010 05:44 PM, André Hentschel wrote:
>> ---
>> dlls/ntdll/tests/om.c |3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c
>> index 1bab21d..e351813 100644
>> --- a/dlls/ntdll/tests/om.c
>
On 01/10/2010 05:35 PM, Julius Schwartzenberg wrote:
First of all, my apologies for all the junk. I didn't fully understand
how the mail moderation exactly worked and made some wrong guesses.
I'm going to use git send-email now as Henri suggested me, to resent two
patches from the serie as repli
Paul Vriens wrote:
Do any of these patches fix any of the tests? If so you should also
change the tests by removing one or more todo_wine()'s.
This could become tricky though if your tests patches are not committed
before these ones.
Yes, all the tests work properly with my patches. I had un
On 01/10/2010 05:44 PM, André Hentschel wrote:
---
dlls/ntdll/tests/om.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c
index 1bab21d..e351813 100644
--- a/dlls/ntdll/tests/om.c
+++ b/dlls/ntdll/tests/om.c
@@ -677,7 +677
Henri Verbeet wrote:
2010/1/10 Julius Schwartzenberg :
My apologies to who'll read this. I found out a bit late my mailclient
sucked and used the wrong 'from' address. I've resent all my patches with
the proper address now, so all other mails from me may be dropped.
I'm not sure what was wrong
2010/1/10 David Adam :
> +
> +/* Test to show that the input quaternions are not changed */
> +expect_quat(q1,q1final);
> +expect_quat(q2,q2final);
> +
You have some trailing spaces here.
2010/1/10 Julius Schwartzenberg :
> My apologies to who'll read this. I found out a bit late my mailclient
> sucked and used the wrong 'from' address. I've resent all my patches with
> the proper address now, so all other mails from me may be dropped.
>
I'm not sure what was wrong with it? Afaik th
2010/1/10 Julius Schwartzenberg :
> This is Detlef's patch from June 2008 with just the import changed from
> "vfw32" to "avifil32" to work around bug 14085.
>
> http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html
>
You should add a proper "From: " line to the patch when submitting
p
On 1/10/2010 13:35, Paul Vriens wrote:
Are you sure? It reads to me as being available up to XP-SP2/W2K3 but
maybe removed or changed in newer versions. Anyway, we shouldn't ever
believe MSDN as even their remark about needed shell32 version 6 or
higher is not correct (see below) ;)
I misr
On 01/09/2010 11:50 PM, Nikolay Sivov wrote:
On 1/9/2010 19:37, Marcus Meissner wrote:
+static void
+test_shlmenu(void) {
+ HRESULT hres;
+ hres = Shell_MergeMenus (0, 0, 0x42, 0x4242, 0x424242, 0);
+ ok (hres == 0x4242, "expected 0x4242 but got %x\n", hres);
+ hres = Shell_MergeMenus ((HMENU)42
On 01/10/2010 03:18 AM, Julius Schwartzenberg wrote:
I was stupid last week and sent patches in a serie that didn't actually
depend on each other. I'm resending them properly now. All fixes are
actually independent from each other.
I started looking into some problems avifil32 had because Civili
On 01/10/2010 03:15 AM, Julius Schwartzenberg wrote:
+static void create_avi_file(const COMMON_AVI_HEADERS *cah, char *filename)
+{
+HANDLE hFile;
+DWORD written;
+
+hFile = CreateFile(filename, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS,
FILE_ATTRIBUTE_NORMAL, NULL);
+
+ok(hFile != I
20 matches
Mail list logo
