2010/1/7 Andrew Eikum :
> The last call in IHlink::Navigate is to IHlinkSite::OnNavigationComplete.
> This function takes an HRESULT argument which, according to MSDN, should
> contain the final result of the navigation. Again, according to MSDN,
> IHlink::Navigate should return S_OK on success,
Ok, I have reimplemented OleCreatePropertyFrame() from scratch. There
is no code from Hidenori's patch in mine, nor did I use it as a
reference (though of course I can't claim that I didn't learn anything
from his patch during my previous cleanup)
Would someone mind reviewing this for style/conte
Andrew Eikum schrieb:
> I've been working the past few days on cleaning up low-hanging-fruit
> bugs relating to MSOffice. I've run into one bug for which I have a
> solution, but I have no explanation as to why the solution is correct.
> It's what Windows does, but I don't know why! This email's
On Thu, Jan 07, 2010 at 11:28:37AM -0800, Juan Lang wrote:
> Hi Marcus,
>
> Ideally this patch would be accompanied by a test. Also, this change:
>
> @@ -212,6 +212,10 @@ static BOOL CRYPT_DecodeEnsureSpace(DWORD dwFlags,
>
> if (dwFlags & CRYPT_DECODE_ALLOC_FLAG)
> {
> +if (!
I've been working the past few days on cleaning up low-hanging-fruit
bugs relating to MSOffice. I've run into one bug for which I have a
solution, but I have no explanation as to why the solution is correct.
It's what Windows does, but I don't know why! This email's a bit long,
but it describ
Anything I can do to help move this along?
~Nate
Hi Alexandre,
Alexandre Julliard schreef:
Maarten Lankhorst writes:
@@ -33,6 +35,13 @@
WINE_DEFAULT_DEBUG_CHANNEL(mmdevapi);
+static const WCHAR software_wine_mmdevapi[] =
+{
'S','o','f','t','w','a','r','e','\\','W','i','n','e','\\','m','m','d','e','v','a','p','i',0};
Thi
Hi Marcus,
Ideally this patch would be accompanied by a test. Also, this change:
@@ -212,6 +212,10 @@ static BOOL CRYPT_DecodeEnsureSpace(DWORD dwFlags,
if (dwFlags & CRYPT_DECODE_ALLOC_FLAG)
{
+if (!pvStructInfo) {
+SetLastError(ERROR_INVALID_PARAMETER);
+
Maarten Lankhorst writes:
> @@ -33,6 +35,13 @@
>
> WINE_DEFAULT_DEBUG_CHANNEL(mmdevapi);
>
> +static const WCHAR software_wine_mmdevapi[] =
> +{
> 'S','o','f','t','w','a','r','e','\\','W','i','n','e','\\','m','m','d','e','v','a','p','i',0};
This looks suspicious. Why do you need a Wine
2010/1/7 Michael Stefaniuc :
> Hello Reece,
> Impressive script. Not sure if you have heard of coccinelle (semantic
> patcher, http://coccinelle.lip6.fr/); it sees some usage in the Linux
> Kernel project. As I would like to see it used on Wine too I've have
> added the corresponding cocci file for
Hello Reece,
Reece Dunn wrote:
> As a result of the "Wine FIXME Report 2009 Aug - Dec" thread, I
thanks for the patch. It is good to see that the FIXME report is useful
and generated some Wine commits.
> created the following to hunt for DllCanUnloadNow calls that were
> marked as being FIXME stu
11 matches
Mail list logo
