On 01/07/2010 03:33 AM, Peter Dons Tychsen wrote:
+/* check that SetCapture fails for another window and that it does
not touch the error code */
+set_cap_wnd = SetCapture(hWnd);
+err = GetLastError();
+ok(!set_cap_wnd, "ReleaseCapture should have
On Tuesday 05 January 2010 17:08:52 Dmitry Timoshkov wrote:
> "Ilya Shpigor" wrote:
> > Some explanation for this patch:
> >
> > The fsCsb is bitfield that is used as boolean value. If this is false the
> > DEFAULT_CHARSET is using and the real charset is choosen through the
> > current ANSI codep
Reece Dunn wrote:
> Hi,
>
> As a result of the "Wine FIXME Report 2009 Aug - Dec" thread, I
> created the following to hunt for DllCanUnloadNow calls that were
> marked as being FIXME stubs:
>
Thank you for the patch, Reece.
James McKenzie
On Wed, Jan 6, 2010 at 3:28 PM, Detlef Riekenberg wrote:
> According to MSDN, both parameter are unused and must be 0/NULL
> A FIXME for every call is useless
>
> (there is no PATCH 1/2, so a resend without that prefix)
>
> --
> By by ... Detlef
>
>
> ---
> dlls/mlang/mlang.c | 8
> 1
Hi Joel
When I read your preview page in Firefox, the lens for print preview in
idb_std_small.bmp is to large.
You can't detect the printer behind the lens. (LCD Resolution here is 1400x1050)
As an Idea for an improvement, the print preview menu icon in Firefox is
readable:
The lens is a bit sm
On Wednesday 06 January 2010 17:49:12 Kai Blin wrote:
> I'll send a patch.
I see Wolfram beat me to it. :)
Cheers,
Kai
--
Kai Blin
WorldForge developer http://www.worldforge.org/
Wine developerhttp://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/
--
Wil
On Wed, Jan 6, 2010 at 7:21 AM, Alexandre Julliard wrote:
> Crashing is the best behavior. Adding parameter checks all over the
> place only hides bugs.
I keep forgetting that crashing is good sometimes :-)
On Wednesday 06 January 2010 01:02:04 Reece Dunn wrote:
> 2010/1/5 Michael Stefaniuc :
> > 2040 | 36 | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109
>
> 0xc109 is NT_STATUS_MESSAGE_NOT_FOUND according to
> http://lists.samba.org/archive/jcifs/2004-February/003038.html.
>
> Inter
Dan Kegel writes:
> AJ wrote:
>> Marcus Meissner writes:
>>> buffer and size need to be either 0 at the same time or not,
>>> otherwise this breaks up. Windows is inconsistent (either crashes
>>> or returns invalids), so we can just add checking.
>>
>>If Windows crashes we don't need extra check
On 01/06/2010 04:03 PM, Dan Kegel wrote:
AJ wrote:
Marcus Meissner writes:
buffer and size need to be either 0 at the same time or not,
otherwise this breaks up. Windows is inconsistent (either crashes
or returns invalids), so we can just add checking.
If Windows crashes we don't need extra
2010/1/6 Maarten Lankhorst :
> Hi Reece,
>
> Reece Dunn schreef:
>>
>> NOTE: Some of the DllCanUnloadNow functions always return S_OK. I
>> intend to address that in a separate patch once I have investigated
>> whether the DLLs implement COM objects or not.
>>
>
> When a dll is first implemented it
AJ wrote:
> Marcus Meissner writes:
>> buffer and size need to be either 0 at the same time or not,
>> otherwise this breaks up. Windows is inconsistent (either crashes
>> or returns invalids), so we can just add checking.
>
>If Windows crashes we don't need extra checks. Just tell Coverity that
>
Hi Reece,
Reece Dunn schreef:
NOTE: Some of the DllCanUnloadNow functions always return S_OK. I
intend to address that in a separate patch once I have investigated
whether the DLLs implement COM objects or not.
When a dll is first implemented it probably returns S_OK since no
interfaces were
2010/1/6 David Gerard :
> whoops, sending to list as well!
>
> 2010/1/5 Reece Dunn :
>
>> 2/ the major issues appear to be in the application launchers used
>> by different game providers (most of which are in the current wine
>> implementation of the IE browser ActiveX control);
>
> Curious ques
whoops, sending to list as well!
-- Forwarded message --
From: David Gerard
Date: 2010/1/6
Subject: Re: The (Casual) Game Support Report in Wine (Jan 2009)
To: Reece Dunn
2010/1/5 Reece Dunn :
> 2/ the major issues appear to be in the application launchers used
> by differe
On 01/06/2010 01:59 PM, Marcus Meissner wrote:
diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c
index e3f7156..8e64e73 100644
--- a/dlls/kernel32/tests/profile.c
+++ b/dlls/kernel32/tests/profile.c
@@ -266,6 +266,10 @@ static void test_profile_sections_names(void)
On 01/06/2010 01:59 PM, Marcus Meissner wrote:
diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c
index e3f7156..8e64e73 100644
--- a/dlls/kernel32/tests/profile.c
+++ b/dlls/kernel32/tests/profile.c
@@ -266,6 +266,10 @@ static void test_profile_sections_names(void)
On Wed, Jan 06, 2010 at 01:34:28PM +0100, Alexandre Julliard wrote:
> Marcus Meissner writes:
>
> > buffer and size need to be either 0 at the same time or not,
> > otherwise this breaks up. Windows is inconsistent (either crashes
> > or returns invalids), so we can just add checking.
>
> If Win
Marcus Meissner writes:
> buffer and size need to be either 0 at the same time or not,
> otherwise this breaks up. Windows is inconsistent (either crashes
> or returns invalids), so we can just add checking.
If Windows crashes we don't need extra checks. Just tell Coverity that
crashing is allow
On 01/06/2010 01:26 PM, Marcus Meissner wrote:
+if (!RtlCreateUnicodeStringFromAsciiz(&filenameW, filename)) {
+SetLastError(ERROR_OUTOFMEMORY);
+return 0;
+}
Aren't you leaking bufferW here?
--
Cheers,
Paul.
2010/1/5 Stefan Dösinger :
> After the discussion on IRC I wasn't quite sure what you intended with
> wined3d_event_query_wait(), but maybe it was something like this:
>
More something along the lines of the attached patch, actually. There
are of course some intermediate steps.
diff --git a/dlls/w
On Wed, Jan 6, 2010 at 2:45 AM, Vincent Povirk
wrote:
> It might be interesting to select for err:module:import_dll lines,
> which are (sometimes) missing dll's.
>
>> 77 | 99 | ole:CoGetClassObject no class object
>> {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1
>>
Ilya Shpigor wrote:
> If the "Terminal" font will be changed in test to "Tahoma" this still be
> failed.
>
> Are you sure what the current behavior of the WineEngCreateFontInstance is
> correct? When the user create logical font with OEM charset the
> GetTextCharset function will be always re
2010/1/5 Christian Costa :
> Here it is. The fixme message is :
> fixme:d3d:set_tex_op_nvrc > GL_INVALID_ENUM (0x500) from
> set_tex_op_nvrc() @ nvidia_texture_shader.c / 460
>
Looks like the context creation code invalidates those states simply
because they exist. Does the attached
Reece Dunn a écrit :
2010/1/6 Christian Costa :
Reece Dunn a écrit :
1/ the games themselves tend to work very well (and have done for a
long while now thanks to the great work CodeWeavers did in getting
DirectDraw and Direct3D working);
While you are at in, you can also thank
On 01/05/2010 08:05 PM, André Hentschel wrote:
vista and 2k8: fails
w7:timeout
---
dlls/ole32/tests/clipboard.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/dlls/ole32/tests/clipboard.c b/dlls/ole32/tests/clipboard.c
index 626d244..4a9e234 100644
--- a/
2010/1/6 Christian Costa :
> Reece Dunn a écrit :
>>
>> 1/ the games themselves tend to work very well (and have done for a
>> long while now thanks to the great work CodeWeavers did in getting
>> DirectDraw and Direct3D working);
>
> While you are at in, you can also thanks people that worked in
Reece Dunn a écrit :
1/ the games themselves tend to work very well (and have done for a
long while now thanks to the great work CodeWeavers did in getting
DirectDraw and Direct3D working);
While you are at in, you can also thanks people that worked in this area
in their spare time.
A+
28 matches
Mail list logo
