Re: Use GCC's -Wlogical-op if possible

2010-01-03 Thread Gerald Pfeifer
On Sun, 3 Jan 2010, Austin English wrote: >> On my FreeBSD test system I am see no warnings triggered by -Wlogical-op >> any more.  How does it look on your side? > ole32: > usrmarshal.c:485: warning: logical ?&&? with non-zero constant will > always evaluate as true > usrmarshal.c:1098: warning: l

Re: Patch feedback requested for OleCreatePropertyFrame()

2010-01-03 Thread Maarten Lankhorst
Hi Geoffrey, 2010/1/4 Geoffrey Hausheer : > Some software I'm using is configured via an OleCreatePropertyFrame > call which isn't implemented in Wine (ticket #16564).  I can use > winetricks + dcom98 to get it working, but would prefer not to need > that.  I found a patch from 2001 written by TAK

Patch feedback requested for OleCreatePropertyFrame()

2010-01-03 Thread Geoffrey Hausheer
Some software I'm using is configured via an OleCreatePropertyFrame call which isn't implemented in Wine (ticket #16564).  I can use winetricks + dcom98 to get it working, but would prefer not to need that.  I found a patch from 2001 written by TAKESHIMA Hidenori that was posted to wine-patches (ht

Re: Use GCC's -Wlogical-op if possible

2010-01-03 Thread Austin English
On Sun, Jan 3, 2010 at 4:13 AM, Gerald Pfeifer wrote: > On Tue, 23 Jun 2009, Paul Vriens wrote: >>> For those interested, here's the make log in Monday's git. 94 warnings >>> for me. >> Sent 3 patches based on your log. >> >> I have less (55) warnings on 4.3.2 btw, but most look like false positiv

Re: [1/7] avifile: Initial test data and simple test for avifil32 depends

2010-01-03 Thread Michael Stefaniuc
On 01/01/2010 10:11 PM, Austin English wrote: On Fri, Jan 1, 2010 at 2:18 PM, Julius Schwartzenberg wrote: I think it was also stupid of me to send all the patches as a serie, while they do not actually depend on each other. I'm not sure though how I would submit the patches next time. Should

Re: Use GCC's -Wlogical-op if possible

2010-01-03 Thread Gerald Pfeifer
On Tue, 23 Jun 2009, Paul Vriens wrote: >> For those interested, here's the make log in Monday's git. 94 warnings >> for me. > Sent 3 patches based on your log. > > I have less (55) warnings on 4.3.2 btw, but most look like false positives. On my FreeBSD test system I am see no warnings triggere