Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 03/01/10 08:29, Jeff Latimer wrote: On 03/01/10 01:12, Nikolay Sivov wrote: On 1/2/2010 13:52, Jeff Latimer wrote: On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Reece Dunn
2010/1/2 Nikolay Sivov : > On 1/2/2010 13:56, Jeff Latimer wrote: >> >> On 02/01/10 21:42, Nikolay Sivov wrote: >>> >>> On 1/2/2010 12:48, Jeff Latimer wrote: ---  dlls/comctl32/listview.c |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> Actually setting buffer

Re: comctl32: Get the test in the correct format

2010-01-02 Thread Jeff Latimer
On 02/01/10 21:25, Nikolay Sivov wrote: On 1/2/2010 12:47, Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) You don't need this. Conversion is done next lines if needed: --- if (isW) bSame = (lstrcmpW(dispInfo.item.pszText

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 03/01/10 01:12, Nikolay Sivov wrote: On 1/2/2010 13:52, Jeff Latimer wrote: On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +dispInfo.item.cchTextMax = textlenT(psz

Re: [PATCH 1/2] msi: queue dynamically allocated strings in cond.y

2010-01-02 Thread James Hawkins
On Sat, Jan 2, 2010 at 10:36 AM, Nathan Gallaher wrote: > > +struct cond_mem { +struct list entry; +void *ptr; +}; + +static void cond_free( void *info, void *ptr ) +{ +COND_input *cond = (COND_input*) info; +struct cond_mem *mem, *safety; + +LIST_FOR_EACH_ENTRY_SAFE( mem,

Re: [rfc] initial conformance test for programs/cmd

2010-01-02 Thread André Hentschel
Dan Kegel schrieb: > On Sat, Jan 2, 2010 at 5:25 AM, Eric Pouech wrote: >> what I don't like in current design: >> - it requires external files to the generic .c file (but putting it into a >> resource would do) > > The current design *does* put the external files into a resource, so > I think I'

Re: merge wine-website's Todo

2010-01-02 Thread André Hentschel
Thomas Heckel schrieb: > Hi, > > the last days I had some free time and tried to make some cleanups to > the wiki. I mainly worked on the pages related to quality assurance > because my little contributions was to Austin's AppInstall which is on > this topic. I hope this way I can contribute to th

Re: Thanks Wylda

2010-01-02 Thread Austin English
2010/1/2 : > PS: You know i'm father, so her->his ;-) But don't worry, even in Czech > language you can not decide HE/SHE just based on "Wylda" (in 99.9% you > can, but Wylda is nickname). Heh. I was wondering...I didn't want to insult you by using the wrong one, so I asked in #winehackers/google

Re: Is native dbghelp useful?

2010-01-02 Thread Austin English
On Sat, Jan 2, 2010 at 7:20 AM, Eric Pouech wrote: > Austin English a écrit : >> >> I noticed Microsoft's got dbghelp in a download available...would the >> native dll be useful to anyone? E.g., should I add it to winetricks? >> >> >> http://www.microsoft.com/downloads/details.aspx?FamilyID=cd1fc4

Re: [rfc] initial conformance test for programs/cmd

2010-01-02 Thread Dan Kegel
On Sat, Jan 2, 2010 at 5:25 AM, Eric Pouech wrote: > what I don't like in current design: > - it requires external files to the generic .c file (but putting it into a > resource would do) The current design *does* put the external files into a resource, so I think I've satisfied that already. >

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Nikolay Sivov
On 1/2/2010 13:56, Jeff Latimer wrote: On 02/01/10 21:42, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for disp

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Nikolay Sivov
On 1/2/2010 13:52, Jeff Latimer wrote: On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; What does this '2' mean? +

Re: [rfc] initial conformance test for programs/cmd

2010-01-02 Thread Eric Pouech
Dan Kegel a écrit : How's this look? I've only tested it lightly, but it should be pretty close; with this, "make test" ought to recurse down into programs/cmd/tests and run the cmd tests, too. Shortcomings: - I don't think I need chomp() in tests/cmd.c anymore, that was a workaround - I think

merge wine-website's Todo

2010-01-02 Thread Thomas Heckel
Hi, the last days I had some free time and tried to make some cleanups to the wiki. I mainly worked on the pages related to quality assurance because my little contributions was to Austin's AppInstall which is on this topic. I hope this way I can contribute to the project. At the moment I st

Re: Is native dbghelp useful?

2010-01-02 Thread Eric Pouech
Austin English a écrit : I noticed Microsoft's got dbghelp in a download available...would the native dll be useful to anyone? E.g., should I add it to winetricks? http://www.microsoft.com/downloads/details.aspx?FamilyID=cd1fc4b2-0885-47f4-af45-7fd5e14db6c0&DisplayLang=en -- -Austin for

Re: Is native dbghelp useful?

2010-01-02 Thread Maarten Lankhorst
Hi Austin, Austin English schreef: I noticed Microsoft's got dbghelp in a download available...would the native dll be useful to anyone? E.g., should I add it to winetricks? http://www.microsoft.com/downloads/details.aspx?FamilyID=cd1fc4b2-0885-47f4-af45-7fd5e14db6c0&DisplayLang=en Probably

Re: [4/6] WineD3D: Add GL_APPLE_flush_buffer_range

2010-01-02 Thread Henri Verbeet
2010/1/1 Stefan Dösinger : > +typedef void (WINE_GLAPI *PGLBUFFERPARAMETERIAPPLE) (GLenum target, GLenum > pname, GLint param); > +typedef void (WINE_GLAPI *PGLFLUSHMAPPEDBUFFERRANGEAPPLE) (GLenum target, > ptrdiff_t offset, ptrdiff_t size); Any reason for not using the same naming convention as

Re: [PATCH] wined3d: Do not try to use not available texture stages in set_tex_op_nvr

2010-01-02 Thread Henri Verbeet
A +d3d,+d3d_caps log would probably be a good start.

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 02/01/10 21:42, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for dispInfo.item. Because it is tied up with ca

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; What does this '2' mean? +1 adds the trailing null and +2 allows f

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Nikolay Sivov
On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for dispInfo.item. A test required for this - let's say check that an ownerdata listview

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Nikolay Sivov
On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; What does this '2' mean?

Re: comctl32: Get the test in the correct format

2010-01-02 Thread Nikolay Sivov
On 1/2/2010 12:47, Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) You don't need this. Conversion is done next lines if needed: --- if (isW) bSame = (lstrcmpW(dispInfo.item.pszText, pszText) == 0); else {

Re: Thanks Wylda

2010-01-02 Thread wylda
Hi Austin, i was really pleased by this mail. It's always good to know, weather your work has some sense. Thank you too and all the people around Wine. W. PS: You know i'm father, so her->his ;-) But don't worry, even in Czech language you can not decide HE/SHE just based on "Wylda" (in 99.9% y