Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Peter Dons Tychsen
On Sat, 2009-12-26 at 20:53 +0100, Jacek Caban wrote: > We can't really change the language as Windows doesn't provide English > resources for most binaries and executables on on non-English > installations. Why not just have the tests file check the locale, and then do skip() for the language dep

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Peter Dons Tychsen
On Fri, 2009-12-25 at 19:55 -0800, Dan Kegel wrote: > So, where should the tests live? I had been thinking > programs/cmd/tests, > but maybe something like programs/tests would be better > given that it can test more than just cmd. I think it would make most sense to follow the current strategy o

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Jacek Caban
On 12/26/09 8:44 PM, Dan Kegel wrote: Also, your tests are very risky in terms of non-English locales. I think we shouldn't test error messages strings. Can we force the locale to a particular value for the tests with a registry key or something? It'd be pretty hard to write tests without

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Dan Kegel
On Sat, Dec 26, 2009 at 11:06 AM, Jacek Caban wrote: > I've been following cmd.exe topic and I was concerned about the fact, that > these tests are out of Wine tree, so I wanted to help and implemented a > simple framework. I almost didn't test it so I didn't send it before. It > caused a code dup

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Steven Edwards
On Sat, Dec 26, 2009 at 1:57 PM, Erich Hoover wrote: > Are you using a real cmd.exe or the Wine cmd.exe?  I encountered a problem > at one point with using a real cmd.exe with CreateProcess, I never actually > finished tracking it down though b/c it wasn't an issue with the > Wine-included cmd.exe

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Jacek Caban
Hi Dan, On 12/26/09 5:16 PM, Dan Kegel wrote: OK, cmd/tests it is. I've updated http://kegel.com/wine/sweng/2010/#tests accordingly. A rough prototype is at http://kegel.com/wine/cmd/tests/ (I'm doing this all on a tiny netbook which doesn't have a wine development system, so I can't produce a

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Erich Hoover
On Sat, Dec 26, 2009 at 11:52 AM, Dan Kegel wrote: > (grumble. I switched to CreateProcess from system() for more clarity, > and now cmd isn't running. I have to go be a dad for the rest of the > day; the code is at > http://kegel.com/wine/cmdtest-11.tar.gz > if someone wants to have a look. >

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Dan Kegel
(grumble. I switched to CreateProcess from system() for more clarity, and now cmd isn't running. I have to go be a dad for the rest of the day; the code is at http://kegel.com/wine/cmdtest-11.tar.gz if someone wants to have a look. It's kind of a pain developing on a netbook without a wine tree.

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Dan Kegel
On Sat, Dec 26, 2009 at 8:28 AM, Nikolay Sivov wrote: > Just thought about a kind of simple diff-like builtin helper. Otherwise > failure output won't > very descriptive, e.g. a missing newlines in some place shift it and it goes > to garbage. We should be able to get rid of most of the whitespac

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Nikolay Sivov
On 12/26/2009 19:16, Dan Kegel wrote: - better messages on test failures? Just thought about a kind of simple diff-like builtin helper. Otherwise failure output won't very descriptive, e.g. a missing newlines in some place shift it and it goes to garbage. - alternately, move to one test s

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread Dan Kegel
OK, cmd/tests it is. I've updated http://kegel.com/wine/sweng/2010/#tests accordingly. A rough prototype is at http://kegel.com/wine/cmd/tests/ (I'm doing this all on a tiny netbook which doesn't have a wine development system, so I can't produce a patch yet.) To-do list: - fix http://bugs.winehq

Re: Acting as advisor for wcmd-uplift project?

2009-12-26 Thread André Hentschel
Dan Kegel schrieb: > Peter Dons Tychen wrote: >> Why not place the test in the source tree along with all of >> the other tests. Of course this requires the tests to be run from a C >> based file > > Yep. I should have a patch ready to submit tomorrow that > is a barebones batch file test driver

Re: avifile tests

2009-12-26 Thread André Hentschel
Julius Schwartzenberg schrieb: > What do you think of the > general idea of the tests? Hi Julius, As i cant proof correctness here, i just can say that the general idea is great. Until Bug 14085 is fixed you can todo_wine it out. Further i think you can leave the data in the c-file(we also have r

Re: qedit: Implement partially the Sample Grabber filter

2009-12-26 Thread Rob Shearman
2009/12/23 Paul Chitescu : > Changelog: >        qedit: Implement partially the Sample Grabber filter > > The IMediaPosition, IMediaSeeking and IQualityControl interfaces are currently > not implemented at all. No programs I've tested tried to query them though. > > Buffering of samples is also not