Re: Acting as advisor for wcmd-uplift project?

2009-12-25 Thread Dan Kegel
Peter Dons Tychen wrote: > Why not place the test in the source tree along with all of > the other tests. Of course this requires the tests to be run from a C > based file Yep. I should have a patch ready to submit tomorrow that is a barebones batch file test driver written in C suitable for use

Re: Acting as advisor for wcmd-uplift project?

2009-12-25 Thread Peter Dons Tychsen
On Tue, 2009-12-22 at 15:36 -0600, Austin English wrote: > Sure. FWIW, I'm working on some AutoHotKey/Appinstall tests for cmd, > but it's a bit difficult, since the only way to capture the stdout is > to pipe it to a file first. Hey, i think a test suite for cmd is an excellent idea, and is surel

Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2009-12-25 Thread James McKenzie
Nikolay Sivov wrote: > On 12/26/2009 00:47, James McKenzie wrote: >> Nikolay Sivov wrote: >> >>> Why? There's no default case, treat is as 'if () {} else if () {} >>> etc.'. >>> It's the same thing to have explicit initializers for all local >>> variables even if I don't use it before >>> set so

Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2009-12-25 Thread Nikolay Sivov
On 12/26/2009 00:47, James McKenzie wrote: Nikolay Sivov wrote: Why? There's no default case, treat is as 'if () {} else if () {} etc.'. It's the same thing to have explicit initializers for all local variables even if I don't use it before set some value. It's a pollution, especially if use

Re: Acting as advisor for wcmd-uplift project?

2009-12-25 Thread Austin English
On Fri, Dec 25, 2009 at 4:13 PM, Peter Dons Tychsen wrote: > On Tue, 2009-12-22 at 15:36 -0600, Austin English wrote: >> Sure. FWIW, I'm working on some AutoHotKey/Appinstall tests for cmd, >> but it's a bit difficult, since the only way to capture the stdout is >> to pipe it to a file first. > >

Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2009-12-25 Thread James McKenzie
Nikolay Sivov wrote: > On 12/26/2009 00:04, James McKenzie wrote: >> Nikolay Sivov wrote: >> >>> On 12/25/2009 14:18, Gerald Pfeifer wrote: >>> Otherwise max_count will be undefined in the following loop may do interesting things it seems. (Does Coverity diagnose similar items?)

Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2009-12-25 Thread Nikolay Sivov
On 12/26/2009 00:04, James McKenzie wrote: Nikolay Sivov wrote: On 12/25/2009 14:18, Gerald Pfeifer wrote: Otherwise max_count will be undefined in the following loop may do interesting things it seems. (Does Coverity diagnose similar items?) Gerald ChangeLog: Improve handling of i

Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2009-12-25 Thread James McKenzie
Nikolay Sivov wrote: > On 12/25/2009 14:18, Gerald Pfeifer wrote: >> Otherwise max_count will be undefined in the following loop may do >> interesting things it seems. (Does Coverity diagnose similar items?) >> >> Gerald >> >> ChangeLog: >> Improve handling of invalid input in DATETIME_ReturnField

avifile tests

2009-12-25 Thread Julius Schwartzenberg
Hi, I still have some fixes for avifile here, but because they are quite nasty, I thought it'd be useful to have proper tests to show the fixes are really correct. Unfortunately there is still a problem with the avifile tests as Detlef indicated in this mail: http://www.winehq.org/pipermail

Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2009-12-25 Thread Nikolay Sivov
On 12/25/2009 14:18, Gerald Pfeifer wrote: Otherwise max_count will be undefined in the following loop may do interesting things it seems. (Does Coverity diagnose similar items?) Gerald ChangeLog: Improve handling of invalid input in DATETIME_ReturnFieldWidth. diff --git a/dlls/comctl32/datet