Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog

2009-12-23 Thread Steven Edwards
Hi Dmitry, On Thu, Dec 24, 2009 at 2:21 AM, Dmitry Timoshkov wrote: > Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch > much smaller. Also avoiding useless typedef, making WineFile_OnRun() static, > using correct casts, avoiding hungarian notation and magic flags would m

Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog

2009-12-23 Thread Dmitry Timoshkov
"Steven Edwards" wrote: - Removed the LoadLibrary calls in favor of GetModuleHandle as suggested by Paul Vriens - Match the bad formating of the rest of the file Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch much smaller. Also avoiding useless typedef, making WineF

Re: [PATCH 1/2] comctl32/updown: Don't update buddy text if it's the same.

2009-12-23 Thread Nikolay Sivov
On 12/23/2009 23:50, Paul Vriens wrote: On 12/23/2009 07:55 PM, Nikolay Sivov wrote: On 12/23/2009 21:49, Paul Vriens wrote: On 12/22/2009 10:43 PM, Nikolay Sivov wrote: Don't update buddy text if it's the same. There's at least one application that depends on this behavior: http://bugs.wineh

Re: [PATCH 1/2] comctl32/updown: Don't update buddy text if it's the same.

2009-12-23 Thread Paul Vriens
On 12/23/2009 07:55 PM, Nikolay Sivov wrote: On 12/23/2009 21:49, Paul Vriens wrote: On 12/22/2009 10:43 PM, Nikolay Sivov wrote: Don't update buddy text if it's the same. There's at least one application that depends on this behavior: http://bugs.winehq.org/show_bug.cgi?id=18574 This bug is

Re: winefile - replace Run/Execute dialog with standard Shell32 RunFileDlg

2009-12-23 Thread Steven Edwards
On Wed, Dec 23, 2009 at 1:26 PM, Paul Vriens wrote: > Isn't shell32 already available (it's imported, see Makefile.in)? If so a > GetModuleHandleW() would suffice. Your right. Looking closer it looks like I didn't follow the Tab abuse that's used in the rest of the file either so I'll resubmit wi

Re: [PATCH 1/2] comctl32/updown: Don't update buddy text if it's the same.

2009-12-23 Thread Nikolay Sivov
On 12/23/2009 21:49, Paul Vriens wrote: On 12/22/2009 10:43 PM, Nikolay Sivov wrote: Don't update buddy text if it's the same. There's at least one application that depends on this behavior: http://bugs.winehq.org/show_bug.cgi?id=18574 This bug is closed cause crash no longer occurs in 1.1.35

trivial cmd test suite

2009-12-23 Thread Dan Kegel
http://kegel.com/wine/sweng/2010/#tests now points to a trivial test suite for cmd that is currently driven by a shell script (so on windows you need to install cygwin). Later I'll replace the shell script with a C program that bundles the test data into the executable to allow its use in WineTestB

Re: [PATCH 1/2] comctl32/updown: Don't update buddy text if it's the same.

2009-12-23 Thread Paul Vriens
On 12/22/2009 10:43 PM, Nikolay Sivov wrote: Don't update buddy text if it's the same. There's at least one application that depends on this behavior: http://bugs.winehq.org/show_bug.cgi?id=18574 This bug is closed cause crash no longer occurs in 1.1.35 due a regression it contains, the real pr

Patch for mmdevapi/tests/dependency.c

2009-12-23 Thread Paul Vriens
Hi Maarten, Your patch to fix the test failure for boxes with no soundcard was not committed (yet?). Would the following patch be ok? It also includes more cleanup. -- Cheers, Paul. diff --git a/dlls/mmdevapi/tests/dependency.c b/dlls/mmdevapi/tests/dependency.c index 1568bed..9b3be0f 100644

Re: winefile - replace Run/Execute dialog with standard Shell32 RunFileDlg

2009-12-23 Thread Paul Vriens
On 12/23/2009 07:08 PM, Steven Edwards wrote: +hShell32 = LoadLibraryW(wszShell32); Isn't shell32 already available (it's imported, see Makefile.in)? If so a GetModuleHandleW() would suffice. -- Cheers, Paul.

Re: Parser for cmd language?

2009-12-23 Thread Dan Kegel
On Wed, Dec 23, 2009 at 12:22 AM, Eric Pouech wrote: >> http://kegel.com/wine/sweng/2010/ > > you could add a couple of references to cmd interpretations: > > in task#1, > - the .bat (and others) files should be embedded in the .c files and > generated on the fly for better inclusion > - this has

Re: [3/5] WineD3D: Set WINED3D_BUFFER_CREATEBO in buffer_init

2009-12-23 Thread Stefan Dösinger
Am 22.12.2009 um 19:23 schrieb Roderick Colenbrander: > On Tue, Dec 22, 2009 at 6:44 PM, Henri Verbeet wrote: >> 2009/12/22 Stefan Dösinger : >>> +conv = ((FVF & WINED3DFVF_POSITION_MASK) == WINED3DFVF_XYZRHW ) || >>> (FVF & (WINED3DFVF_DIFFUSE | WINED3DFVF_SPECULAR)); >>> hr = buffer_

Re: [PATCH 2/5] wined3d: Focus the focus window.

2009-12-23 Thread Stefan Dösinger
Am 22.12.2009 um 18:32 schrieb Henri Verbeet: > +SetFocus(This->focus_window); > + Is this correct for windowed rendering as well?

Re: [1/5] WineD3D: Revert the GL usage confusion

2009-12-23 Thread Stefan Dösinger
Am 22.12.2009 um 17:08 schrieb Roderick Colenbrander: > On Tue, Dec 22, 2009 at 4:51 PM, Stefan Dösinger > wrote: >> We had a discussion in wine-devel a few days ago about which GL usage is >> better. The red book also agrees with the GL wiki, but the GL 3.0 spec uses >> the confusing languag

Re: [2/5] WineD3D: Use unload instead of duplicating buffer remove code

2009-12-23 Thread Stefan Dösinger
Am 22.12.2009 um 17:06 schrieb Henri Verbeet: > 2009/12/22 Stefan Dösinger : >> -HeapFree(GetProcessHeap(), 0, This->conversion_shift); >> +IWineD3DBuffer_UnLoad(iface); >> +This->flags &= ~WINED3D_BUFFER_CREATEBO; > UnLoad() doesn't free "conversion_shift". Sh

Re: Parser for cmd language?

2009-12-23 Thread Eric Pouech
Dan Kegel a écrit : I'm getting ready to propose this as a project for students at UCLA. See http://kegel.com/wine/sweng/2010/ Comments welcome (especially from anyone who knows our current cmd implementation). you could add a couple of references to cmd interpretations: http://www.micros