Re: Status check for patches 56770/56772

2009-12-22 Thread James Hawkins
On Tue, Dec 22, 2009 at 1:10 PM, Nathan Gallaher wrote: > Seeing if there was anything I can do to help either of these patches move > along.  Don't want them to get lost. > I have a modified patch that I'll submit by the end of the day. Thanks, James Hawkins

Status check for patches 56770/56772

2009-12-22 Thread Nathan Gallaher
Seeing if there was anything I can do to help either of these patches move along. Don't want them to get lost. ~Nate

Re: [1/5] WineD3D: Revert the GL usage confusion

2009-12-22 Thread Roderick Colenbrander
On Tue, Dec 22, 2009 at 5:08 PM, Roderick Colenbrander wrote: > On Tue, Dec 22, 2009 at 4:51 PM, Stefan Dösinger > wrote: >> We had a discussion in wine-devel a few days ago about which GL usage is >> better. The red book also agrees with the GL wiki, but the GL 3.0 spec uses >> the confusing

Re: gdiplus: Implement GdipGet/SetStringFormatMeasurableCharacterRanges.

2009-12-22 Thread Vincent Povirk
> +    format->character_ranges = GdipAlloc(rangeCount * > sizeof(CharacterRange)); > +    if (!format->character_ranges) > +        return OutOfMemory; > > -    return NotImplemented; > +    memcpy(format->character_ranges, ranges, sizeof(CharacterRange) * > rangeCount); > +    format->range_cou

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates

2009-12-22 Thread Paul Vriens
On 12/22/2009 05:13 PM, Owen Rudge wrote: Hi Paul, Would something like this be ok: file_size_orig = get_file_size(); + if (file_size_orig % 16 != 0) + { + trace("We need to adjust the file size\n"); + file_size_orig = ((file_size_orig / 16) + 1) * 16; + } Does anybody know if '16' is indeed

Re: [3/5] WineD3D: Set WINED3D_BUFFER_CREATEBO in buffer_init

2009-12-22 Thread Roderick Colenbrander
On Tue, Dec 22, 2009 at 6:44 PM, Henri Verbeet wrote: > 2009/12/22 Stefan Dösinger : >> +    conv = ((FVF & WINED3DFVF_POSITION_MASK) == WINED3DFVF_XYZRHW ) || (FVF >> & (WINED3DFVF_DIFFUSE | WINED3DFVF_SPECULAR)); >>      hr = buffer_init(object, This, Size, Usage, WINED3DFMT_VERTEXDATA, >> -  

Re: [3/5] WineD3D: Set WINED3D_BUFFER_CREATEBO in buffer_init

2009-12-22 Thread Henri Verbeet
2009/12/22 Stefan Dösinger : > +conv = ((FVF & WINED3DFVF_POSITION_MASK) == WINED3DFVF_XYZRHW ) || (FVF > & (WINED3DFVF_DIFFUSE | WINED3DFVF_SPECULAR)); > hr = buffer_init(object, This, Size, Usage, WINED3DFMT_VERTEXDATA, > -Pool, GL_ARRAY_BUFFER_ARB, NULL, parent, parent_ops)

Re: advapi32/tests: Fix test crash in Wine

2009-12-22 Thread Paul Vriens
On 12/22/2009 05:29 PM, Nikolay Sivov wrote: On 12/22/2009 20:09, Vladimir Pankratov wrote: Hello all. Fixed test crash in Wine. changed files: dlls/advapi32/tests/eventlog.c Thanks. Looks like you're hiding a real problem. BTW, I don't see any crashes on Wine in test page. How did you test

Re: advapi32/tests: Fix test crash in Wine

2009-12-22 Thread Nikolay Sivov
On 12/22/2009 20:09, Vladimir Pankratov wrote: Hello all. Fixed test crash in Wine. changed files: dlls/advapi32/tests/eventlog.c Thanks. Looks like you're hiding a real problem. BTW, I don't see any crashes on Wine in test page. How did you test it?

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates

2009-12-22 Thread Paul Vriens
On 12/22/2009 05:13 PM, Owen Rudge wrote: Hi Paul, Would something like this be ok: file_size_orig = get_file_size(); + if (file_size_orig % 16 != 0) + { + trace("We need to adjust the file size\n"); + file_size_orig = ((file_size_orig / 16) + 1) * 16; + } Does anybody know if '16' is indeed

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates

2009-12-22 Thread Owen Rudge
Hi Paul, Would something like this be ok: file_size_orig = get_file_size(); + if (file_size_orig % 16 != 0) + { + trace("We need to adjust the file size\n"); + file_size_orig = ((file_size_orig / 16) + 1) * 16; + } Does anybody know if '16' is indeed the alignment needed? The ImageHlp routin

Re: [1/5] WineD3D: Revert the GL usage confusion

2009-12-22 Thread Roderick Colenbrander
On Tue, Dec 22, 2009 at 4:51 PM, Stefan Dösinger wrote: > We had a discussion in wine-devel a few days ago about which GL usage is > better. The red book also agrees with the GL wiki, but the GL 3.0 spec uses > the confusing language the extension used. > > In my performance testing there is no

Re: [2/5] WineD3D: Use unload instead of duplicating buffer remove code

2009-12-22 Thread Henri Verbeet
2009/12/22 Stefan Dösinger : > -HeapFree(GetProcessHeap(), 0, This->conversion_shift); > +IWineD3DBuffer_UnLoad(iface); > +This->flags &= ~WINED3D_BUFFER_CREATEBO; UnLoad() doesn't free "conversion_shift".

Re: Parser for cmd language?

2009-12-22 Thread Dan Kegel
I'm getting ready to propose this as a project for students at UCLA. See http://kegel.com/wine/sweng/2010/ Comments welcome (especially from anyone who knows our current cmd implementation).

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates

2009-12-22 Thread Paul Vriens
On 12/04/2009 05:11 PM, Owen Rudge wrote: --- dlls/imagehlp/tests/integrity.c | 68 +++ 1 files changed, 54 insertions(+), 14 deletions(-) Hi Owen, This test fails on Win95 but only because the size of the dll is not aligned on a 16byte boundary. Using a

Re: [1/2] wininet: Always set last error in HttpSendRequest{,Ex}.

2009-12-22 Thread Paul Vriens
On 12/21/2009 11:13 AM, Hans Leidekker wrote: +SetLastError(0xdeadbeef); r = HttpSendRequest(hr, NULL, 0, NULL, 0); +error = GetLastError(); ok(r, "HttpSendRequest failed\n"); +ok(error == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", error); Hi Hans, This one intr