Re: Conformance tess for cmd?

2009-12-18 Thread Eric Pouech
Austin English a écrit : On Fri, Dec 18, 2009 at 11:09 PM, Dan Kegel wrote: Has anyone written conformance tests for cmd? I imagine they'd mostly just be a bunch of batch files with matching expected output files. I started to add some to appinstall, but haven't found the time. One t

Re: Parser for cmd language?

2009-12-18 Thread Eric Pouech
Dan Kegel a écrit : On Thu, Dec 17, 2009 at 8:32 PM, Dan Kegel wrote: bison it is, then. I'm thinking of having some ucla students do this, and it occurred to me that using "ply" might be a good way to start. ply is a nice lex/yacc implementation written in python that sounds good for

Re: Conformance tess for cmd?

2009-12-18 Thread Austin English
On Fri, Dec 18, 2009 at 11:09 PM, Dan Kegel wrote: > Has anyone written conformance tests for cmd? > > I imagine they'd mostly just be a bunch of batch files with > matching expected output files. I started to add some to appinstall, but haven't found the time. One thing that makes it a bit hard

Re: Parser for cmd language?

2009-12-18 Thread Dan Kegel
On Fri, Dec 18, 2009 at 6:07 PM, Steven Edwards wrote: > This suggestion will most likely get null'd as it has before but since > there are still patches accepted by ReactOS developers from time to > time, it would seem to make more since to me to just prepackage a > winelib build or binary build

Conformance tess for cmd?

2009-12-18 Thread Dan Kegel
Has anyone written conformance tests for cmd? I imagine they'd mostly just be a bunch of batch files with matching expected output files.

Re: Parser for cmd language?

2009-12-18 Thread Steven Edwards
On Fri, Dec 18, 2009 at 8:01 PM, Dan Kegel wrote: > Oh, and http://ss64.com/nt/syntax.html seems like a nice summary > of the language. This suggestion will most likely get null'd as it has before but since there are still patches accepted by ReactOS developers from time to time, it would seem to

Re: [PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

2009-12-18 Thread Amine Khaldi
Not really, it's up to you too. This is essentially a style-only change. Alexandre generally frowns on these, but reluctantly accepts them if the existing style is horrible, or if you're actively involved in the code being modified. Neither appears to be true here. This is a helpful hint to a

Re: [PATCH] inetcomm/smtptransport.c : Fix a typo ?

2009-12-18 Thread Amine Khaldi
Hi Amine, Hi Juan, Um, it's called a prototype, and it's needed to compile smtptransport.c. Have you tested this patch at all? I knew it was a prototype, I just thought it was left over, as it wasn't at the top of the file, and I saw no other prototype in that file. As for testing,

Re: [PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

2009-12-18 Thread Amine Khaldi
It makes the code use one less variable. I don't see how is this dubious, but I understand that it's trivial. Yes, at the cost of potentially less readability, or, depending on the compile settings, a little more difficulty in checking whether the function succeeded. I don't see that the

Re: [PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

2009-12-18 Thread Amine Khaldi
Hi Amine, Hi Juan, this patch has no functional benefit. For example, -HRESULT hr; TRACE("\n"); -hr = SMTPTransport_ParseResponse(This, pBuffer,&response); -if (FAILED(hr)) +if (FAILED(SMTPTransport_ParseResponse(This, pBuffer,&response))) This has the dubious ben

Re: inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

2009-12-18 Thread Amine Khaldi
Hey Chip, I think he's using Clang. I've seen him on the LLVM bugzilla. He's waiting for someone (e.g. me) to fix the bugs that prevent Wine from being compiled with Clang. That's right. BTW, if and when you find a bug using Clang, be sure to put "(Clang/LLVM)" in the title--or at least menti

Re: inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

2009-12-18 Thread Amine Khaldi
Out of curiosity, what tool are you using to find these bugs? Clang. WBR, Amine.

Re: hlink/hlink_main.c : Remove an unneeded assignment.

2009-12-18 Thread Amine Khaldi
Hi Amine, Hi Jacek, r = register_clsid(&CLSID_StdHlink); if (SUCCEEDED(r)) -r = register_clsid(&CLSID_StdHlinkBrowseContext); +register_clsid(&CLSID_StdHlinkBrowseContext); return S_OK; In this case the correct fix is to return r. Please be more careful

Re: Parser for cmd language?

2009-12-18 Thread Dan Kegel
On Fri, Dec 18, 2009 at 5:00 PM, Dan Kegel wrote: > Maybe I'll noodle around with ply and see if I can implement a > subset of cmd's language with it.  Here's a tiny toy start: > http://kegel.com/wine/cmd.py > > ply home page: > http://www.dabeaz.com/ply/ > example of use of ply in compiler course

Re: Parser for cmd language?

2009-12-18 Thread Dan Kegel
On Thu, Dec 17, 2009 at 8:32 PM, Dan Kegel wrote: > bison it is, then. I'm thinking of having some ucla students do this, and it occurred to me that using "ply" might be a good way to start. ply is a nice lex/yacc implementation written in python that sounds good for prototyping. Once the gramme

re: msi: fix leak in cond.y

2009-12-18 Thread Nate Gallaher
I should have mentioned in the commit message that this approach took heavy inspiration from the solution to the same problem in sql.y.

re: daily 16 bit tests?

2009-12-18 Thread Dan Kegel
Joerg-Cyril.Hoehle wrote: > there have been a number of 16bit changes lately (accompanied by a > few regressions) and I've been wondering whether some bot somewhere > has been setup to execute 16 bit tests (I read that there's a 16bit > testsuite somewhere, not integrated into Wine tests)? The pro

Re: [usp10 5/6] Fix the ABC width calculations in ScriptPlace

2009-12-18 Thread Alexandre Julliard
Jason Green writes: > -if (pABC) TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", > pABC->abcA, pABC->abcB, pABC->abcC); > +if (pABC) > +{ > +ABC tmp; > + > + > +/* the compositie 'A' width is simply the padding from the first > glyph in the run */ > +get_

Re: [usp10 3/6] Fix the handling of spaces in ScriptBreak and ScriptShape

2009-12-18 Thread Alexandre Julliard
Jason Green writes: > commit 93b60cf8b1bcdabf008437b00cde35e162bdad1c > Author: Jason Green > Date: Thu Dec 17 10:56:39 2009 -0500 > > Fix the handling of spaces in ScriptBreak and ScriptShape > From: Eric van Beurden It doesn't work: ../../../tools/runtest -q -P wine -M usp10.dll -

Re: mapi32: add French translation

2009-12-18 Thread Frédéric Delanoy
OK... I'll fix that and resubmit this evening On Fri, Dec 18, 2009 at 1:53 AM, Nicolas Le Cam wrote: > Hi Frédéric, > > Using "absence" and "installé" in the same sentence doesn't sound right. > Something like "L'envoi de courriel a échoué car vous n'avez pas de > client mail MAPI installé." or "

Re: gcrypt windows build is done on linux, uses wine to run test suite

2009-12-18 Thread Jeff Zaroyko
On Fri, Dec 18, 2009 at 8:34 PM, Dan Kegel wrote: > Here's an interesting tidbit.  gcrypt's windows version's only > supported build environment is mingw on unix/linux, and > it relies on wine to run its test suite. > - Dan > Similar case for libsndfile, the maintainer has also contributed to Win

daily 16 bit tests?

2009-12-18 Thread Joerg-Cyril.Hoehle
Hi, there have been a number of 16bit changes lately (accompanied by a few regressions) and I've been wondering whether some bot somewhere has been setup to execute 16 bit tests (I read that there's a 16bit testsuite somewhere, not integrated into Wine tests)? I believe that would be a good thing

gcrypt windows build is done on linux, uses wine to run test suite

2009-12-18 Thread Dan Kegel
Here's an interesting tidbit. gcrypt's windows version's only supported build environment is mingw on unix/linux, and it relies on wine to run its test suite. - Dan -- Forwarded message -- From: Simon Josefsson Date: Thu, Dec 17, 2009 at 12:57 PM Subject: Re: gcrypt windows build