Re: [2/3] WineD3D: Properly release client storage memory

2009-12-14 Thread Henri Verbeet
2009/12/15 Stefan Dösinger : > +This->Flags &= ~(SFLAG_ALLOCATED | SFLAG_SRGBALLOCATED); That's pretty much what surface_force_reload() does.

Re: [PATCH 2/5] wined3d: Filter window messages generated by switching to fullscreen and back.

2009-12-14 Thread Henri Verbeet
2009/12/14 Stefan Dösinger : >> +    filter_messages = swapchain->filter_messages; >> +    swapchain->filter_messages = TRUE; >> + >>     SetWindowLongW(window, GWL_STYLE, style); >>     SetWindowLongW(window, GWL_EXSTYLE, exstyle); >>     SetWindowPos(window, HWND_TOP, 0, 0, w, h, SWP_FRAMECHANGED

Re: [3/3] WineD3D: Don't enable render_to_fbo on single buffered swapchains

2009-12-14 Thread Henri Verbeet
2009/12/15 Stefan Dösinger : > +&& present_parameters->BackBufferCount > 0 "BackBufferCount" is unsigned.

Re: winetricks directx testers needed

2009-12-14 Thread Austin English
On Tue, Dec 15, 2009 at 1:09 AM, Tom Wickline wrote: > Howdy, > > From memory I know dxdiag.exe wont work on Linux if its set to XP the only > way to get it to work properly is set the windows version to 2k. As for MAC > I'm not sure, you will need another sucker.. I mean guinea pig to test there

Re: winetricks directx testers needed

2009-12-14 Thread Tom Wickline
Howdy, >From memory I know dxdiag.exe wont work on Linux if its set to XP the only way to get it to work properly is set the windows version to 2k. As for MAC I'm not sure, you will need another sucker.. I mean guinea pig to test there :) Maybe have two versions, one for Linux and one for Mac? C

winetricks directx testers needed

2009-12-14 Thread Austin English
Howdy all, I e-mailed wine-users a few days ago, but had no volunteers. I know most of you here aren't the target audience for using winetricks directx9, but since neither Dan or I game much, we need a guinea pig ;-). Long story short, someone complained that 'winetricks directx9' crashes on OS X

Re: Edit control messages through Comctl32 v6 module

2009-12-14 Thread Nikolay Sivov
On 12/14/2009 19:56, André Hentschel wrote: Nikolay Sivov schrieb: Alexandre told me, that he just wants to see that this test works, but its not necessary to add it to wine. I ran into to some issues where windows needed a signed dll to use a manifest with it. I dont know how to manage that

Re: Test suite under Intel drivers

2009-12-14 Thread Francois Gouget
On Wed, 9 Dec 2009, Jaime Rave wrote: [...] > Hi wine devs, I'm writing you to ask some help to try to fix the the Wine > test suite under the Intel drivers. I have already fill a bug with > freedesktop but they are asking for some wine devs to give them some openGL > test to add it to the piglit t

Re: [PATCH 2/5] wined3d: Filter window messages generated by switching to fullscreen and back.

2009-12-14 Thread Stefan Dösinger
This looks correct to me, I'm just asking to make sure I understand this correctly: > +filter_messages = swapchain->filter_messages; > +swapchain->filter_messages = TRUE; > + > SetWindowLongW(window, GWL_STYLE, style); > SetWindowLongW(window, GWL_EXSTYLE, exstyle); > SetWindo

Re: [PATCH 2/2] mmdevapi: Add more tests

2009-12-14 Thread Maarten Lankhorst
Hi Paul, Paul Vriens schreef: On 12/14/2009 10:09 AM, Maarten Lankhorst wrote: +hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(mme, eRender, eMultimedia,&dev); +ok(hr == S_OK, "GetDefaultAudioEndpoint failed: 0x%08x\n", hr); +if (hr != S_OK) +{ +skip("GetDefaultAudioE

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.

2009-12-14 Thread Alexandre Julliard
Eric Pouech writes: > Alexandre Julliard a écrit : >> Module: wine >> Branch: master >> Commit: dcec342b50524562844f64d43d423ed2c83c1f97 >> URL: >> http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43d423ed2c83c1f97 >> >> Author: Alexandre Julliard >> Date: Fri Dec 1

Re: [PATCH 14/14] [WineDbg]: fix some casts issues on 64bit platform

2009-12-14 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech writes: diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y index 855407f..7ed6307 100644 --- a/programs/winedbg/dbg.y +++ b/programs/winedbg/dbg.y @@ -281,9 +281,9 @@ info_command: | tINFO tCLASS { info_win32_class(NULL, N

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.

2009-12-14 Thread Eric Pouech
Alexandre Julliard a écrit : Module: wine Branch: master Commit: dcec342b50524562844f64d43d423ed2c83c1f97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43d423ed2c83c1f97 Author: Alexandre Julliard Date: Fri Dec 11 14:52:28 2009 +0100 user32: Add a thunking

Re: [PATCH 2/2] mmdevapi: Add more tests

2009-12-14 Thread Paul Vriens
On 12/14/2009 10:09 AM, Maarten Lankhorst wrote: +hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(mme, eRender, eMultimedia,&dev); +ok(hr == S_OK, "GetDefaultAudioEndpoint failed: 0x%08x\n", hr); +if (hr != S_OK) +{ +skip("GetDefaultAudioEndpoint returns 0x%08x, skipping

Re: [usrmarshal] Check the actual size of safe arrays marshaled, not just projected size.

2009-12-14 Thread Paul Vriens
On 12/11/2009 04:25 PM, Jeremy White wrote: --- dlls/oleaut32/tests/usrmarshal.c | 41 +++-- 1 files changed, 25 insertions(+), 16 deletions(-) Hi Jeremy, This one looks like to have introduced some test failures on Win9x/WinME: http://test.winehq.org/dat

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.

2009-12-14 Thread Paul Vriens
On 12/14/2009 11:45 AM, Hans Leidekker wrote: On Monday 14 December 2009 10:41:12 Paul Vriens wrote: I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above: https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 I wrote those tests originally, so I'll f

RE: WineTestBot

2009-12-14 Thread Greg Geldorp
Hi Andre, > From: Andre Hentschel > > Some Questions/Suggestions by me: > - Are the VMs running on Computer at VMWare, on some Internetserver or at your home? I have a personal box (Dell SC1435, Quad core AMD Opteron @ 2.2 GHz, 16GB RAM) collocated at a large Dutch ISP. WineTestBot and the test V

Re: Rob Shearman : msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit.

2009-12-14 Thread Nikolay Sivov
On 12/14/2009 20:35, Rob Shearman wrote: 2009/12/14 Nikolay Sivov: On 12/14/2009 18:51, Alexandre Julliard wrote: Module: wine Branch: master Commit: c20868e0a2f7af909cf8af2877ae8b024fa6d11e URL: http://source.winehq.org/git/wine.git/?a=commit;h=c20868e0a2f7af909cf8af2877ae8b024fa6

Re: Rob Shearman : msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit.

2009-12-14 Thread Rob Shearman
2009/12/14 Nikolay Sivov : > On 12/14/2009 18:51, Alexandre Julliard wrote: >> >> Module: wine >> Branch: master >> Commit: c20868e0a2f7af909cf8af2877ae8b024fa6d11e >> URL: >>  http://source.winehq.org/git/wine.git/?a=commit;h=c20868e0a2f7af909cf8af2877ae8b024fa6d11e >> >> Author: Rob Shearman >> D

Re: Edit control messages through Comctl32 v6 module

2009-12-14 Thread André Hentschel
Nikolay Sivov schrieb: > On 12/14/2009 18:19, André Hentschel wrote: >> Roderick Colenbrander schrieb: >> >>> On Sun, Dec 13, 2009 at 1:46 PM, Nikolay Sivov >>> wrote: >>> On 12/13/2009 15:15, Roderick Colenbrander wrote: >>> The main test which AJ suggested would be t

Re: Rob Shearman : msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit.

2009-12-14 Thread Nikolay Sivov
On 12/14/2009 18:51, Alexandre Julliard wrote: Module: wine Branch: master Commit: c20868e0a2f7af909cf8af2877ae8b024fa6d11e URL: http://source.winehq.org/git/wine.git/?a=commit;h=c20868e0a2f7af909cf8af2877ae8b024fa6d11e Author: Rob Shearman Date: Mon Dec 14 14:13:57 2009 + msvcrt: Fre

Re: Edit control messages through Comctl32 v6 module

2009-12-14 Thread Nikolay Sivov
On 12/14/2009 18:19, André Hentschel wrote: Roderick Colenbrander schrieb: On Sun, Dec 13, 2009 at 1:46 PM, Nikolay Sivov wrote: On 12/13/2009 15:15, Roderick Colenbrander wrote: The main test which AJ suggested would be to 'force' native user32 to call RegisterClassNameW. T

WineTestBot

2009-12-14 Thread André Hentschel
Hi, First i have to thank Mr. Geldorp for this really great gift :) Some Questions/Suggestions by me: - Are the VMs running on Computer at VMWare, on some Internetserver or at your home? - IMO you should add pruning to your script, we are at about 120 tests and i guess old ones can be deleted - W

Re: meaning of "Hardware" field in bugzilla? what about ARM?

2009-12-14 Thread André Hentschel
Seth Shelnutt schrieb: > I'm curious what the level of ARM support is or the progress is? Is > there a "todo" list somewhere? I searched the wine site but besides > turning up mailing list threads I didn't see much info on ARM, only > discussions. I haven't been following this, but would like to se

Re: msi: Add binary search to the string table.

2009-12-14 Thread Alexandre Julliard
Hans Leidekker writes: > On Monday 14 December 2009 16:00:21 Henri Verbeet wrote: > >> Does it really make sense to maintain both a hash table and a binary >> search tree? > > Theoretically the hash lookup is faster for small numbers of strings, > but I haven't benchmarked it. Alexandre suggested

Re: msi: Add binary search to the string table.

2009-12-14 Thread Hans Leidekker
On Monday 14 December 2009 16:00:21 Henri Verbeet wrote: > Does it really make sense to maintain both a hash table and a binary > search tree? Theoretically the hash lookup is faster for small numbers of strings, but I haven't benchmarked it. Alexandre suggested to keep the hash IIRC. -Hans

Re: Edit control messages through Comctl32 v6 module

2009-12-14 Thread André Hentschel
Roderick Colenbrander schrieb: > On Sun, Dec 13, 2009 at 1:46 PM, Nikolay Sivov wrote: >> On 12/13/2009 15:15, Roderick Colenbrander wrote: > The main test which AJ suggested would be to 'force' native user32 to > call RegisterClassNameW. There would be a dummy dll containing a > Regis

re: ntdll: Ignore the hole in the FILE_PIPE_WAIT_FOR_BUFFER structure passed into NtFsControlFile before writing the structure to the server.

2009-12-14 Thread Dan Kegel
Rob's patch is the most precise solution. The macro should probably go in a .h file as it might be useful elsewhere. Alternately I can suppress all errors from functions like server_ioctl_file but it'd be better to just mark the holes as defined. Thanks, Rob!

Re: msi: Add binary search to the string table.

2009-12-14 Thread Henri Verbeet
2009/12/14 Hans Leidekker : > Addresses a performance bottleneck in the Visual Studio 2005 installer. > See http://bugs.winehq.org/show_bug.cgi?id=14168 Does it really make sense to maintain both a hash table and a binary search tree?

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.

2009-12-14 Thread Rob Shearman
2009/12/14 Hans Leidekker : > On Monday 14 December 2009 10:41:12 Paul Vriens wrote: > >> I took the liberty of running these tests on winetestbot. It shows two >> errors for W2K and above: >> >> https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 > > I wrote those tests originally, so I'll fix it

Re: weird and funky things happen when viewing guimark in ie6 in wine...

2009-12-14 Thread Steven Edwards
On Sun, Dec 13, 2009 at 10:57 PM, Austin English wrote: >> Building font metrics. This may take some time... >> Font metrics: 0.0% done >> ... >> and the whole long font metric rebuilding process, which should >> never be happening anymore for local X servers (right?). > > It still occurs on OS X

Re: (resend)shlwapi: implement SHPropertyBag_ReadLONG

2009-12-14 Thread Aric Stewart
You are probibly right. What is an example of a variant type that cannot be converted to I4 so that I can write a test? thanks! -aric Jacek Caban wrote: Hi Aric, On 12/11/09 10:44 PM, Aric Stewart wrote: --- dlls/shlwapi/ordinal.c| 25 + dlls/shlwapi/shlwapi.s

Re: [PATCH 14/14] [WineDbg]: fix some casts issues on 64bit platform

2009-12-14 Thread Alexandre Julliard
Eric Pouech writes: > diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y > index 855407f..7ed6307 100644 > --- a/programs/winedbg/dbg.y > +++ b/programs/winedbg/dbg.y > @@ -281,9 +281,9 @@ info_command: > | tINFO tCLASS { info_win32_class(NULL, NULL); } > | tINFO

Re: ws2_32: Fix allocating a hostent with no h_aliases list.

2009-12-14 Thread Alexandre Julliard
Erich Hoover writes: > @@ -4616,11 +4620,18 @@ static struct WS_hostent *WS_create_he(char *name, > int aliases, int addresses, i > sizeof(char *)*aliases + > sizeof(char *)*addresses); > > -/* Place addresses in the allocated memory, making sure to have e

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.

2009-12-14 Thread Paul Vriens
On 12/14/2009 11:45 AM, Hans Leidekker wrote: On Monday 14 December 2009 10:41:12 Paul Vriens wrote: I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above: https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 I wrote those tests originally, so I'll f

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.

2009-12-14 Thread Hans Leidekker
On Monday 14 December 2009 10:41:12 Paul Vriens wrote: > I took the liberty of running these tests on winetestbot. It shows two > errors for W2K and above: > > https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 I wrote those tests originally, so I'll fix it :) -Hans

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.

2009-12-14 Thread Paul Vriens
Hi Rob, I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above: https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 -- Cheers, Paul.