Re: Leaks galore!

2009-12-09 Thread Vincent Povirk
On Wed, Dec 9, 2009 at 11:52 PM, James Hawkins wrote: > Oops, spoke too soon.  Thanks for fixing the problem Vincent!  I guess > we can close http://bugs.winehq.org/show_bug.cgi?id=20920 now. > > James > That wasn't me; I just removed the fixed code afterwards. ;) -- Vincent Povirk

Re: Leaks galore!

2009-12-09 Thread James Hawkins
On Wed, Dec 9, 2009 at 9:51 PM, James Hawkins wrote: > On Wed, Dec 9, 2009 at 9:01 PM, Dan Kegel wrote: >> On Sat, Dec 5, 2009 at 7:39 AM, Dan Kegel wrote: >>> With those changes, I now see 457 non-leak errors, >>> (~134 of which are due to the fresh regression >>> http://bugs.winehq.org/show_bu

Re: Leaks galore!

2009-12-09 Thread James Hawkins
On Wed, Dec 9, 2009 at 9:01 PM, Dan Kegel wrote: > On Sat, Dec 5, 2009 at 7:39 AM, Dan Kegel wrote: >> With those changes, I now see 457 non-leak errors, >> (~134 of which are due to the fresh regression >> http://bugs.winehq.org/show_bug.cgi?id=20920 ) >> and 1560 leak errors >> (~300 of which a

Re: Leaks galore!

2009-12-09 Thread Dan Kegel
On Sat, Dec 5, 2009 at 7:39 AM, Dan Kegel wrote: > With those changes, I now see 457 non-leak errors, > (~134 of which are due to the fresh regression > http://bugs.winehq.org/show_bug.cgi?id=20920 ) > and 1560 leak errors > (~300 of which are due to ntlm_auth, which I'm still > trying to suppress

Test suite under Intel drivers

2009-12-09 Thread Jaime Rave
Hi wine devs, I'm writing you to ask some help to try to fix the the Wine test suite under the Intel drivers. I have already fill a bug with freedesktop but they are asking for some wine devs to give them some openGL test to add it to the piglit testcases. The bug is: http://bugs.freedesktop.org/s

Re: Wine performance improvement

2009-12-09 Thread Wolfram Sang
Stefan Dösinger wrote: Am 09.12.2009 um 09:36 schrieb 임은지: Thank you for your comments. I will cleanup the patch as you suggested and send it. Did you contact the kernel maintainers regarding the kernel side of your changes? I think including the Wine patch doesn't make sense until the kernel d

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Ken Thomases
On Dec 9, 2009, at 1:34 PM, Ken Thomases wrote: So, I'm making a new proposal: the Mac formats region will be used to set LANG unconditionally. (Passing 1 for the third argument to setenv() rather than 0.) The current code for overwriting lcid_LC_MESSAGES will be tweaked. Instead of look

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Charles Davis
Ken Thomases wrote: > On Dec 3, 2009, at 11:27 AM, Ken Thomases wrote: > >> I propose the following (in pseudocode): >> >> mac_formats_locale = CFLocaleGetIdentifier( CFLocaleCopyCurrent() ); >> mac_language = CFArrayGetValueAtIndex( >> CFBundleCopyLocalizationsForPreferences( >> CFLocaleCopyAvail

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Ken Thomases
On Dec 3, 2009, at 11:27 AM, Ken Thomases wrote: I propose the following (in pseudocode): mac_formats_locale = CFLocaleGetIdentifier( CFLocaleCopyCurrent() ); mac_language = CFArrayGetValueAtIndex ( CFBundleCopyLocalizationsForPreferences ( CFLocaleCopyAvailableLocaleIdentifiers(), NULL ),

Regression on Tuesday Dec 8

2009-12-09 Thread Susan Cragin
I was installing Dragon NaturallySpeaking on Tuesday with git and noticed that it was very slow to load. In addition, the "automatic" registration doesn't work as well as it used to. The link to the Scansoft site, to generate the code, does not work. Regression test? Sigh.

Re: [1/5] ole32: Change the base IStorage filename to a pointer type.

2009-12-09 Thread Paul Vriens
On 12/09/2009 05:43 PM, Vincent Povirk wrote: On Wed, Dec 9, 2009 at 8:26 AM, Paul Vriens wrote: These tests currently crash on Win9x/WinME due . I rewrote that test to just use A-functions but there are loads of lstrcmpW tests that of course always fail on Win9x (not implemented). I always f

Re: libs/wine: don't try to read() a directory

2009-12-09 Thread Dan Kegel
On Wed, Dec 9, 2009 at 5:06 AM, Alexandre Julliard wrote: >> Fixes http://bugs.winehq.org/show_bug.cgi?id=20942 > > Introducing an fd leak to fix a Valgrind warning is not much of an > improvement ;-) d'oh!

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Ken Thomases
On Dec 8, 2009, at 6:39 AM, > wrote: Ken Thomases wrote: This results in the order I previously described: LC_ALL LC_* from the original environment Mac OS X settings LANG In other words, LANG is completely ignored, since there presumably won't be a Mac without settings. Correct. LANG i

Re: [1/5] ole32: Change the base IStorage filename to a pointer type.

2009-12-09 Thread Vincent Povirk
On Wed, Dec 9, 2009 at 8:26 AM, Paul Vriens wrote: > These tests currently crash on Win9x/WinME due . I rewrote that test to just > use A-functions but there are loads of lstrcmpW tests that of course always > fail on Win9x (not implemented). I always forget about that. Sorry. Should I write a pa

Re: [PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W

2009-12-09 Thread Maarten Lankhorst
Hi AJ, Alexandre Julliard schreef: Maarten Lankhorst writes: +data.DataFlow = ppd->DataFlow; +len = strlen(ppd->DeviceName)+1; +data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len); +if (!data.DeviceName) +return E_OUTOFMEMORY; +MultiByteToWideChar(CP_ACP, 0, pp

Re: [PATCH 1/2] dsound: Only initialize 1 guid for capture and renderer

2009-12-09 Thread Maarten Lankhorst
Hi, Alexandre Julliard schreef: Maarten Lankhorst writes: @@ -355,8 +357,8 @@ HRESULT WINAPI DirectSoundEnumerateW( if (devs > 0) { if (GetDeviceID(&DSDEVID_DefaultPlayback, &guid) == DS_OK) { static const WCHAR empty[] = { 0 }; - for (wod = 0; wod < dev

Re: [1/5] ole32: Change the base IStorage filename to a pointer type.

2009-12-09 Thread Paul Vriens
On 12/07/2009 10:17 PM, Vincent Povirk wrote: +/* Stat always returns the full path, even for files opened with a relative path. */ +GetCurrentDirectoryW(MAX_PATH, prev_dir); + +GetTempPathW(MAX_PATH, temp); + +SetCurrentDirectoryW(temp); + +GetFullPathNameW(filename, MAX_PAT

RE: Cruft left behind by tests

2009-12-09 Thread Greg Geldorp
> From: Maarten LankhorstSent: woensdag 9 december 2009 13:03 > > 2009/12/9 Greg Geldorp : > > During WineConf we briefly discussed files/registry keys left behind by running winetest.exe on Windows machines. I promised to look at that and then promptly forgot about it. Anyway, this is the list of

Re: libs/wine: don't try to read() a directory

2009-12-09 Thread Alexandre Julliard
Dan Kegel writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=20942 Introducing an fd leak to fix a Valgrind warning is not much of an improvement ;-) -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/2] dsound: Only initialize 1 guid for capture and renderer

2009-12-09 Thread Alexandre Julliard
Maarten Lankhorst writes: > @@ -355,8 +357,8 @@ HRESULT WINAPI DirectSoundEnumerateW( > if (devs > 0) { > if (GetDeviceID(&DSDEVID_DefaultPlayback, &guid) == DS_OK) { > static const WCHAR empty[] = { 0 }; > - for (wod = 0; wod < devs; ++wod) { > -if

Re: wineserver: Use existing file permissions as base for applying ACLs, change mapping logic

2009-12-09 Thread Alexandre Julliard
Paul Chitescu writes: > Changelog: > wineserver: Use existing file permissions as base for applying ACLs, > change > mapping logic. > > ACLs are applied over existing permissions. An ACCESS_ALLOWED_ACE by itself > will never reduce permissions. This doesn't make sense to me. A security

Re: [PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W

2009-12-09 Thread Alexandre Julliard
Maarten Lankhorst writes: > +data.DataFlow = ppd->DataFlow; > +len = strlen(ppd->DeviceName)+1; > +data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len); > +if (!data.DeviceName) > +return E_OUTOFMEMORY; > +MultiByteToWideChar(CP_ACP, 0, ppd->DeviceName, -1, data.Devic

Re: shdocvw: Implement refresh in webbbrowser.c

2009-12-09 Thread Jacek Caban
Hi David, David Anderson wrote: Implements WebBrowser_Refresh in shdocvw/webbrowser.c . Now a VB app with a 'refresh' button works, refreshing a web page displayed by gecko with the current web page (it used to crash the app because refresh returned an E_NOTIMPL). Tested with linux winetest.

Re: Cruft left behind by tests

2009-12-09 Thread Maarten Lankhorst
Hoi, 2009/12/9 Greg Geldorp : > During WineConf we briefly discussed files/registry keys left behind by > running winetest.exe on Windows machines. I promised to look at that and then > promptly forgot about it. Anyway, this is the list of files that get left > behind when running the tests on

Cruft left behind by tests

2009-12-09 Thread Greg Geldorp
Hi Dmitry, During WineConf we briefly discussed files/registry keys left behind by running winetest.exe on Windows machines. I promised to look at that and then promptly forgot about it. Anyway, this is the list of files that get left behind when running the tests on a WinXP machine: C:\Custom

Re: ntdll/tests: Fix a memory leak.

2009-12-09 Thread Paul Vriens
On 12/08/2009 11:44 AM, Hans Leidekker wrote: CloseHandle( dir ); +pRtlFreeUnicodeString(&nameW ); This one makes the tests crash on 64bit Windows 7. Any idea why? The NtQueryDirectoryFile() just before that fails with ERROR_NO_MORE_ITEMS btw, but that's also true on my 32bit Win7 b

Re: Wine performance improvement

2009-12-09 Thread Stefan Dösinger
Am 09.12.2009 um 09:36 schrieb 임은지: > Thank you for your comments. > I will cleanup the patch as you suggested and send it. Did you contact the kernel maintainers regarding the kernel side of your changes? I think including the Wine patch doesn't make sense until the kernel developers accept the

Re: Wine performance improvement

2009-12-09 Thread 임은지
Dan Kegel wrote: > > > Interesting!    Clearly a long ways off from production-ready, but > it's fun to see somebody trying this. > > A few notes: > > Please clean up the patch a bit to remove lines like this: > +//FIXME("handle : %ld \n", handle); > and extra files like > dlls/ws2_32/tests/test.sh