Re: Silencing RtlNtStatusToDosErrorNoTeb() a bit

2009-12-01 Thread Dmitry Timoshkov
"Wolfram Sang" wrote: Another solution might be to define, let's say, ERROR_WINE_FIXME for all real fixmes and convert them to ERROR_MR_MID_NOT_FOUND. If a FIXME is not appropriate it should be replaced by a WARN. Although most of the places it's used are the places with missing functionality

Silencing RtlNtStatusToDosErrorNoTeb() a bit

2009-12-01 Thread Wolfram Sang
Hi, while debugging an application (Project One, available at [1]), I noticed that wine (today's git) throws a lot of these fixmes: fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109 Looking around, I found this page[2] stating that ERROR_MR_MID_NOT_FOUND is an expected return value

Re: New winetricks 20091125: new verbs ie7, alsa, fbo, pbuffer, ...

2009-12-01 Thread Austin English
On Fri, Nov 27, 2009 at 3:57 PM, Louis Lenders wrote: > Dan Kegel kegel.com> writes: > >> >> Pie's in the oven, time for another winetricks release. >> > > Could it be possible to "fix" mdac as well?  Because of wine now having a more > or less stubbed oledb32.dll, apps that need mdac don't run p

Re: [3/5] imagehlp: Implement ImageAddCertificate

2009-12-01 Thread Owen Rudge
The virtual address is not necessarily the same as the disk offset. Actually, it seems that the security directory is one of the few places where a disk offset is intentionally used. Trying to compensate for the virtual address results in failure in this case. I have been amending the code t

Re: Introducing WineTestBot

2009-12-01 Thread Jeremy White
>> Let me be the first to thank Ge for this awesome piece of work. > > Seconded! It's really quite slick, for anyone that hasn't used it. It's a very nice way to quickly feel comfortable that the test you just wrote actually works in more places than just your mind. Thanks again! Cheers, Jere

Re: [PATCH] mshtml: check for NULL return from allocations

2009-12-01 Thread Jacek Caban
Hi Marcus, Marcus Meissner wrote: Hi, Coverity thinks we miss NULL checks and yes, we do. Added some. (...) -wstrbuf_init(&buf); +if (!wstrbuf_init(&buf)) +return E_OUTOFMEMORY; range_to_string(This, &buf); -if(buf.buf) -*p = SysAllocString(buf.buf); +

Re: [2/4] ntdll: add support for the HEAP_FREE_CHECKING_ENABLED style of heap overrun detection.

2009-12-01 Thread Dan Kegel
On Tue, Dec 1, 2009 at 11:22 AM, Alexandre Julliard wrote: > Validation should only happen when explicitly requested. Should I submit a separate patch to remove the existing small arena validation from RtlFreeHeap and RtlReAllocateHeap, then? Or is that how Windows XP behaved (validating small h

Re: [2/4] ntdll: add support for the HEAP_FREE_CHECKING_ENABLED style of heap overrun detection.

2009-12-01 Thread Dan Kegel
On Tue, Dec 1, 2009 at 11:22 AM, Alexandre Julliard wrote: > You should create your own heap with checking enabled so that it can be > tested in all cases. I couldn't figure out how to do that on Windows Vista, but I can sure do it at least for Wine.

Re: [PATCH 2/2] jscript: Added lastIndex tests.

2009-12-01 Thread Jacek Caban
Paul Vriens wrote: On 12/01/2009 08:11 PM, Jacek Caban wrote: Paul Vriens wrote: On 11/30/2009 09:12 PM, Jacek Caban wrote: --- dlls/jscript/tests/regexp.js | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) Hi Jacek, This one introduces test

Re: [PATCH 2/2] jscript: Added lastIndex tests.

2009-12-01 Thread Paul Vriens
On 12/01/2009 08:11 PM, Jacek Caban wrote: Paul Vriens wrote: On 11/30/2009 09:12 PM, Jacek Caban wrote: --- dlls/jscript/tests/regexp.js | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) Hi Jacek, This one introduces test failures on Vista+

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-01 Thread Gert van den Berg
On Tue, Dec 1, 2009 at 06:12, Ken Thomases wrote: > On Nov 30, 2009, at 9:34 PM, James McKenzie wrote: >> >> The idea behind most of the MacIntosh 'magic' is that the user is >> deliberately oblivous to this. > > I agree that Wine (well, anything) should meet the user's expectations > without the

Re: [2/4] ntdll: add support for the HEAP_FREE_CHECKING_ENABLED style of heap overrun detection.

2009-12-01 Thread Alexandre Julliard
Dan Kegel writes: > @@ -85,6 +85,7 @@ typedef struct > > #define ARENA_INUSE_FILLER 0x55 > #define ARENA_FREE_FILLER 0xaa > +#define ARENA_PAD_FILLER(address) (((int)(address) & 1) ? 0xee : 0xfe) Don't cast addresses to int. > +static PVOID HEAP_ValidateTail( const HEAP *heap, cons

Re: [PATCH 2/2] jscript: Added lastIndex tests.

2009-12-01 Thread Jacek Caban
Paul Vriens wrote: On 11/30/2009 09:12 PM, Jacek Caban wrote: --- dlls/jscript/tests/regexp.js | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) Hi Jacek, This one introduces test failures on Vista+ : http://test.winehq.org/data/tests/jscript

Slackware packager?

2009-12-01 Thread Jeremy White
So Adam Schreiber reports that he's no longer doing the Slackware packages. Is there an active Packager currently? If so, can you submit a patch to remove Adam's name and insert yours? If not, I guess I'll submit a patch to remove that column for Slackware... Cheers, Jeremy

Re: [PATCH 2/2] jscript: Added lastIndex tests.

2009-12-01 Thread Paul Vriens
On 11/30/2009 09:12 PM, Jacek Caban wrote: --- dlls/jscript/tests/regexp.js | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) Hi Jacek, This one introduces test failures on Vista+ : http://test.winehq.org/data/tests/jscript:run.html Could you

Re: work underway: Dependency on openal incoming

2009-12-01 Thread Alexandre Julliard
Charles Davis writes: > You can. The "proper" way to do this is to use the CFBundle API. First > you need to find the framework. Typically, it's in > /System/Library/Frameworks, but the user might have a custom OpenAL in > /Library/Frameworks or in $HOME/Library/Frameworks. Then we tack on the >

Re: [3/5] imagehlp: Implement ImageAddCertificate

2009-12-01 Thread Alexandre Julliard
Owen Rudge writes: > +sd = &nt_hdr.OptionalHeader.DataDirectory[IMAGE_FILE_SECURITY_DIRECTORY]; > + > +sd->Size = dwSize; > +sd->VirtualAddress = dwOfs; > + > +TRACE("size = %x addr = %x\n", sd->Size, sd->VirtualAddress); > + > +/* write the header back again */ > +count =

Re: work underway: Dependency on openal incoming

2009-12-01 Thread Charles Davis
Alexandre Julliard wrote: > Maarten Lankhorst writes: > >> Hello Alexandre, >> >> Alexandre Julliard schreef: >>> Openal missing at compile time or at runtime should be handled the same >>> way, i.e. by reporting no sound devices. It doesn't make sense to have >>> two different failure modes. >>>

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-12-01 Thread Alexandre Hardy
Thanks Paul, Right! Tried to implement it too fast! Other parts of the test code dereference the function pointer and I took my lead from there without checking properly. As far as the length goes, I don't really know much about UNC pathnames, so I'm not sure what exactly the result should be. I

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-12-01 Thread Paul Vriens
On 12/01/2009 11:52 AM, Paul Vriens wrote: On 12/01/2009 08:44 AM, Alexandre Hardy wrote: + length = (*pGetLongPathNameW)(unc_path,NULL,0); Why the brackets around *pGetLongPathNameW? + ok(length>0,"GetLongPathNameA: Failed on UNC Pathname (length=%d)\n",length); You called the W-function

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-12-01 Thread Paul Vriens
On 12/01/2009 08:44 AM, Alexandre Hardy wrote: +length = (*pGetLongPathNameW)(unc_path,NULL,0); Why the brackets around *pGetLongPathNameW? +ok(length>0,"GetLongPathNameA: Failed on UNC Pathname (length=%d)\n",length); You called the W-function so the ok text needs to be adjusted.

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-01 Thread Bruno Haible
Hi, As the author of the support for GNU gettext in MacOS X [1], I can explain the relation between the POSIX notion of locale and the MacOS X user preferences. POSIX:2008 [2] says: "All implementations shall define a locale as the default locale, to be invoked when no environment variables

Re: work underway: Dependency on openal incoming

2009-12-01 Thread Alexandre Julliard
Maarten Lankhorst writes: > Hello Alexandre, > > Alexandre Julliard schreef: >> Openal missing at compile time or at runtime should be handled the same >> way, i.e. by reporting no sound devices. It doesn't make sense to have >> two different failure modes. >> > Mac OSX can only link directly

RE: Introducing WineTestBot

2009-12-01 Thread Greg Geldorp
> From: Austin English [mailto:austinengl...@gmail.com] > > On a slightly related note, would it be possible to add a > 16-bit display VM? I finally got around to testing wine on a 16-bit > display again, and several things have regressed. It would be good to > test the testsuite on windows in that

Re: work underway: Dependency on openal incoming

2009-12-01 Thread Maarten Lankhorst
Hello Alexandre, Alexandre Julliard schreef: Maarten Lankhorst writes: Without openal at compile-time, dsound will still build, but report no sound devices found. Some games or other applications may refuse to run if no dsound devices are found, so its recommended that you build with opena

Re: work underway: Dependency on openal incoming

2009-12-01 Thread Alexandre Julliard
Maarten Lankhorst writes: > Without openal at compile-time, dsound will still build, but report no > sound devices found. Some games or other applications may refuse to > run if no dsound devices are found, so its recommended that you build > with openal. If openal is compiled in, but missing at

Re: [PATCH 4/5] dsound: Add support for OpenAL IDirectSoundCaptureBuffer

2009-12-01 Thread Maarten Lankhorst
Hi Chris, Chris Robinson schreef: On Monday 30 November 2009 1:56:20 pm Maarten Lankhorst wrote: +if (This->playing) +{ +pos2 = This->format->nSamplesPerSec / 100; +pos2 *= This->format->nBlockAlign; +pos2 += pos1; +if (!This->looping && pos2 > This->b