Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-23 Thread Austin Lund
2009/11/23 Paul Vriens : > > I'm curious how important a test on a FAT filesystem is. I'm not overly concerned, but the way it is at the moment, my test system will always fail with this test. > What happens when these tests are run on Wine with a FAT filesystem btw? I don't have such a system t

Re: [2/3] msi/tests: Test for SELECT table.column FROM table

2009-11-23 Thread Nikolay Sivov
On Tue, Nov 24, 2009 at 11:14 AM, Nathan Gallaher wrote: > Make sure that mixing table columns returns the expected > data. eg:  SELECT t1.action, t2.action FROM t1, t2 > should return distinct data. > > > +// Test that selection based on prefixing the column with the table +// actually s

RFC: visual.c:783: Test failed: DSTALPHA on frame buffer returned color 0x00ff0000, expected 0x000000ff

2009-11-23 Thread chris ahrendt
Ok going through and looking at the next failure in wine tests I found this one : If you look at the code its: 779 color = getPixelColor(device, 160, 120); 780 red = (color & 0x00ff) >> 16; 781 green = (color & 0xff00) >> 8; 782 blue = (color & 0x00ff);

Re: RFC : query.c d3d9 test...

2009-11-23 Thread chris ahrendt
Roderick Colenbrander wrote: > On Mon, Nov 23, 2009 at 9:23 PM, Stefan Dösinger > wrote: >> Am 23.11.2009 um 21:00 schrieb chris ahrendt: >>> The test fails with : >>> >>> query.c:224: Test failed: IDirect3DQuery9_GetData a 2nd time on a ended >>> query returned 0001 >> This is Windows, righ

Re: [PATCH] ole32: Some missing error checking in FileMonikerImpl_CommonPrefixWith (Coverity)

2009-11-23 Thread Rob Shearman
2009/11/23 Marcus Meissner : >     if(mkSys==MKSYS_FILEMONIKER){ >         HRESULT ret; > > -        CreateBindCtx(0,&pbind); > +        ret = CreateBindCtx(0,&pbind); > +        if (FAILED(ret)) > +            return ret; > >         /* create a string based on common part of the two paths */ > >

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-23 Thread Charles Davis
Ken Thomases wrote: > The call to setenv() has 0 (false) as its third parameter, so that LANG is > not overwritten. Then why does Wine not repsect the LANG setting on Mac OS X? I've seen it on wine-users. Wherever the problem lies, it lies elsewhere. (Yeah, I forgot what that third parameter to s

Re: RFC : query.c d3d9 test...

2009-11-23 Thread Stefan Dösinger
Am 23.11.2009 um 21:31 schrieb Roderick Colenbrander: > On Mon, Nov 23, 2009 at 9:23 PM, Stefan Dösinger > wrote: >> >> Am 23.11.2009 um 21:00 schrieb chris ahrendt: >>> The test fails with : >>> >>> query.c:224: Test failed: IDirect3DQuery9_GetData a 2nd time on a ended >>> query returned 0

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-23 Thread Ken Thomases
The call to setenv() has 0 (false) as its third parameter, so that LANG is not overwritten. -Ken On Nov 23, 2009, at 9:12 AM, Charles Davis wrote: > --- > dlls/kernel32/locale.c | 53 > +-- > 1 files changed, 28 insertions(+), 25 deletions(-) > > >

Re: msvcrt: Calculate floating point decimals in internally used long double precision.

2009-11-23 Thread Austin English
On Mon, Nov 23, 2009 at 2:43 PM, Gregor Schneider wrote: > This patch proposes to calculate the fp digits in scanf with the internally > used long double precision instead of simple float accuracy. > With the current implementation small errors are added with each calculation > step originating fr

Re: RFC : query.c d3d9 test...

2009-11-23 Thread Roderick Colenbrander
On Mon, Nov 23, 2009 at 9:23 PM, Stefan Dösinger wrote: > > Am 23.11.2009 um 21:00 schrieb chris ahrendt: >> The test fails with : >> >> query.c:224: Test failed: IDirect3DQuery9_GetData a 2nd time on a ended >> query returned 0001 > This is Windows, right? Which GPU/driver? > > My guess is t

Re: RFC : query.c d3d9 test...

2009-11-23 Thread Stefan Dösinger
Am 23.11.2009 um 21:00 schrieb chris ahrendt: > The test fails with : > > query.c:224: Test failed: IDirect3DQuery9_GetData a 2nd time on a ended query > returned 0001 This is Windows, right? Which GPU/driver? My guess is that its ok to modify the test to accept both results. Ie, ok(hr ==

RFC : query.c d3d9 test...

2009-11-23 Thread chris ahrendt
Looking at the wine test results for the following test: query.c in the d3d9 tests directory... hr = IDirect3DQuery9_GetData(pQuery, data, IDirect3DQuery9_GetDataSize(pQuery), D3DGETDATA_FLUSH); ok(hr == S_OK, "IDirect3DQuery9_GetData on a ended query returned %08x\n", hr); hr =

Re: Add .cvsignore entries for .fake files

2009-11-23 Thread Stephen Eilert
On Mon, Nov 23, 2009 at 7:07 AM, Paul Chitescu wrote: > On Friday 20 November 2009 05:43:48 pm Charles Davis wrote: > > Paul Chitescu wrote: > > > On Monday 16 November 2009 04:11:25 pm Paul Chitescu wrote: > > >> Changelog: > > >>Add .cvsignore entries for .fake files. > > > > > > What's wro

winmm: Don't stop parsing after MCI's alias keyword.

2009-11-23 Thread Joerg-Cyril.Hoehle
Dan Kegel wrote: >Looks like I ignore files that only contain leak errors: >You can still see the leaks in the full log, >http://kegel.com/wine/valgrind/logs/2009-11-19-08.35.log Ah, I was surprised to find no mention of winmm in the normal log ;) >should I stop ignoring modules that only have le

Re: winspool: Don't use 16Bit gdi.exe function for DeviceCapabilitiesA/W

2009-11-23 Thread Alexandre Julliard
Detlef Riekenberg writes: > -if (!GDI_CallDeviceCapabilities16) > -{ > -GDI_CallDeviceCapabilities16 = (void*)GetProcAddress( > GetModuleHandleA("gdi32"), > - (LPCSTR)104 ); > -if (!GDI_CallDeviceCapabilities16)

re: winmm: Don't stop parsing after MCI's alias keyword.

2009-11-23 Thread Dan Kegel
Joerg wrote: > I'm surprised that valgrind did not complain about the bug... Looks like I ignore files that only contain leak errors: http://code.google.com/p/winezeug/source/browse/trunk/valgrind/valgrind-split.pl on the theory that we're already overwhelmed dealing with non-leak errors. You can

Re: Add .cvsignore entries for .fake files

2009-11-23 Thread Alexandre Julliard
Paul Chitescu writes: > Can someone clarify if there's a relation between .gitignore and .cvsignore > files? Are they synchronized somehow? > > If .cvsignore is generated from .gitignore then there's something wrong. > > If .cvsignore files are stored separately in CVS then the patch can be > a

Re: server: Only require REG_OPTION_VOLATILE when creating a new key.

2009-11-23 Thread Paul Vriens
Hi Alexandre, With this patch the following errors are introduced when starting anything on a clean .wine : err:setupapi:registry_callback could not create key 0x8002 L"HARDWARE\\DEVICEMAP\\PARALLEL PORTS" err:setupapi:registry_callback could not create key 0x8002 L"HARDWARE\\DEVICEM

Re: Add .cvsignore entries for .fake files

2009-11-23 Thread Paul Chitescu
On Friday 20 November 2009 05:43:48 pm Charles Davis wrote: > Paul Chitescu wrote: > > On Monday 16 November 2009 04:11:25 pm Paul Chitescu wrote: > >> Changelog: > >>Add .cvsignore entries for .fake files. > > > > What's wrong with this? Applies cleanly to my pristine wine-CVS, tried with >