Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Marcus Meissner
On Mon, Nov 16, 2009 at 11:29:51PM +0100, Ove Kaaven wrote: > Jacek Caban skrev: > > Well, I hope that a side effect of installation during wineprefix > > creation is that it will force packagers to package gecko > > You can't *force* the creation of packages which would likely fail to > meet the

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Vincent Povirk
On Mon, Nov 16, 2009 at 5:52 PM, Ove Kaaven wrote: > (It is actually for similar reasons that binaries must be buildable on a > clean system (say, a build daemon), without any special (non-free) tools > or sourceless libraries. Magic libshell32.a in the source package fails > this requirement, and

Re: [RFC] Handle process token groups in server/file.c::sd_to_mode

2009-11-16 Thread Ben Peddell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Rob Shearman wrote: > While I agree that there is a problem that needs to be fixed, I'm not > sure this is the right approach. I think you need to take a step back > and consider the meanings of the different SIDs in a token by default > and how they m

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Ben Klein
2009/11/17 Juan Lang : >> However, I refuse to force the Wine >> package to depend on it because this wine-gecko-1.0 package doubles >> the required download (7.8MB wine-gecko-1.0, 7.8MB wine 1.1.33 >> package). I realise that this will not be required to download on >> every upgrade, but I also ca

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Ove Kaaven
Jacek Caban skrev: > Ove Kaaven wrote: >> Jacek Caban skrev: >> >>> Well, I hope that a side effect of installation during wineprefix >>> creation is that it will force packagers to package gecko >>> >> >> You can't *force* the creation of packages which would likely fail to >> meet the req

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Juan Lang
> However, I refuse to force the Wine > package to depend on it because this wine-gecko-1.0 package doubles > the required download (7.8MB wine-gecko-1.0, 7.8MB wine 1.1.33 > package). I realise that this will not be required to download on > every upgrade, but I also can't predict when wine-gecko

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Ben Klein
2009/11/17 Jacek Caban : > I can see three types of Wine users: > > - regular users > They use Wine packages that should guarantee presence of Gecko (as Wine > dependency or in Wine package, depends on packagers preferences). The > current situation will probably force packagers to do the right thi

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Steven Edwards
On Mon, Nov 16, 2009 at 12:58 PM, Jacek Caban wrote: > You should understand, that we don't want users to have problems due to > *lack* of Gecko. Any solution like moving installation to winecfg means that > most user (at least these, who don't get Gecko from their distro packages) > will have thi

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Jacek Caban
Ove Kaaven wrote: Jacek Caban skrev: Well, I hope that a side effect of installation during wineprefix creation is that it will force packagers to package gecko You can't *force* the creation of packages which would likely fail to meet the requirements for inclusion into Debian's main

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Ove Kaaven
Jacek Caban skrev: > Well, I hope that a side effect of installation during wineprefix > creation is that it will force packagers to package gecko You can't *force* the creation of packages which would likely fail to meet the requirements for inclusion into Debian's main archive. Even if I didn't

Re: [PATCH] jscript: Implement decodeURIComponent

2009-11-16 Thread Andrew Eikum
Jacek Caban wrote: Hi Andrew, Andrew Eikum wrote: --- dlls/jscript/global.c | 104 - dlls/jscript/tests/api.js | 20 + 2 files changed, 122 insertions(+), 2 deletions(-) +while(*ptr == '%') { +if(hex_t

Re: [PATCH] jscript: Implement decodeURIComponent

2009-11-16 Thread Jacek Caban
Hi Andrew, Andrew Eikum wrote: --- dlls/jscript/global.c | 104 - dlls/jscript/tests/api.js | 20 + 2 files changed, 122 insertions(+), 2 deletions(-) +while(*ptr == '%') { +if(hex_to_int(*(ptr+1)) < 0

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Jacek Caban
joerg-cyril.hoe...@t-systems.com wrote: Jacek, - I tried to think positively about it and expected the winetest-1.1.33.exe to install Gecko and perform the mshtml tests when online. Curiously they were skipped. I have yet to find out why. Did you read the page from the link that

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Joerg-Cyril.Hoehle
Jacek, >> - I tried to think positively about it and expected the winetest-1.1.33.exe >> to install Gecko and perform the mshtml tests when online. Curiously they >> were skipped. I have yet to find out why. >Did you read the page from the link that is on the dialog informing >about missing

Re: WineD3D: fix bug 20522

2009-11-16 Thread Alexandre Julliard
Roderick Colenbrander writes: > This patch fixes bug 20522 which was uncovered by 32-bit dibsection > support. I have added a test to show that the patch is correct. Like > with Blt the results varry depending on the drivers. It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Jacek Caban
Marcus Meissner wrote: On Mon, Nov 16, 2009 at 05:08:21PM +0100, Jacek Caban wrote: Well, I hope that a side effect of installation during wineprefix creation is that it will force packagers to package gecko The brutal true is that we had a very bad situation for a long time. I can see three

Re: [RFC] Handle process token groups in server/file.c::sd_to_mode

2009-11-16 Thread Rob Shearman
2009/11/16 Ben Peddell : > This proposed patch (which I believe will contribute toward solving bugs > 17672, 19588 and 20643, and any others where the permissions are set too > restrictive) exposes the token_sid_present call in token.c, > and uses it to check the SIDs in the security descriptor aga

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Marcus Meissner
On Mon, Nov 16, 2009 at 05:08:21PM +0100, Jacek Caban wrote: > Well, I hope that a side effect of installation during wineprefix > creation is that it will force packagers to package gecko The > brutal true is that we had a very bad situation for a long time. I > can see three types of Wine users:

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Jacek Caban
Tom Wickline wrote: Jacek, How does this work off line? If Wine cant download and install gecko at wineprefix creation then Wine wont work? And if so every time you create a wineprefix your going to have to be connected and the server is going to have to be up 100% of the time or Wine wont pr

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Jacek Caban
Steven Edwards wrote: Hi Jacek, On Mon, Nov 16, 2009 at 10:16 AM, Jacek Caban wrote: Did you read the page from the link that is on the dialog informing about missing Gecko? I've been kind of following this thread and see where Jörg is coming from. I don't think the argument about br

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Tom Wickline
On Mon, Nov 16, 2009 at 11:38 PM, Steven Edwards wrote: > Hi Jacek, > > On Mon, Nov 16, 2009 at 10:16 AM, Jacek Caban > wrote: > > Did you read the page from the link that is on the dialog informing about > > missing Gecko? > > I've been kind of following this thread and see where Jörg is coming

[RFC] Handle process token groups in server/file.c::sd_to_mode

2009-11-16 Thread Ben Peddell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This proposed patch (which I believe will contribute toward solving bugs 17672, 19588 and 20643, and any others where the permissions are set too restrictive) exposes the token_sid_present call in token.c, and uses it to check the SIDs in the security

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Steven Edwards
Hi Jacek, On Mon, Nov 16, 2009 at 10:16 AM, Jacek Caban wrote: > Did you read the page from the link that is on the dialog informing about > missing Gecko? I've been kind of following this thread and see where Jörg is coming from. I don't think the argument about broken wine due to missing gecko

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Jacek Caban
joerg-cyril.hoe...@t-systems.com wrote: Hi, wine cmd /c echo yes now downloads gecko. Me to -- I'm not pleased with Wine-1.1.33 starting an installation request upon startup. - How am I going to automate regression testing when it hangs waiting for a mouse click? - I tried to think

today's git broke winetricks gecko :-(

2009-11-16 Thread Joerg-Cyril.Hoehle
Hi, >wine cmd /c echo yes now downloads gecko. Me to -- I'm not pleased with Wine-1.1.33 starting an installation request upon startup. - How am I going to automate regression testing when it hangs waiting for a mouse click? - I tried to think positively about it and expected the winetest-1.1.3

Re: comctl32/listview: use the infile ImageListRelease

2009-11-16 Thread André Hentschel
Nikolay Sivov schrieb: > Hi, Andre. > > Could you please wait with that? I have some similar patches already sent... > > On 11/16/09, André Hentschel wrote: >> Otherwise Apps crash on exit(e.g. uninstaller) >> --- >> dlls/comctl32/imagelist.c |3 ++- >> 1 files changed, 2 insertions(+), 1 d

Re: [PATCH 2/2] dsound: Simplify duplex code

2009-11-16 Thread Alexandre Julliard
Maarten Lankhorst writes: > @@ -48,37 +50,20 @@ typedef struct IDirectSoundFullDuplexImpl > > /* IDirectSoundFullDuplexImpl fields */ > DirectSoundDevice*renderer_device; > -DirectSoundCaptureDevice *capture_device; > - > -LPUNKNOWN

Re: [PATCH 1/3] user32: Free window text to prevent leak in case whenWM_NCDESTROY doesn't get to default procedure

2009-11-16 Thread Nikolay Sivov
The only case why I left it was that I thought about app that directly sends this message for some insane reason. I just don't want to touch default handler. On 11/16/09, Dmitry Timoshkov wrote: > "Nikolay Sivov" wrote: > >> This fixes a leak spotted by valgrind. >> >> Changelog: >>- free wi

Re: comctl32/listview: use the infile ImageListRelease

2009-11-16 Thread Nikolay Sivov
Hi, Andre. Could you please wait with that? I have some similar patches already sent... On 11/16/09, André Hentschel wrote: > Otherwise Apps crash on exit(e.g. uninstaller) > --- > dlls/comctl32/imagelist.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/com

Re: [PATCH] winex11.drv: check for org = NULL (Coverity)

2009-11-16 Thread Roderick Colenbrander
On Mon, Nov 16, 2009 at 11:02 AM, Marcus Meissner wrote: > On Sun, Nov 15, 2009 at 10:37:27PM +0100, Roderick Colenbrander wrote: >> Hi Marcus, >> >> A couple of hours ago I submitted a patch rewrites the function. It >> suffers from the same 'issue'. This and any other wgl function are >> called

Re: [PATCH] winex11.drv: check for org = NULL (Coverity)

2009-11-16 Thread Marcus Meissner
On Sun, Nov 15, 2009 at 10:37:27PM +0100, Roderick Colenbrander wrote: > Hi Marcus, > > A couple of hours ago I submitted a patch rewrites the function. It > suffers from the same 'issue'. This and any other wgl function are > called from gdi32/opengl.c which perform magic to arrive here and in >

Re: Working on avifil32, sudden "non enough memory" error

2009-11-16 Thread Marcus Meissner
On Mon, Nov 16, 2009 at 10:52:04AM +0100, Julius Schwartzenberg wrote: > Dan Kegel wrote: > >Julius wrote: > >>With one file however (GOODTIME.AVI from the win95 cd) I get this > >>error after about a second: > >>err:heap:HEAP_ValidateInUseArena Heap 0x11: in-use arena 0x184420 > >>next block h

Re: Working on avifil32, sudden "non enough memory" error

2009-11-16 Thread Julius Schwartzenberg
Dan Kegel wrote: Julius wrote: With one file however (GOODTIME.AVI from the win95 cd) I get this error after about a second: err:heap:HEAP_ValidateInUseArena Heap 0x11: in-use arena 0x184420 next block has PREV_FREE flag non enough memory I have no idea where this comes from and why it happ

Re: [RFC] Extended Attributes for Dos Attributes, Creation Time, etc.

2009-11-16 Thread Ben Peddell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dan Kegel wrote: > Hi Ben, > did you see > http://bugs.winehq.org/show_bug.cgi?id=15679 > http://www.winehq.org/pipermail/wine-patches/2009-October/079842.html > ? > > IMHO the way the Samba sources merged the fd and filename > version of the calls ma