Re: user32: Destroy EDITSTATE structure in the WM_NCDESTROY messageprocessing

2009-11-15 Thread Dmitry Timoshkov
"Ilya Shpigor" wrote: +SendMessageA(hWnd, WM_SETTEXT, 0, (LPARAM)str); +SendMessageA(hWnd, WM_GETTEXT, MAXLEN, (LPARAM)buf); +ok(!lstrcmp(buf, str), "Wrong contents of edit: %s\n", buf); +lstrcpy(buf, ""); +SendMessageA(hWnd, WM_DESTROY, 0, 0); +SendMessageA(hWnd, WM_GET

Re: [PATCH 1/3] user32: Free window text to prevent leak in case whenWM_NCDESTROY doesn't get to default procedure

2009-11-15 Thread Dmitry Timoshkov
"Nikolay Sivov" wrote: This fixes a leak spotted by valgrind. Changelog: - free window text to prevent leak in case when WM_NCDESTROY doesn't get to default procedure Then WM_NCDESTROY handler should be removed from DefWindowProc to avoid a confusing duplication. -- Dmitry.

re: [RFC] Extended Attributes for Dos Attributes, Creation Time, etc.

2009-11-15 Thread Dan Kegel
Hi Ben, did you see http://bugs.winehq.org/show_bug.cgi?id=15679 http://www.winehq.org/pipermail/wine-patches/2009-October/079842.html ? IMHO the way the Samba sources merged the fd and filename version of the calls makes for less duplication of code. (I tried to do it the other way first, and it

[Fwd: Interesting Problem Building Wine for Regression Test]

2009-11-15 Thread James McKenzie
All: I continue to work with Tony Rollo's code as presented in bug 6254. I've found a problem with Wordpad's Print Preview between wine-1.1.10 and wine-1.1.11 and I attempted to run a regression test and end up with errors in makedep.c as follows: makedep.c:21:20: error: config.h: No such file or

Re: winscard: add pcsc-lite helpers for upcoming(?) implementation

2009-11-15 Thread Juan Lang
> To my knowledge the integration of the patches by Mounir IDRASSI has been > rejected due to missing automated tests. This is a problem since for a full > test someone has to write/provide an IFD handler which emulates some stuff. IIRC, there was also a problem with the way it integration was don

Interesting Problem Building Wine for Regression Test

2009-11-15 Thread James McKenzie
All: I continue to work with Tony Rollo's code as presented in bug 6254. I've found a problem with Wordpad's Print Preview between wine-1.1.10 and wine-1.1.11 and I attempted to run a regression test and end up with errors in makedep.c as follows: makedep.c:21:20: error: config.h: No such file or

[RFC] Extended Attributes for Dos Attributes, Creation Time, etc.

2009-11-15 Thread Ben Peddell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 What are your thoughts on using Extended Attributes for items such as: * Dos Attributes (like samba's "store dos attributes = yes") * File Creation Times (like samba's proposed user.crtime) * An option for alternate storage of NT ACLs (like samba's "vf

Re: wined3d: Fix some typos

2009-11-15 Thread Roderick Colenbrander
Hi Anders, Your patch changes to two different dlls in one patch. In general a patch should only change one thing. It would be nice if you could separate it because else I'm not sure if it will be added. Roderick On Sun, Nov 15, 2009 at 9:12 PM, Anders Jonsson wrote: > Fixes some typos in comc

Re: [PATCH] winex11.drv: check for org = NULL (Coverity)

2009-11-15 Thread Roderick Colenbrander
Hi Marcus, A couple of hours ago I submitted a patch rewrites the function. It suffers from the same 'issue'. This and any other wgl function are called from gdi32/opengl.c which perform magic to arrive here and in case of wglsharelists it also performs the filtering. Roderick On Sun, Nov 15, 20

Implementing a cooling-off list in the heap

2009-11-15 Thread Dan Kegel
Valgrind has a nice option --freelist_vol which is the total size of blocks to hold on the freed block queue. It does this to help detect double free errors. Where in Wine's heap would one want to keep a free list like that? My first idea is to just add another element to the freeList array; rat

Re: ddraw/tests: Add test for refcounts of surface objects.

2009-11-15 Thread Vincent Povirk
Ah, I only checked refcount.c. On Sun, Nov 15, 2009 at 2:12 PM, Stefan Dösinger wrote: > > Am 15.11.2009 um 20:55 schrieb Vincent Povirk: > >> >> >> <0001-ddraw-tests-Add-test-for-refcounts-of-surface-object.txt> > I think we already have tests for that - see IFaceRefCount() in dsurface.c > > > >

Re: ddraw/tests: Add test for refcounts of surface objects.

2009-11-15 Thread Stefan Dösinger
Am 15.11.2009 um 20:55 schrieb Vincent Povirk: > > > <0001-ddraw-tests-Add-test-for-refcounts-of-surface-object.txt> I think we already have tests for that - see IFaceRefCount() in dsurface.c

Re: winscard: add pcsc-lite helpers for upcoming(?) implementation

2009-11-15 Thread Heiko Nardmann
To my knowledge the integration of the patches by Mounir IDRASSI has been rejected due to missing automated tests. This is a problem since for a full test someone has to write/provide an IFD handler which emulates some stuff. So far I haven't found some kind of virtual card reader - maybe attach

Re: shell32/tests: Fix Program Manager DDE Conformance Test Failues

2009-11-15 Thread Greg Geldorp
> I think you misunderstood me. The window is created but as you're > searching for a "Startup" window's title it fails on localized > systems. So the test is not completely correct and only work on > English system. That's why I proposed to skip the two tests on (and > only on) such systems. I ha

re: Working on avifil32, sudden "non enough memory" error

2009-11-15 Thread Dan Kegel
Julius wrote: >With one file however (GOODTIME.AVI from the win95 cd) I get this > error after about a second: > err:heap:HEAP_ValidateInUseArena Heap 0x11: in-use arena 0x184420 > next block has PREV_FREE flag > non enough memory > > I have no idea where this comes from and why it happens. (It

Re: shell32/tests: Fix Program Manager DDE Conformance Test Failures

2009-11-15 Thread Nicolas Le Cam
2009/11/15 Mikey Alexander : > You really don't want to skip this one as the api is supposed to create the > window, but you can't be absolutely sure it is a failure, hence the error > message being what it is.  If you are going to skip the timeout if it fails, > why bother checking for the wind

Working on avifil32, sudden "non enough memory" error

2009-11-15 Thread Julius Schwartzenberg
Hi, I'm working on fixing some things in avifil32. Several problems should be gone when using the attached four patches and most AVI files play back properly. With one file however (GOODTIME.AVI from the win95 cd) I get this error after about a second: err:heap:HEAP_ValidateInUseArena Heap 0

Re: avifile bugfixes

2009-11-15 Thread Julius Schwartzenberg
Detlef Riekenberg wrote: On Di, 2009-11-10 at 00:43 +0100, Julius Schwartzenberg wrote: I will add tests to show this and submit the patches then. I created a test for avifil32 in June 2008, but it was not comitted. ( http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html ) Thank

Re: shell32/tests: Fix Program Manager DDE Conformance Test Failures

2009-11-15 Thread Mikey Alexander
You really don't want to skip this one as the api is supposed to create the window, but you can't be absolutely sure it is a failure, hence the error message being what it is. If you are going to skip the timeout if it fails, why bother checking for the window creation at all? The real questio

Re: user32/tests: Test edit control to WM_GETTEXT processing after WM_DESTROY

2009-11-15 Thread Ilya Shpigor
Please don't commit this test. Instead use or comment next try: user32: Destroy EDITSTATE structure in the WM_NCDESTROY message processing -- Best regards, Ilya Shpigor.