On Wed, Nov 11, 2009 at 11:05:49AM +1100, Ben Klein wrote:
> 2009/11/11 Michael Stefaniuc :
> > For fedora it will not be possible to do a special 32bit compile on the
> > x86_64
> > arch.
>
> Wait ... no gcc -m32 on Fedora x86_64?
>
> > Hence the only way is to have the default x86_32 version a
is wrong because it changes offsets... but it also breaks
those comments. (Can you put the vtable at the end?)
In comctl32 v6, IImageList and HIMAGELIST are the same thing. See, for
instance, http://msdn.microsoft.com/en-us/library/bb762185%28VS.85%29.aspx:
"The IImageList pointer type, suc
As Nikolay pointed out, the change
> /* the ones with offsets at the end are the same as in Windows */
> struct _IMAGELIST
> {
>+const struct IImageListVtbl *lpVtbl;/* IImageList vtable */
>+LONGref;/* reference count */
>+
> DWORD magic;
On Wed, Nov 11, 2009 at 12:11 AM, Owen Rudge wrote:
> ---
> dlls/comctl32/imagelist.c | 322
> -
> dlls/comctl32/imagelist.h | 3 +
> 2 files changed, 319 insertions(+), 6 deletions(-)
>
After that:
---
diff --git a/dlls/comctl32/imagelist.h b/dlls
Alexandre Julliard wrote:
> chris ahrendt writes:
>
>> Well its been a few since I ran CPP Check and so I ran it today and got the
>> following:
>>
>> New CPP Check Errors for the Wine Code:
>>
>> [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error)
>> Uninitialized variable: bmi_
> This patch suggest that one of the previous patches in this series makes
> the tests succeed or actually fail as they are inside a todo_wine().
The previous patch is the one that makes the tests succeed. I split the
todo_wine removal from the tests due to the modifications being in separate
p
2009/11/11 Michael Stefaniuc :
> For fedora it will not be possible to do a special 32bit compile on the x86_64
> arch.
Wait ... no gcc -m32 on Fedora x86_64?
> Hence the only way is to have the default x86_32 version and a x86_64
> version to be parallel installable. While it may be possible to
2009/11/10 Michael Stefaniuc :
> Uwe Bonnes wrote:
>> Did nobody of the packages test what they did?
> It is easy to miss as it requires:
> - Fresh install of Wine (via PackageKit or yum install) and
> - Old 32-bit WINEPREFIX.
Except that it's obvious that the packagers are not people who USE
wine
On Di, 2009-11-10 at 00:43 +0100, Julius Schwartzenberg wrote:
> I will add tests to show this and submit the patches then.
I created a test for avifil32 in June 2008, but it was not comitted.
( http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html )
The bug 14085 was created to docu
2009/11/10 Stefan Leichter :
> When reviewing the patch i found two line containing only spaces. But this are
> to my understanding no "whitespace errors". Can you please tell me what else
> you have seen ?
>
That counts as trailing spaces. Note that git apply warns about white
space errors by defa
Am Tuesday 10 November 2009 10:09:22 schrieb Henri Verbeet:
> 2009/11/9 Stefan Leichter :
> > my crystal ball is still not working, therefore resending unchanged
>
> Try http://source.winehq.org/patches/
>
> And indeed, the patch doesn't apply:
>
> diff -urw wine-git/dlls/setupapi/install.c
> wine-
On 11/10/2009 07:12 PM, Owen Rudge wrote:
---
dlls/comctl32/tests/imagelist.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Hi Owen,
This patch suggest that one of the previous patches in this series makes
the tests succeed or actually fail as they are inside a todo_wine().
-
Stefan Leichter writes:
> Am Tuesday 10 November 2009 10:09:22 schrieb Henri Verbeet:
>> 2009/11/9 Stefan Leichter :
>> > my crystal ball is still not working, therefore resending unchanged
>>
>> Try http://source.winehq.org/patches/
>>
>> And indeed, the patch doesn't apply:
>>
>> diff -urw wine
On 11/05/2009 07:11 PM, Juan Lang wrote:
--Juan
Hi Juan,
This one introduces some test failures on Win9x and WinMe:
http://test.winehq.org/data/tests/rsaenh:rsaenh.html
Could you have a look?
--
Cheers,
Paul.
On 11/07/2009 03:55 PM, Rob Shearman wrote:
---
dlls/rpcrt4/tests/server.c |3 ++
dlls/rpcrt4/tests/server.idl |2 +
tools/widl/header.c | 68 ++---
tools/widl/parser.l |1 +
tools/widl/parser.y | 12 +--
On 11/07/2009 01:29 PM, Rob Shearman wrote:
---
dlls/oledb32/tests/Makefile.in |5 +-
dlls/oledb32/tests/marshal.c | 272
2 files changed, 275 insertions(+), 2 deletions(-)
create mode 100644 dlls/oledb32/tests/marshal.c
Hi Rob,
The test r
Am Tuesday 10 November 2009 10:09:22 schrieb Henri Verbeet:
> 2009/11/9 Stefan Leichter :
> > my crystal ball is still not working, therefore resending unchanged
>
> Try http://source.winehq.org/patches/
>
> And indeed, the patch doesn't apply:
>
> diff -urw wine-git/dlls/setupapi/install.c
> wine-
On Mon, Nov 09, 2009 at 04:53:31PM +0100, Uwe Bonnes wrote:
> > "Henri" == Henri Verbeet writes:
>
> Henri> 2009/11/9 Uwe Bonnes :
> >> Can anybody help with the flaw in my implementation? Or did anything
> >> change in wine?
> >>
> Henri> I'm not sure if anything changed
--- Begin Message ---
Hi there,
thanks for reporting the bug regarding the 64bit wine in bugzilla.
I am quite aware of the problem as I get requests about trouble myself. Could
you please give some more insight into the way stuff is developing in the wine
area regarding future use of 64bit versio
Vitaliy Margolen wrote:
> Charles Davis wrote:
>> Also, add stub handlers in mountmgr.
>>
>> This patch fixes an issue with the previous one where wine would hang if
>> ntoskrnl got a STATUS_BUFFER_OVERFLOW back from thes server.
>> ---
>
>> +int suspend_thread( struct thread *thread );
>> +int re
On 11/10/2009 12:56 PM, joerg-cyril.hoe...@t-systems.com wrote:
Hi,
same patch as yesterday, with more spaces and volatile and mciSave fix thrown
out.
I was about to resend
[PATCH 2] winmm: MCI Close all causes one notification per open driver.
which I rebased as well when I realised that it's
chris ahrendt writes:
> Well its been a few since I ran CPP Check and so I ran it today and got the
> following:
>
> New CPP Check Errors for the Wine Code:
>
> [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error)
> Uninitialized variable: bmi_buf
> [/home/cahrendt/wine-git/dlls/n
Uwe Bonnes wrote:
>> "Michael" == Michael Stefaniuc writes:
>
> Michael> Fedora includes now a 64-bit Wine package (at least in F11)
> Michael> which of course breaks existing Wine setups. "yum install wine"
> Michael> will install the 64-bit version... Looks like we had our
>
On Tue, Nov 10, 2009 at 1:48 PM, Uwe Bonnes
wrote:
>> "Michael" == Michael Stefaniuc writes:
>
> Michael> Fedora includes now a 64-bit Wine package (at least in F11)
> Michael> which of course breaks existing Wine setups. "yum install wine"
> Michael> will install the 64-bit version.
> "Michael" == Michael Stefaniuc writes:
Michael> Fedora includes now a 64-bit Wine package (at least in F11)
Michael> which of course breaks existing Wine setups. "yum install wine"
Michael> will install the 64-bit version... Looks like we had our
Michael> WineConf too late f
Austin English wrote:
> On Mon, Nov 9, 2009 at 5:54 PM, Michael Stefaniuc wrote:
>> Fedora includes now a 64-bit Wine package (at least in F11) which of course
>> breaks existing Wine setups. "yum install wine" will install the 64-bit
>> version... Looks like we had our WineConf too late for this.
2009/11/9 Stefan Leichter :
> my crystal ball is still not working, therefore resending unchanged
>
Try http://source.winehq.org/patches/
And indeed, the patch doesn't apply:
diff -urw wine-git/dlls/setupapi/install.c wine-build/dlls/setupapi/install.c
--- a/wine-git/dlls/setupapi/install.c
+++ b
27 matches
Mail list logo
