Re: [PATCH 4] mciwave: Rework MCI notification system.

2009-11-09 Thread Vitaliy Margolen
Vitaliy Margolen wrote: > joerg-cyril.hoe...@t-systems.com wrote: >> +HANDLE old = InterlockedExchangePointer(&wmw->hCallback, NULL); >> +if (old) mciDriverNotify(old,wDevID,MCI_NOTIFY_SUPERSEDED); >> +mciDriverNotify(HWND_32(LOWORD(hWndCallBack)),wDevID,wStatus); > Here and everywhere

Re: [PATCH] server, ntoskrnl: Implement support for IRP_MJ_CREATE requests.

2009-11-09 Thread Vitaliy Margolen
Charles Davis wrote: > Also, add stub handlers in mountmgr. > > This patch fixes an issue with the previous one where wine would hang if > ntoskrnl got a STATUS_BUFFER_OVERFLOW back from thes server. > --- > +int suspend_thread( struct thread *thread ); > +int resume_thread( struct thread *thread

Re: ntdll: fix memory leak in GetDiskFreeSpaceW

2009-11-09 Thread Vitaliy Margolen
Dan Kegel wrote: > Found while valgrinding chromium's app_unittests. > > + done: > +RtlFreeHeap(GetProcessHeap(), 0, val.Buffer); > + You should us RtlFreeUnicodeString( &val ); instead. Vitaliy.

Multithreaded debugging

2009-11-09 Thread Peter Urbanec
Eric Pouech wrote: Peter Urbanec a écrit : It can't be as simple as updating the value of dbg_curr_thread with the result of dbg_get_thread(dbg_curr_process, tid) and then calling GetThreadContext(dbg_curr_thread->handle, &dbg_context), can it? the changes will need to be larger than that wi

Re: Wine 64-bit in Fedora ...

2009-11-09 Thread Austin English
On Mon, Nov 9, 2009 at 5:54 PM, Michael Stefaniuc wrote: > Fedora includes now a 64-bit Wine package (at least in F11) which of course > breaks existing Wine setups. "yum install wine" will install the 64-bit > version... Looks like we had our WineConf too late for this. > > I have opened https://

Wine 64-bit in Fedora ...

2009-11-09 Thread Michael Stefaniuc
Fedora includes now a 64-bit Wine package (at least in F11) which of course breaks existing Wine setups. "yum install wine" will install the 64-bit version... Looks like we had our WineConf too late for this. I have opened https://bugzilla.redhat.com/show_bug.cgi?id=533988 for this problem.

avifile bugfixes

2009-11-09 Thread Julius Schwartzenberg
Here are some bugfixes for avifile that Maarten mainly did during WineConf. The behaviour corresponds to what native avifil32 does. I will add tests to show this and submit the patches then. (Maybe avifil32 does a few more hacks like these, I'll add those too when I find them when creating test

Re: Question about GetTokenInformation and memory leaks

2009-11-09 Thread Reece Dunn
2009/11/9 Dan Kegel : > I've never used the security apis, so I'm pretty unfamiliar with them. > Valgrinding chromium's sandbox_unittests.exe shows the leak > > (I think the code leaks token_handle, but fixing > that doesn't get rid of the reported leak.) token_handle does not leak -- access_token

Re: Question about GetTokenInformation and memory leaks

2009-11-09 Thread Rob Shearman
2009/11/9 Dan Kegel : > I've never used the security apis, so I'm pretty unfamiliar with them. > Valgrinding chromium's sandbox_unittests.exe shows the leak > > 16 bytes in 1 blocks are definitely lost in loss record 123 of 728 >   at RtlAllocateHeap (heap.c:1423) >   by RtlAllocateAndInitializeSid

Question about GetTokenInformation and memory leaks

2009-11-09 Thread Dan Kegel
I've never used the security apis, so I'm pretty unfamiliar with them. Valgrinding chromium's sandbox_unittests.exe shows the leak 16 bytes in 1 blocks are definitely lost in loss record 123 of 728 at RtlAllocateHeap (heap.c:1423) by RtlAllocateAndInitializeSid (sec.c:156) by NtQueryInfor

Re: Question on using winedbg when program does not crash, just becomes unresponsive

2009-11-09 Thread Eric Pouech
Peter Urbanec a écrit : Dan Kegel wrote: start winedbg without any app say 'bt all' in winedbg Voila, you now have backtraces for every process, including the hung one. It's your job to get that into a text file and remove the uninteresting ones... I've also been trying to debug a mult

Re: The user32/win test crashes X on Intel cards

2009-11-09 Thread Reece Dunn
2009/11/9 : > Hi, > >>Marcus got the same issue and he had an Intel card too > > Charles Davis wrote: >>This happens on Mac OS X, too. Check out >>http://xquartz.macosforge.org/trac/ticket/293 > > Charles forgot to mention that it affects NVidia on the Mac, which I did > not explicitly write in th

Re: To error out or to skip tests?

2009-11-09 Thread Reece Dunn
2009/11/9 : > Reece, > > I think we reached agreement on: > a) Tests should "usually" succeed. > b) machines without sound are usual (e.g. in virtual server env.). > c) I'll modify the MCI tests to succeed on machines without sound. > But for some other points, I've trouble following you. Yes. >

Re: To error out or to skip tests?

2009-11-09 Thread Reece Dunn
2009/11/9 Paul Vriens : > On 11/09/2009 07:25 PM, joerg-cyril.hoe...@t-systems.com wrote: >> >> Reece, >> >> I think we reached agreement on: >> a) Tests should "usually" succeed. > > I didn't read that in any of the emails. Tests should always succeed. the > broken() and skip() will help in achiev

The user32/win test crashes X on Intel cards

2009-11-09 Thread Joerg-Cyril.Hoehle
Hi, >Marcus got the same issue and he had an Intel card too Charles Davis wrote: >This happens on Mac OS X, too. Check out >http://xquartz.macosforge.org/trac/ticket/293 Charles forgot to mention that it affects NVidia on the Mac, which I did not explicitly write in the above bug report (the Mac

Re: To error out or to skip tests?

2009-11-09 Thread Paul Vriens
On 11/09/2009 07:25 PM, joerg-cyril.hoe...@t-systems.com wrote: Reece, I think we reached agreement on: a) Tests should "usually" succeed. I didn't read that in any of the emails. Tests should always succeed. the broken() and skip() will help in achieving that. The point is, if the machine

To error out or to skip tests?

2009-11-09 Thread Joerg-Cyril.Hoehle
Reece, I think we reached agreement on: a) Tests should "usually" succeed. b) machines without sound are usual (e.g. in virtual server env.). c) I'll modify the MCI tests to succeed on machines without sound. But for some other points, I've trouble following you. >> The relevant question becomes

Re: Question on using winedbg when program does not crash, just becomes unresponsive

2009-11-09 Thread Peter Urbanec
Dan Kegel wrote: start winedbg without any app say 'bt all' in winedbg Voila, you now have backtraces for every process, including the hung one. It's your job to get that into a text file and remove the uninteresting ones... I've also been trying to debug a multithreaded app. There are at

Re: Infinite loop with translation DLL

2009-11-09 Thread Uwe Bonnes
> "Henri" == Henri Verbeet writes: Henri> 2009/11/9 Uwe Bonnes : >> Can anybody help with the flaw in my implementation? Or did anything >> change in wine? >> Henri> I'm not sure if anything changed there recently, or if that's Henri> even supposed to work, but I supp

Re: Infinite loop with translation DLL

2009-11-09 Thread Henri Verbeet
2009/11/9 Uwe Bonnes : > Can anybody help with the flaw in my implementation? Or did anything change > in wine? > I'm not sure if anything changed there recently, or if that's even supposed to work, but I suppose that one way to solve the problem would be to load the linux library dynamically with

Re: [PATCH 4] mciwave: Rework MCI notification system.

2009-11-09 Thread Vitaliy Margolen
joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > + * Notifications in MCI work like a 1-element queue. > + * Each new notification request supersedes the previous one. > +volatile HANDLEhCallback; /* Callback handle for > pending notification */ You do not need volatile her

re: Question on using winedbg when program does not crash, just becomes unresponsive

2009-11-09 Thread Dan Kegel
Susan asked: > [What can you do to get a backtrace of a hung app that won't hang when you > run it in winedbg?] I ran into this last week and added a note to http://wiki.winehq.org/Backtraces "Alternately, instad of info process / attach, you can do 'bt all' to get backtraces of all threads in

Re: To error out or to skip tests?

2009-11-09 Thread Reece Dunn
2009/11/9 : > Reece Dunn wrote: > >>> The question remains: >>> a) turn sound tests red on machines without sound (with 1 >>error only); >>> b) turn them blue (clearly marking skipped tests) >>> c) turn them green -- status quo (for dsound.ok and wave.ok). > >> 310     ok(!err,"mci open waveaudio!

Question on using winedbg when program does not crash, just becomes unresponsive

2009-11-09 Thread Susan Cragin
There is some sort of memory leak in Dragon NaturallySpeaking that makes the program become unresponsive (but not crash) after some minutes of using the Dictation Box. I have tried winedbg, SetOnFirstBreak but the program never actually crashes. Without SOFB, of course, winedbg goes for the fir

Re: To error out or to skip tests?

2009-11-09 Thread Reece Dunn
2009/11/9 : > Hi, > > Paul Vriens wrote: >>In my opinion the main purpose for skip() is to not run tests for >>legitimate reasons. > Alas, this sentence and the examples you give do not explain to me why > to use skip instead of e.g. trace + return. What is the added value? > What to do about that

To error out or to skip tests?

2009-11-09 Thread Joerg-Cyril.Hoehle
Hi, Paul Vriens wrote: >In my opinion the main purpose for skip() is to not run tests for >legitimate reasons. Alas, this sentence and the examples you give do not explain to me why to use skip instead of e.g. trace + return. What is the added value? What to do about that blue color or mention in

Re: To error out or to skip tests?

2009-11-09 Thread Kai Blin
On Friday 06 November 2009 13:21:45 joerg-cyril.hoe...@t-systems.com wrote: > The picture on test.winehq.org is a disaster: None of the w95, w98, nt4, > 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests! > They all have no sound configured. Mostly useless. By extension of your log

Re: To error out or to skip tests?

2009-11-09 Thread Paul Vriens
On 11/09/2009 11:27 AM, joerg-cyril.hoe...@t-systems.com wrote: Reece Dunn wrote: The question remains: a) turn sound tests red on machines without sound (with 1 error only); b) turn them blue (clearly marking skipped tests) c) turn them green -- status quo (for dsound.ok and wave.ok). 310

To error out or to skip tests?

2009-11-09 Thread Joerg-Cyril.Hoehle
Reece Dunn wrote: >> The question remains: >> a) turn sound tests red on machines without sound (with 1 >error only); >> b) turn them blue (clearly marking skipped tests) >> c) turn them green -- status quo (for dsound.ok and wave.ok). > 310 ok(!err,"mci open waveaudio!tempfile.wav returned

Infinite loop with translation DLL

2009-11-09 Thread Uwe Bonnes
Hello, around July 2009, I implemented a translation dll, allowing to run Win32 programms using ftd2xx.dll with Wine translating the calls to linux-libftd2xx. It was done while looking at dll/glu32. I was able to run mprog.exe (www.ftdichip.org) some time ago. Reapplying now, I hit an infinite lo