I've taken the following feedback on board and resubmitted the patch.
Andrew Eikum wrote:
This is less important, but you're not following the code conventions
of the surrounding code. The surrounding code does not have spaces
around function parameters, so yours shouldn't either.
The exist
On Wed, Nov 4, 2009 at 10:26 PM, Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: e1f3edef3e491095dd73548b711bddf14ee73ef0
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=e1f3edef3e491095dd73548b711bddf14ee73ef0
>
> Author: Owen Rudge
> Date: Mon Nov 2 10:58:2
2009/11/8 Dan Kegel :
> The key is to require no user choices -- just do the
> right thing by default. Then the user's level of education
> or computer skills don't matter.
E.g., convince distros to give Wine SOCKET_RAW access using file
capabilities by default?
On Sat, Nov 7, 2009 at 3:40 PM, James McKenzie
wrote:
> You really underestimate the stupidity of people.
I expect that people will do utterly stupid things,
there's no two ways around that, it's human nature.
That being the case, I think there are still opportunities
for providing a safe computi
Dan Kegel wrote:
> http://www.linuxinsider.com/rsstory/68566.html
>
> The article is about users who are willing to
> follow bogus instructions to solve a problem
> (or install something).
>
> It makes me want the average desktop to be
> really, really locked down... and for user-installed
> apps t
Well its been a few since I ran CPP Check and so I ran it today and got the
following:
New CPP Check Errors for the Wine Code:
[/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error) Uninitialized
variable: bmi_buf
[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource l
2009/11/7 Aric Stewart :
> ---
> dlls/msctf/tests/inputprocessor.c | 7 +--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
Here are the results for 100 consecutive runs :
$ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log 2>&1; done
$ grep "tests executed" msctf_tests.
2009/10/17 Marcus Meissner :
> Hi,
>
> Coverity spotted that this could lead to NULL dereference,
> and yes, the && should be ||.
This is not what was intended. The code inside the if block shouldn't
execute if assoc->NetworkOptions is NULL and NetworkOptions isn't and
vice-versa. The comparison s
2009/10/23 Dan Kegel :
> Hi folks,
> it's often been said that wine can't use libsmbclient because
> of license problems. I'd like to look at that assumption a bit.
>
> - What would wine like to use libsmbclient for, if it could?
>
> - Would it suffice to just link it in to wineserver, or would
>
Please disregard this. I was testing the wrong version on my winvista
machine and this causes a failure.
revised version coming.
-aric
Aric Stewart wrote:
---
dlls/msctf/tests/inputprocessor.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
-
2009/11/7 Aric Stewart :
> ---
> dlls/msctf/tests/inputprocessor.c | 5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>
>
>
>
>
Aric, is this for my versatile machine ?
--
Nicolas Le Cam
Am Friday 06 November 2009 21:49:26 schrieb lejcik:
> Signed-off-by: lejcik
> ---
> dlls/kernel32/nls/csy.nls | 38 +++---
> dlls/kernel32/nls/sky.nls | 42
> +-
> 2 files changed, 40 insertions(+), 40 deletions(-)
To ge
12 matches
Mail list logo
