Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()

2009-11-04 Thread Juan Lang
Hi Paul, I imagine this is to avoid checking prov if CryptAcquireContextW fails. In that case, wouldn't it be better to check the return value of CryptAcquireContextW? --Juan

Comment request: wineconsole: Fix Alt+F10 sent when F10 pressed.

2009-11-04 Thread Erich Hoover
I thought this patch was pretty straightforward, comments? http://www.winehq.org/pipermail/wine-patches/2009-October/080779.html Erich Hoover ehoo...@mines.edu

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

2009-11-04 Thread Reece Dunn
2009/11/4 Paul Vriens : > Hi, > > Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog > tests. I was sure I've tested these from Win95 up to Win7. > > When I run tests I want to do this as Administrator, so on Vista+ I select > 'Run as Administrator' to start a command prom

Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet

2009-11-04 Thread Eric Pouech
Paul Bolle a écrit : Add support for the qAttached packet. Main benefit is that if gdb was attached to a debuggee and it quits it will now ask if it should detach from the debuggee instead of asking whether the debuggee should be killed. (It still will ask whether the debuggee should be killed if

Re: Weird error for the advapi32/eventlog tests on Vista+ when running winetest

2009-11-04 Thread Reece Dunn
2009/11/4 Paul Vriens : > Hi, > > Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog > tests. I was sure I've tested these from Win95 up to Win7. > > When I run tests I want to do this as Administrator, so on Vista+ I select > 'Run as Administrator' to start a command prom

Weird error for the advapi32/eventlog tests on Vista+ when running winetest

2009-11-04 Thread Paul Vriens
Hi, Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog tests. I was sure I've tested these from Win95 up to Win7. When I run tests I want to do this as Administrator, so on Vista+ I select 'Run as Administrator' to start a command prompt, or to launch winetest. Ru

Re: winex11.drv: Implement FIXME in AlphaBlend

2009-11-04 Thread Roderick Colenbrander
Hi Peter, I didn't see this patch before because I was away at that time. The SourceConstantAlpha part looks correct to me. It might make sense to calculate blendfn.SourceConstantAlpha / 255 before the loop, so that it isn't recalculated each time. The other half of your patch is a separate chang

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-11-04 Thread Jacek Caban
Hi Nicolas, Nicolas Le Cam wrote: 2009/10/30 Jacek Caban : Hi Nicolas, Nicolas Le Cam wrote: Hi Jacek, Thanks for feedback. It should handle pointer in every corners IMHO, the left corner can cause failures in winetest. I'll try to find a better solution. Do you have any hints ?

Re: Please write audio tests (was: Playing ULAW sample correctly?)

2009-11-04 Thread Gert van den Berg
On Wed, Nov 4, 2009 at 12:48, wrote: > Hi, > >>1. generate a PCM sine wave tone (like winmm/tests/wave.c); > Actually any repetitive signal may not be good enough for general purpose, > sine or square.  Perhaps add some change in volume? > > For instance, there currently is a bug somewhere that c

Re: winmm/tests: Add MCI waveaudio tests.

2009-11-04 Thread Alexandre Julliard
writes: > +START_TEST(mci) > +{ > +HWND hwnd; > +hwnd = CreateWindowExA(0, "static", "winmm test", WS_POPUP, 0,0,100,100, > + 0, 0, 0, NULL); > +test_openCloseWAVE(hwnd); > +test_recordWAVE(hwnd); > +test_playWAVE(hwnd); > +test_asyncWAVE(hwnd); >

RE: how to install a windows service in wine?

2009-11-04 Thread Zhaohui Wang
Sorry, I didn't find the user list at the beginning, now I moved to there. -Original Message- From: Juan Lang [mailto:juan.l...@gmail.com] Sent: Tuesday, November 03, 2009 10:25 PM To: Zhaohui Wang Cc: wine-devel@winehq.org Subject: Re: how to install a windows service in wine? > I a

Re: mciwave: Use volatile on slot modified from recorder thread.

2009-11-04 Thread Alexandre Julliard
writes: > From b45e51940a42016e25a5c3a144968d81248927ed Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?J=C3=B6rg=20H=C3=B6hle?= > Date: Mon, 2 Nov 2009 23:49:42 +0100 > Subject: [PATCH] mciwave: Use volatile on slot modified from recorder thread. That's wrong. If there is proper synchronization you

Re: mciwave: Eliminate superfluous logs.

2009-11-04 Thread Alexandre Julliard
writes: > - WARN after ExitThread is superfluous (and not present in most other code) Most likely the ExitThread should be removed. -- Alexandre Julliard julli...@winehq.org

Please write audio tests (was: Playing ULAW sample correctly?)

2009-11-04 Thread Joerg-Cyril.Hoehle
Hi, >1. generate a PCM sine wave tone (like winmm/tests/wave.c); Actually any repetitive signal may not be good enough for general purpose, sine or square. Perhaps add some change in volume? For instance, there currently is a bug somewhere that causes Wine to repeat the first second of an intro